[coreboot-gerrit] Change in coreboot[master]: security/intel/stm: Add STM support

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )

Change subject: security/intel/stm: Add STM support
......................................................................

Patch Set 54:

(2 comments)

Do some of the CamelCasedNamed files come from Tianocore? If so, some information on the commit they've been taken from would be good to have to ease future updates.

https://review.coreboot.org/c/coreboot/+/33234/54/configs/config.stm 
File configs/config.stm:

https://review.coreboot.org/c/coreboot/+/33234/54/configs/config.stm@2 
PS54, Line 2: CONFIG_VENDOR_PURISM=y
            : CONFIG_MAINBOARD_VENDOR="google"
            : CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Emulation"
that's a weird combination, I guess this config underwent a couple of iterations on different boards?

https://review.coreboot.org/c/coreboot/+/33234/54/src/security/intel/stm/Kco... 
File src/security/intel/stm/Kconfig:

https://review.coreboot.org/c/coreboot/+/33234/54/src/security/intel/stm/Kco... 
PS54, Line 4: 	bool "Enable STM"
The integration in mp_init.c suggests that with enabled STM, you either get STM+SMM or no SMM running at all. Maybe mention this somewhere with this flag?