[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware

[Arthur Heymans (Code Review)]

Attention is currently required from: Julius Werner, Lance Zhao, Tim Wawrzynczak.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email )

Change subject: acpi: Add functions to declare ARM GIC V3 hardware
......................................................................

Patch Set 4:

(2 comments)

File src/acpi/acpi_gic.c:

https://review.coreboot.org/c/coreboot/+/76132/comment/b688203e_aa68f138 :
PS3, Line 20: 	gicc->gicr_base_address = 0; /* ignored by ASPM if GICR is present */
> `OSPM`

Done

https://review.coreboot.org/c/coreboot/+/76132/comment/d89e800a_bc39a989 :
PS3, Line 22: /* For platforms implementing ARMv8 the format must be:
            : 	 * Bits [63:40] Must be zero
            : 	 * Bits [39:32] Aff3 : Match Aff3 of target processor MPIDR
            : 	 * Bits [31:24] Must be zero
            : 	 * Bits [23:16] Aff2 : Match Aff2 of target processor MPIDR
            : 	 * Bits [15:8] Aff1 : Match Aff1 of target processor MPIDR
            : 	 * Bits [7:0] Aff0 : Match Aff0 of target processor MPIDR
            : 	*/
            : 	gicc->mpidr = mpidr & 0xff00ffffff;
> is this comment for mpidr ? That mask value doesn't seem to match the comment?

I'm not sure what you mean?