Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )
Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/gpio...
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/gpio...
PS2, Line 638: if (!CONFIG(SOC_INTEL_DISABLE_DYNAMIC_CLOCK_LOCAL_GATING))
This condition is the same as the 'else' clause above. Please move this statement into the 'else' and eliminate the redundant 'if' here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I816a70ad92595f013740a235a9799912ad51665e
Gerrit-Change-Number: 32788
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 May 2019 17:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment