23 Aug
2019
23 Aug
'19
1:23 a.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: intel/common/mmc: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... PS2, Line 2: CONFIG_SOC_INTEL_COMMON_BLOCK_SCS also shouldn't we use a dedicated Kconfig to avoid the DLL getting overridden by mistake for some soc?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c72b9851f41585ec099d8ae83a721af87ed383
Gerrit-Change-Number: 35040
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 08:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment