[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brox: Check to powergate the UFS controller

[Kapil Porwal (Code Review)]

Attention is currently required from: Karthik Ramasubramanian, Sowmya Aralguppe.

Kapil Porwal has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86151?usp=email )

Change subject: mb/google/brox: Check to powergate the UFS controller
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/86151/comment/be2ad515_f3098b27?usp... :
PS3, Line 114: 
             : static uint8_t pmc_get_pch_ip_pg_sts(uint32_t offset)
             : {
             : 	uint8_t val = 0;
             : 	uintptr_t pmc_bar;
             : 
             : 	pmc_bar = soc_read_pmc_base();
             : 	val = read8p(pmc_bar + offset);
             : 	return val;
             : }
> can you please move this into pmclib. […]

+1

```suggestion

inline uint8_t pmc_read8(uint32_t offset)
{
    return read8p(soc_read_pmc_base() + offset);
}
```