Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32699 )
Change subject: sb/i82801gx: Don't rewrite over BCTRL
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32699/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32699/1//COMMIT_MSG@9
PS1, Line 9: PCI_MIN_GNT is defined at offset 0x3e in <pci_def.h>,
which does not apply to this PCI bridge because it is only
defined for "Header type 0 (normal devices)" (line 82).
Same header file also defines PCI_BRIDGE_CONTROL as 0x3e.
So BCTRL is nothing special.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8a0514200f424049503bb8e4bc076ee6ae86ce3
Gerrit-Change-Number: 32699
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 May 2019 11:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment