Attention is currently required from: Selma Bensaid, Bernardo Perez Priego, Andy Yeh, kiran2.kumar@intel.com, ShawnX Tu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 )
Change subject: mb/google/brya: Update camera NVM parameters
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58374/comment/10c12b0c_aa3778b7
PS5, Line 9: Change HID name from INT3499 to PRP0001 along with size and
: address width.
Refer to eeprom discussion thread (https://partnerissuetracker.corp.google. […]
(I am denied access to that URL.)
Please amend the commit message with that information.
Also mention the size value decrease and width change.
https://review.coreboot.org/c/coreboot/+/58374/comment/a7e161c6_dd2b4bc4
PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected.
Correct the commands to dump the nvm data on brya device. […]
Please amend the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0
Gerrit-Change-Number: 58374
Gerrit-PatchSet: 5
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: kiran2.kumar@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: kiran2.kumar@intel.com
Gerrit-Attention: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 10:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: ShawnX Tu
shawnx.tu@intel.com
Gerrit-MessageType: comment