Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42875 )
Change subject: soc/amd/gpio, mb/{amd,google}: Configure pads using a single entry in GPIO configuration table
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42875/3/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42875/3/src/soc/amd/common/block/gp...
PS3, Line 204: control
Actually, doesn't this clear the pad strength?
Reworked to preserve the pad strength bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42875
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3364dc2982d66c4e33c2b4e6b0b97641ebea27f0
Gerrit-Change-Number: 42875
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 17:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment