Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )
Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47739/comment/e1f6f082_f289c7f5
PS2, Line 11: before this.
Before this, but after FSP-T is finished? I think the idea is to see if FSP-T worked.
So you have FSP-T -> console init with initial message -> this message. The initial console init message serves as a sufficient proxy to know if FSP-T failed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c6013805497604bb6a42ed4f9fdc594a73c28f1
Gerrit-Change-Number: 47739
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 18 May 2021 18:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment