EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33030 )
Change subject: mb/google/sarien: Send post code to the EC in ROM stage
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I guess this is because we deviated from Keith's original design that had this in chromeos.c where it gets included in all stages.
We can pull mainboard_post() into a separate file (ec.c?) and include it in all the appropriate stages and then it doesn't have to be duplicated or guarded.
I can try that and update the result here.
Is there a reason why mainboard_post() can't just be added back to chromeos.c instead of creating a new file.
I wanna know as well. And I try add ec.c like https://review.coreboot.org/c/coreboot/+/33047. But this just a try dry code not verify.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33030
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic03827e148b8c05e6b97f73ad36964832942c09a
Gerrit-Change-Number: 33030
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 28 May 2019 16:00:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment