Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33062 )
Change subject: soc/mediatek/mt8173/i2c.c: Remove variable set but not used ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I don't understand this. We might have a very different interpretation of "used".
Beside decreasing readability, I don't see what this change has to offer. Is this about some compiler or automatic tool reporting it? I assume it would be really unused depending on the definition of I2CLOG(). There might be multiple ways to work around: 1. make the variable a constant, and hope that nothing complains anymore. 2. define I2CLOG() such that the code is always compiled.
https://review.coreboot.org/#/c/33062/3/src/soc/mediatek/mt8173/i2c.c File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/#/c/33062/3/src/soc/mediatek/mt8173/i2c.c@a122 PS3, Line 122: It was used here. I assume to enhance readability.