Attention is currently required from: Arthur Heymans, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, TangYiwei, Varshit Pandya.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )
Change subject: mb/intel/avenuecity_crb: Add 2S GNR/SRF-AP server board Avenue City
......................................................................
Patch Set 32:
(1 comment)
File src/mainboard/intel/avenuecity_crb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81319/comment/145562a4_efb5eaf1 :
PS31, Line 21: register "serial_io_uart_debug_io_base" = "0x3F8"
The devicetree.cb cannot directly refer to a config macro and cannot update at the moment. […]
Searched around the project and found there no existing case to refer a config marco in devicetree.cb, maybe sconfig system needs to be extended? Not sure if there are any related upstreaming activities around this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81319?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64fdd5388aadf7732f6d3daa600c1455d3672a46
Gerrit-Change-Number: 81319
Gerrit-PatchSet: 32
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen, Gang C
gang.c.chen@intel.com
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Wed, 10 Apr 2024 11:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment