Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35109 )
Change subject: soc/intel/cannonlake: Use common cpu/intel/car/romstage.c code
......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
Ahh crap, there is a weak .car_stage_entry definition. Same fix for apoololake, icelake and denverton_ns.
Subrata - are you planning on pushing changes for the rest of the affected platforms as well? It might make sense to push it as a single CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35109
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9da592960f20ed9742ff696198dbc028ef519ddf
Gerrit-Change-Number: 35109
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 27 Aug 2019 06:19:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment