Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40403 )
Change subject: mb/up/squared: Fix eMMC speed for UP2 with EDK2
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40403/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40403/6//COMMIT_MSG@9
PS6, Line 9: Historically (402fe20e3e10f0f2aa1329eb60970e56bf92986e)
Since commit 402fe20e (mb/up/squared: Add mainboard)
Ack
https://review.coreboot.org/c/coreboot/+/40403/6//COMMIT_MSG@11
PS6, Line 11: Lately we found out that with EDK2 the correct Host
: Speed could not be set properly during EDK2 platform initialization.
: Therefore eMMC would not show up for boot device selection.
it never worked with MrChromebox tianocore branch. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d53204d8a776efd560fbdea918f83e180813179
Gerrit-Change-Number: 40403
Gerrit-PatchSet: 7
Gerrit-Owner: Patrik Tesarik
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Wed, 29 Apr 2020 12:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment