Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40255 )
Change subject: soc/intel/apollolake: Disable XHCI LFPS power management ......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... PS19, Line 192: * 0:FALSE (default), 1:True.
I think this should be clear enough if using a `bool` type (see comment below)
proposed to change it to: 0:Enable (default), 1:Disable
https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... PS19, Line 844: uint32_t
void
Done
https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... PS19, Line 856: configured
to make it shorter, maybe use "set" instead?
Done