coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
410 discussions

[S] Change in coreboot[main]: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source
by Cliff Huang (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/87085?usp=email ) Change subject: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source ...................................................................... Patch Set 2: (1 comment) File src/drivers/intel/touch/touch.c: https://review.coreboot.org/c/coreboot/+/87085/comment/d14b8a63_49d55ea0?us… : PS2, Line 208: acpigen_write_name_integer("_S0W", ACPI_DEVICE_SLEEP_D3_HOT); > Why remove _S0W? right. moved out of the condition. -- To view, visit https://review.coreboot.org/c/coreboot/+/87085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6 Gerrit-Change-Number: 87085 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 00:02:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XS] Change in coreboot[main]: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source
by Cliff Huang (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Jérémy Compostella, Kyoung Il Kim. Hello Intel coreboot Reviewers, Jérémy Compostella, Kyoung Il Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87085?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Kyoung Il Kim, Verified+1 by build bot (Jenkins) Change subject: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source ...................................................................... drivers/intel/touch: Conditionally add ACPI _PRW based on wake source This change addresses an issue in the touch driver where the ACPI _PRW method was added unconditionally. The ACPI _PRW method should only be generated when an Interrupt() resource is used in the _CRS method. When a GpioInt() resource is used instead, the _PRW method is not required. The ACPI generation code has been updated to conditionally add the _PRW method based on whether the wake source is a GPIO interrupt or an IRQ interrupt. Now, the _PRW method is only added when an IRQ pin is specified, which is consistent with ACPI requirements. BUG=none TEST=Configure the DRIVERS_INTEL_TOUCH option on a motherboard that has the necessary touch configurations with wake support. Verify that the THC ACPI tables are correctly generated in the SSDT. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6 --- M src/drivers/intel/touch/touch.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/87085/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6 Gerrit-Change-Number: 87085 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[M] Change in coreboot[main]: mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad
by Cliff Huang (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Bora Guvendik, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85200?usp=email ) Change subject: mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad ...................................................................... Patch Set 38: (3 comments) File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85200/comment/438762c5_aa339806?us… : PS38, Line 374: register "wake_gpe" = "GPE0_DW0_11" > Can be removed now. Done File src/mainboard/google/fatcat/variants/fatcat/variant.c: https://review.coreboot.org/c/coreboot/+/85200/comment/1e8703be_d878ba10?us… : PS38, Line 50: config->pmc_gpe0_dw0 = GPP_VGPIO > same. Done https://review.coreboot.org/c/coreboot/+/85200/comment/ba44da93_325a78ec?us… : PS38, Line 54: config->pmc_gpe0_dw0 = GPP_VGPIO; > You can remove this now. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I865dbb9eed648c8f35c7f469b27a13be993ff479 Gerrit-Change-Number: 85200 Gerrit-PatchSet: 38 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 23:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad
by Cliff Huang (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jayvik Desai, Jérémy Compostella, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim. Hello Bora Guvendik, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N, Subrata Banik, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85200?usp=email to look at the new patch set (#39). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad ...................................................................... mb/google/fatcat: Add Intel Touch support for touchscreen and touchpad This commit introduces support for touch functionalities on the Google Fatcat board( Please see docu # 818597). Changes include: - Configuration for building with the THC driver - Support for touchscreen devices in both THC-I2C and THC-SPI modes - Rework is necessary for touchscreen use in THC-SPI mode on Fatcat board - The ELAN BOM37A device is supported in THC-I2C mode - The ELAN BOM36 device is supported in THC-SPI mode - Support for the HYNITRON HFW68H touchpad device in THC-I2C mode - A rework is required to switch the interrupt pad from GPP_A13 to GPP_F18 for touchpad use in THC-I2C mode - Introduction of variant-specific touch.h header file - Wake support from S0ix state for both touchscreen and touchpad across multiple modes: LPSS-I2C, THC-I2C, and THC-SPI - PMC GPE DW0 is reconfigured to GPP_F for Touchpad in LPSS mode in variant.c for wake support BUG=none TEST= 1. Set the CBI firmware configuration for touchscreen to TOUCHSCREEN_LPSS_I2C and/or TOUCHPAD to TOUCHPAD_LPSS_I2C 2. Check the ACPI objects are generated in SSDT 3. The devices should be enumerated under the /sys/class/hidraw directory 4. The Touchscreen and/or touchpad should function properly The cursor on the screen should move accordingly 5. Test wake from S0ix state via touchscreen and touchpad inputs 6. Repeat the above for the THC CBI configurations: touchscreen: TOUCHSCREEN_THC_I2C touchpad: TOUCHPAD_THC_I2C Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I865dbb9eed648c8f35c7f469b27a13be993ff479 --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/fatcat/fw_config.c M src/mainboard/google/fatcat/variants/fatcat/gpio.c M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb M src/mainboard/google/fatcat/variants/fatcat/variant.c 5 files changed, 182 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/85200/39 -- To view, visit https://review.coreboot.org/c/coreboot/+/85200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I865dbb9eed648c8f35c7f469b27a13be993ff479 Gerrit-Change-Number: 85200 Gerrit-PatchSet: 39 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XL] Change in coreboot[main]: mb/system76/mtl: Add Lemur Pro 13
by Tim Crawford (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel. Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82788?usp=email ) Change subject: mb/system76/mtl: Add Lemur Pro 13 ...................................................................... Patch Set 7: (4 comments) File src/mainboard/system76/mtl/Makefile.mk: https://review.coreboot.org/c/coreboot/+/82788/comment/9cd578d2_94469fdd?us… : PS5, Line 16: SPD_SOURCES = samsung-M425R1GB4BB0-CQKOD samsung-M425R1GB4PB0-CWMOD > Is it intended to add the SPD files to all variants? Since Lemur is our only model with onboard memory, yes. File src/mainboard/system76/mtl/variants/lemp13/board.fmd: PS5: > That looks like a standard coreboot FMAP. […] We have a downstream patch that locks regions, so we explicitly declare the layout in FMD files, rather than relying on what `CBFS_SIZE` generates. File src/mainboard/system76/mtl/variants/lemp13/gpio.c: PS5: > For completeness, could you add comments to the rest of the used GPIOs as well? Done File src/mainboard/system76/mtl/variants/lemp13/overridetree.cb: https://review.coreboot.org/c/coreboot/+/82788/comment/1bf79fb0_922742cd?us… : PS5, Line 86: CARD > That probably means card reader? Yes. -- To view, visit https://review.coreboot.org/c/coreboot/+/82788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icac8c7dafd6371881622d797f399f8ddbe13cbce Gerrit-Change-Number: 82788 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 02 Apr 2025 22:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XL] Change in coreboot[main]: mb/system76/mtl: Add Lemur Pro 13
by Tim Crawford (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Martin L Roth, Paul Menzel, Tim Crawford. Hello Jeremy Soller, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82788?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/system76/mtl: Add Lemur Pro 13 ...................................................................... mb/system76/mtl: Add Lemur Pro 13 The Lemur Pro 13 (lemp13) is an Intel Meteor Lake-U based board. There are 2 variants to differentiate which keyboard design the unit uses, as they require different EC firmware. Change-Id: Icac8c7dafd6371881622d797f399f8ddbe13cbce Signed-off-by: Jeremy Soller <jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/mtl/Kconfig M src/mainboard/system76/mtl/Kconfig.name M src/mainboard/system76/mtl/Makefile.mk A src/mainboard/system76/mtl/spd/samsung-M425R1GB4BB0-CQKOD.spd.hex A src/mainboard/system76/mtl/spd/samsung-M425R1GB4PB0-CWMOD.spd.hex A src/mainboard/system76/mtl/variants/lemp13/board.fmd A src/mainboard/system76/mtl/variants/lemp13/board_info.txt A src/mainboard/system76/mtl/variants/lemp13/data.vbt A src/mainboard/system76/mtl/variants/lemp13/gpio.c A src/mainboard/system76/mtl/variants/lemp13/gpio_early.c A src/mainboard/system76/mtl/variants/lemp13/hda_verb.c A src/mainboard/system76/mtl/variants/lemp13/overridetree.cb A src/mainboard/system76/mtl/variants/lemp13/ramstage.c A src/mainboard/system76/mtl/variants/lemp13/romstage.c A src/mainboard/system76/mtl/variants/lemp13/tas5825m.c 15 files changed, 1,680 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/82788/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/82788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icac8c7dafd6371881622d797f399f8ddbe13cbce Gerrit-Change-Number: 82788 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Increase CBFS mcache size
by Wonkyu Kim (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Wonkyu Kim has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87108?usp=email ) Change subject: soc/intel/pantherlake: Increase CBFS mcache size ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib6f046c7211a020c15d89a02348ea89f095273ed Gerrit-Change-Number: 87108 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 21:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Allow board-specific FSP-M UPD override
by Wonkyu Kim (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Sowmya Aralguppe, Subrata Banik. Wonkyu Kim has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87089?usp=email ) Change subject: mb/google/fatcat: Allow board-specific FSP-M UPD override ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bc4270ef526363defa6cd7d22741ad42a8a76 Gerrit-Change-Number: 87089 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 21:25:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Enable HDA SDI based on FW config
by Wonkyu Kim (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Jayvik Desai, Pranava Y N, Subrata Banik. Wonkyu Kim has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87090?usp=email ) Change subject: mb/google/fatcat: Enable HDA SDI based on FW config ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice28ea7445a5cb32fe8263ada363d4f45c3152f5 Gerrit-Change-Number: 87090 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 21:24:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Directly assign HDA SDI enable
by Wonkyu Kim (Code Review) 02 Apr '25

02 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Wonkyu Kim has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87109?usp=email ) Change subject: soc/intel/pantherlake: Directly assign HDA SDI enable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87109?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9233116ca2bfaeac2f685d464a1cb261f067db6a Gerrit-Change-Number: 87109 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 21:22:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025