coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2924 discussions

[S] Change in coreboot[main]: ec/google/chromeec: Add Kconfig for ChromeEC SMBIOS APIs
by Subrata Banik (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Aamir Bohra, Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub "Kuba" Czapiga, Jason Nien, Jayvik Desai, Kapil Porwal, Martin Roth, Nick Vaccaro, Pranava Y N, Tarun, Yu-Ping Wu. Subrata Banik has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86993?usp=email ) Change subject: ec/google/chromeec: Add Kconfig for ChromeEC SMBIOS APIs ...................................................................... Patch Set 3: (1 comment) File src/ec/google/chromeec/Kconfig: https://review.coreboot.org/c/coreboot/+/86993/comment/9dd36497_63bad6b4?us… : PS3, Line 143: chromeEC nit: `Chrome EC` -- To view, visit https://review.coreboot.org/c/coreboot/+/86993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I665a3276aa6dc01571657359d17f292efc601d63 Gerrit-Change-Number: 86993 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamirbohra(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Aamir Bohra <aamirbohra(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 09:01:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
by Mac Chiang (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Weimin Wu. Mac Chiang has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86747/comment/1c6cfbdd_fcc24fb2?us… : PS5, Line 10: The ALC1320 soundwire class_id = 0x01 (MIPI_CLASS_SDCA) > Sorry, I didn’t mean HDA verb, but a normal verb (noun, adjective), so it reads as a sentence. […] ha~ I misunderstood. Correct the comments as you mentioned. File src/mainboard/google/fatcat/variants/felino/overridetree.cb: https://review.coreboot.org/c/coreboot/+/86747/comment/7266bfcc_ea69d624?us… : PS3, Line 221: 3.1 > Yes. Please rebase. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Gerrit-Change-Number: 86747 Gerrit-PatchSet: 8 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mac Chiang <mac.chiang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 08:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mac Chiang <mac.chiang(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in coreboot[main]: drivers/soundwire/alc1320: use common struct to set soundwire ADDR_
by Mac Chiang (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Mac Chiang, Paul Menzel. Hello Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86939?usp=email to look at the new patch set (#6). Change subject: drivers/soundwire/alc1320: use common struct to set soundwire ADDR_ ...................................................................... drivers/soundwire/alc1320: use common struct to set soundwire ADDR_ Add common soundwire address struct for acpi table configuration over overridetree. refer to: commit 2411942a0518 ("drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs") BUG=b:378629979 TEST=emerge-fatcat coreboot check the ssdt dump PCI0.HDAS.SNDW has address: 0x000331025D132001 Change-Id: I2d3531eef6adf21a28a26dcc3ac1bb7830877905 Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> --- M src/drivers/soundwire/alc1320/alc1320.c M src/drivers/soundwire/alc1320/chip.h 2 files changed, 8 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/86939/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86939?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d3531eef6adf21a28a26dcc3ac1bb7830877905 Gerrit-Change-Number: 86939 Gerrit-PatchSet: 6 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
by Mac Chiang (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Jayvik Desai, Paul Menzel, Pranava Y N, Varun Upadhyay, Weimin Wu. Mac Chiang has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Gerrit-Change-Number: 85572 Gerrit-PatchSet: 6 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 08:17:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
by Mac Chiang (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Jayvik Desai, Mac Chiang, Pranava Y N, Subrata Banik, Weimin Wu. Mac Chiang has uploaded a new patch set (#8) to the change originally created by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email ) The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree ...................................................................... mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree Update devicetree to support Realtek ALC1320 codec. The ALC1320 soundwire class_id is MIPI_CLASS_SDCA(1). BUG=b:378629979 TEST=emerge-fatcat coreboot check the ssdt dump PCI0.HDAS.SNDW including 0x000331025D132001 Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/felino/overridetree.cb 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/86747/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/86747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Gerrit-Change-Number: 86747 Gerrit-PatchSet: 8 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mac Chiang <mac.chiang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Show the option to enable the GNA
by Sean Rhodes (Code Review) 01 Apr '25

01 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87055?usp=email ) Change subject: mb/starlabs/starbook/mtl: Show the option to enable the GNA ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I568cb169f5266703e4422d77c0e0546a6d245ee2 Gerrit-Change-Number: 87055 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 08:07:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add WFC Function
by Daniel Peng (Code Review) 01 Apr '25

01 Apr '25

Daniel Peng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87054?usp=email ) Change subject: mb/google/nissa/var/guren: Add WFC Function ...................................................................... mb/google/nissa/var/guren: Add WFC Function New WFC function for Guren360 project. 1. Add WFC fw_config setting 2. Used USB2 Port7 for WFC BUG=b:406164678 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: Ia2ab019fe76c503cc669ebf4aa8b3d7ae72269c1 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/brya/variants/guren/overridetree.cb M src/mainboard/google/brya/variants/guren/variant.c 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/87054/1 diff --git a/src/mainboard/google/brya/variants/guren/overridetree.cb b/src/mainboard/google/brya/variants/guren/overridetree.cb index 77ec260..8b1adb1 100644 --- a/src/mainboard/google/brya/variants/guren/overridetree.cb +++ b/src/mainboard/google/brya/variants/guren/overridetree.cb @@ -21,6 +21,10 @@ option WIFI_SAR_ID_INTEL_CONVERTIBLE 0 option WIFI_SAR_ID_INTEL_CLAMSHELL 1 end + field WFC 17 18 + option WFC_ABSENT 0 + option WFC_PRESENT 1 + end field TOUCHSCREEN_SOURCE 32 34 option TOUCHSCREEN_UNPROVISIONED 0 option TOUCHSCREEN_ELAN0001 1 @@ -87,6 +91,7 @@ register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" register "typec_aux_bias_pads[1]" = "{.pad_auxp_dc = GPP_A21, .pad_auxn_dc = GPP_A22}" + register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WFC register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for CNVi WLAN # Configure external V1P05/Vnn/VnnSx Rails @@ -595,9 +600,11 @@ device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""USB2 Camera"" + register "desc" = ""USB2 WFC"" register "type" = "UPC_TYPE_INTERNAL" - device ref usb2_port7 on end + device ref usb2_port7 on + probe WFC WFC_PRESENT + end end chip drivers/usb/acpi register "desc" = ""USB2 Bluetooth"" diff --git a/src/mainboard/google/brya/variants/guren/variant.c b/src/mainboard/google/brya/variants/guren/variant.c index c2c49f8..8092ad6 100644 --- a/src/mainboard/google/brya/variants/guren/variant.c +++ b/src/mainboard/google/brya/variants/guren/variant.c @@ -18,4 +18,14 @@ printk(BIOS_INFO, "Enable DDI PORT 2 for HPD and DDC.\n"); config->ddi_ports_config[DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC; } + + if (!fw_config_probe(FW_CONFIG(WFC, WFC_PRESENT))) { + printk(BIOS_INFO, "Disable usb2_port7 of WFC.\n"); + config->usb2_ports[6].enable = 0; + config->usb2_ports[6].ocpin = OC_SKIP; + config->usb2_ports[6].tx_bias = USB2_BIAS_0MV; + config->usb2_ports[6].tx_emp_enable = USB2_EMP_OFF; + config->usb2_ports[6].pre_emp_bias = USB2_BIAS_0MV; + config->usb2_ports[6].pre_emp_bit = USB2_HALF_BIT_PRE_EMP; + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/87054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2ab019fe76c503cc669ebf4aa8b3d7ae72269c1 Gerrit-Change-Number: 87054 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
by Mac Chiang (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Jayvik Desai, Mac Chiang, Pranava Y N, Subrata Banik, Weimin Wu. Mac Chiang has uploaded a new patch set (#7) to the change originally created by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree ...................................................................... mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree Update devicetree to support Realtek ALC1320 codec. The ALC1320 soundwire class_id is MIPI_CLASS_SDCA(1). BUG=b:378629979 TEST=emerge-fatcat coreboot check the ssdt dump PCI0.HDAS.SNDW including 0x000331025D132001 Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/felino/overridetree.cb 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/86747/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Gerrit-Change-Number: 86747 Gerrit-PatchSet: 7 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mac Chiang <mac.chiang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil
by Michał Żygowski (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Piotr Król. Hello Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87049?usp=email to look at the new patch set (#3). Change subject: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil ...................................................................... mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil The SoC code requires for GPE DW config values to be different. Assign the default values of PMC GPIO_CONF register as GPIO GPEs are not used on this platform. Fixes the assertion in soc/intel/elkhartalke/pmutil. TEST=Boot Protectli VP2420 to Ubuntu 24.04. Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/mainboard/protectli/vault_ehl/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/87049/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87049?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Gerrit-Change-Number: 87049 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/moxie: Remove wifi sar table for moxie
by Jayvik Desai (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Lucas Chen, Nick Vaccaro, Paul Menzel, Subrata Banik. Jayvik Desai has posted comments on this change by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/87004?usp=email ) Change subject: mb/google/brask/var/moxie: Remove wifi sar table for moxie ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/variants/moxie/variant.c: https://review.coreboot.org/c/coreboot/+/87004/comment/3032b7b0_574463aa?us… : PS5, Line 6: Remove extra line -- To view, visit https://review.coreboot.org/c/coreboot/+/87004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I012ff2d9c8c4d6d4480cae7166bf8e633bcaa752 Gerrit-Change-Number: 87004 Gerrit-PatchSet: 5 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 07:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025