Attention is currently required from: Subrata Banik.
Momoko Hattori has posted comments on this change by Momoko Hattori. ( https://review.coreboot.org/c/coreboot/+/87001?usp=email )
Change subject: mb/google/rex: Enable use_gpio_for_status for touchscreen
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
@subratabanik@google.com I saw that you're a core coreboot contributor. Would you mind submitting this change? Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/87001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe7681884dc3edfb98c7c179b1af2063e35c4b46
Gerrit-Change-Number: 87001
Gerrit-PatchSet: 7
Gerrit-Owner: Momoko Hattori <momohatt(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 01:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Eric Lai.
Momoko Hattori has posted comments on this change by Momoko Hattori. ( https://review.coreboot.org/c/coreboot/+/86876?usp=email )
Change subject: mb/google/brya: Enable use_gpio_for_status for touchscreen
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
@ericllai@google.com I saw that you are a core contributor. Would you mind submitting this change and CB:86877 ? Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/86876?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I068faa97089ce0011727325ffc868450572bdf58
Gerrit-Change-Number: 86876
Gerrit-PatchSet: 5
Gerrit-Owner: Momoko Hattori <momohatt(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 01:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )
Change subject: soc/mediatek/mt8189: Add USB host support
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87021/comment/1526be54_c621bafe?us… :
PS2, Line 14: TEST=build pass
> Done
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/87021?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f1b4b3eb178cb9a110b97a2763c8cff5cdf0ddd
Gerrit-Change-Number: 87021
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 00:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Vince Liu <vince-wl.liu(a)mediatek.com>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )
Change subject: soc/mediatek/mt8189: Add USB host support
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87021/comment/ac1da0a4_2d5305c0?us… :
PS2, Line 14: TEST=build pass
> This commit is to add USB related configurations and make it buildable, but it cannot be executed or […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/87021?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f1b4b3eb178cb9a110b97a2763c8cff5cdf0ddd
Gerrit-Change-Number: 87021
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 00:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Vince Liu <vince-wl.liu(a)mediatek.com>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )
Change subject: soc/mediatek/mt8189: Add USB host support
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87021/comment/72870941_32e5f057?us… :
PS2, Line 14: TEST=build pass
> Did you test this?
This commit is to add USB related configurations and make it buildable, but it cannot be executed or tested by itself. I have provided the test result in another related [CL#87022](https://review.coreboot.org/c/coreboot/+/87022).
--
To view, visit https://review.coreboot.org/c/coreboot/+/87021?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f1b4b3eb178cb9a110b97a2763c8cff5cdf0ddd
Gerrit-Change-Number: 87021
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 00:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jon Murphy, Kapil Porwal, Subrata Banik, Yu-Ping Wu.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87031?usp=email )
Change subject: security/vboot: Add option for enabling ADB over network via GBB flag
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > > Thoughts? […]
I mean, we can start building coreboot from the firmware-android branch as well if you think this is important enough. Or you can put a line to set this after building in some script, or in an ebuild guarded by a USE flag or something. It does not belong here. (Besides, your patch sets it to `default n` anyway so on its own this patch does nothing?)
--
To view, visit https://review.coreboot.org/c/coreboot/+/87031?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb3a69f20ae39baf482a748a00556268d0d0aef7
Gerrit-Change-Number: 87031
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 00:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>