coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2933 discussions

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Set CNVi strap to disabled
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87084?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Set CNVi strap to disabled ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82f3ce699d5e823e1ce942acb7a0ba1bd548d9a0 Gerrit-Change-Number: 87084 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:44:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs
by Sean Rhodes (Code Review) 01 Apr '25

01 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87083?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87083/comment/38ab2c2f_88662b6c?us… : PS1, Line 9: connected. > line wrap Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I779b6bc486b68e8df50347540364901507a7102c Gerrit-Change-Number: 87083 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:44:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs
by Sean Rhodes (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87083?usp=email to look at the new patch set (#2). Change subject: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs ...................................................................... mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs Configure all strap GPIOs as outputs, rather than some being not connected. This doesn't change anything, but is more explicit. Set these all to sample on RSMRST. Change-Id: I779b6bc486b68e8df50347540364901507a7102c Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/87083/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I779b6bc486b68e8df50347540364901507a7102c Gerrit-Change-Number: 87083 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87083?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Reconfigure PCH Strap GPIOs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87083/comment/9c2bba49_129d5715?us… : PS1, Line 9: connected. line wrap -- To view, visit https://review.coreboot.org/c/coreboot/+/87083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I779b6bc486b68e8df50347540364901507a7102c Gerrit-Change-Number: 87083 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:44:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Remove comments for GPIOs that aren't con...
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87082?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Remove comments for GPIOs that aren't connected ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib3f87c6e3e83d57c4e6969c3aac7cae02d750a5c Gerrit-Change-Number: 87082 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:43:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Disconnect GPP_F10
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87081?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Disconnect GPP_F10 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie85d69e0a2a423261038688c176b32abe7bd8134 Gerrit-Change-Number: 87081 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:43:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87080?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the PCH Straps ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/mainboard/starlabs/starbook/variants/adl_n/gpio.c: https://review.coreboot.org/c/coreboot/+/87080/comment/0a32c752_05c3c191?us… : PS1, Line 95: fix alignment -- To view, visit https://review.coreboot.org/c/coreboot/+/87080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I658cd6ddf2d418da0e36a8e1969041a696a10d87 Gerrit-Change-Number: 87080 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Conditionally check for barrel charger
by Jayvik Desai (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik. Jayvik Desai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87064?usp=email ) Change subject: mb/google/fatcat: Conditionally check for barrel charger ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7a26b634a1a310f714fbf4b4a2accd75665bc28 Gerrit-Change-Number: 87064 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87079?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8456c5fa72d0c8620469e9c9ea260c60100db40e Gerrit-Change-Number: 87079 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:41:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the TPM
by Matt DeVillier (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87078?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for the TPM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I147d0b9770c6a1d10b4e8996591508a42805a18c Gerrit-Change-Number: 87078 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 01 Apr 2025 20:41:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025