Attention is currently required from: Patrick Rudolph.
Julius Werner has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87114?usp=email )
Change subject: drivers/smmstore: Support 64-bit MMIO addresses
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/87114/comment/0c46192d_255ebddf?us… :
PS1, Line …
[View More]548: uint64_t mmap_addr_high; /* When the ROM MMIO address is above 4GiB the 'mmap_addr' cannot hold it.
The naming here seems very confusing to me. When I see two fields `mmap_addr` and a later added `mmap_addr_high`, I'd expect that you want me to do `mmap_addr_high << 32 | mmap_addr`, but that's not how you designed it. How about renaming `mmap_addr` to `deprecated_mmap_addr` and naming the other one `mmap_addr_v2` or something like that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/87114?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1131cfa5cdbf92bbd33de3e5b22a305136eec9f7
Gerrit-Change-Number: 87114
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
[View Less]
Attention is currently required from: Ben Kao, Dinesh Gehlot, Dtrain Hsu, Eric Lai, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )
Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................
Patch Set 10:
(1 comment)
…
[View More]Patchset:
PS10:
This is a google board, I'll let Google +2.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87033?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I337574c8c55889ceb49b9f33625feadb48bd8890
Gerrit-Change-Number: 87033
Gerrit-PatchSet: 10
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ben Kao <ben.kao(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
[View Less]
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86864?usp=email )
Change subject: soc/amd/*/psp_verstage: Remove duplicate verstage-generic-ccopts
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> not directly related to this change: is there a difference between '$(src)'…
[View More] and 'src'? looks a bit o […]
Not that I can see. $(obj) is at least useful and more consistently used, but I don't think $(src) is actually necessary. $(top) is also not really used consistently (or I am just not seeing it). Maybe something to bring up in mailing list or leadership meeting to gain some consistency and explicit rules in our codebase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic64f5187e50b903af5461bfa4d57bb4951d3b501
Gerrit-Change-Number: 86864
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
[View Less]
Attention is currently required from: Ana Carolina Cabral, Martin L Roth, Maximilian Brune, Patrick Rudolph.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86865?usp=email )
Change subject: soc/amd/glinda/psp_verstage/Makefile.mk: Fix incorrect syntax
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86865?usp=email
To …
[View More]unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78996cd35085c7649c4952d9b121957c8cedd84b
Gerrit-Change-Number: 86865
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:11:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
[View Less]
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86864?usp=email )
Change subject: soc/amd/*/psp_verstage: Remove duplicate verstage-generic-ccopts
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
not directly related to this change: is there a …
[View More]difference between '$(src)' and 'src'? looks a bit odd to me to have a mix of those two in there
--
To view, visit https://review.coreboot.org/c/coreboot/+/86864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic64f5187e50b903af5461bfa4d57bb4951d3b501
Gerrit-Change-Number: 86864
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
[View Less]
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune, Patrick Rudolph.
Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86216?usp=email )
Change subject: soc/amd/common/block/pci: Prevent disabling active bridges
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/block/pci/pcie_gpp.c:
https://review.coreboot.…
[View More]org/c/coreboot/+/86216/comment/55caccbd_b150f672?us… :
PS2, Line 52: dev->enabled ||
is this part of the check necessary? i think that dev_is_active_bridge already checks that, right?
https://review.coreboot.org/c/coreboot/+/86216/comment/12bfbb50_dddbd62e?us… :
PS2, Line 53: if (!dev->enabled && dev_is_active_bridge(dev)) {
can this condition ever evaluate to true? when the first part is true, the second part can't be true, since dev_is_active_bridge returns 0 in the !dev->enabled case and dev is the same. or am i reading this wrong?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86216?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97098c860aa6cd6b0b59aa7b1c6f7c239e41983
Gerrit-Change-Number: 86216
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
[View Less]