Attention is currently required from: Brian Hsu, Daniel Peng, Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by Brian Hsu. ( https://review.coreboot.org/c/coreboot/+/87238?usp=email )
Change subject: mb/google/nissa/var/guren: Add touch screen FTSC1000 support
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87238?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfe5f57c69d1bd98e0852a1aa3baed8c1444e4d9
Gerrit-Change-Number: 87238
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Li <david_li(a)pegatron.corp-partner.google.com>
Gerrit-CC: Samuel Chen <samuel_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Apr 2025 06:28:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Wonkyu Kim.
Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87247?usp=email
to look at the new patch set (#4).
Change subject: ec/intel: read board ID one time from EC per stage
......................................................................
ec/intel: read board ID one time from EC per stage
Using static variables to store the board ID optimizes boot time by
reading the ID once per stage and retaining it for subsequent use.
This approach reduces redundant hardware access, ensuring efficient
and consistent retrieval of the board ID throughout the boot process.
Static variables help streamline operations, minimize overhead, and
improve performance by maintaining the board ID in a fixed memory
location, enhancing the efficiency of each boot stage.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef
---
M src/ec/intel/board_id.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/87247/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/87247?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef
Gerrit-Change-Number: 87247
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Wonkyu Kim.
Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87247?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Bora Guvendik, Verified+1 by build bot (Jenkins)
Change subject: src/ec/intel: read board id one time from EC per stage
......................................................................
src/ec/intel: read board id one time from EC per stage
Using static variables to store the board ID optimizes boot time by
reading the ID once per stage and retaining it for subsequent use.
This approach reduces redundant hardware access, ensuring efficient
and consistent retrieval of the board ID throughout the boot process.
Static variables help streamline operations, minimize overhead, and
improve performance by maintaining the board ID in a fixed memory
location, enhancing the efficiency of each boot stage.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef
---
M src/ec/intel/board_id.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/87247/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/87247?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef
Gerrit-Change-Number: 87247
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Attention is currently required from: Erik van den Bogaert, Felix Singer, Harrie Paijmans, Maxim Polyakov.
Frans Hendriks has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 3
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Comment-Date: Thu, 10 Apr 2025 05:35:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes