coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
2862 discussions

[M] Change in coreboot[main]: vendorcode/intel: allow selecting EDK headers manually
by Sergii Dmytruk (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Martin L Roth, Paul Menzel, Ronak Kanabar, Shuo Liu. Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email ) Change subject: vendorcode/intel: allow selecting EDK headers manually ...................................................................... Patch Set 13: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83738/comment/… [View More]cf2486f4_6884c578?us… : PS3, Line 7: vendorcode/intel > Should it be generalized in the future? It could be, but it needs to be untied from FSP-related code. Headers in `src/vendorcode/intel/edk2` need to be moved somewhere (without `IntelFsp2Pkg` directory). There seems to be no good place for that, maybe something like `src/uefi` or `src/vendor/uefi`. The headers are used by AMD boards, by the way, so it's more of a vendor-supplied/managed rather than vendor-specific functionality. File src/vendorcode/intel/Kconfig: https://review.coreboot.org/c/coreboot/+/83738/comment/07556a5f_caff55e9?us… : PS13, Line 63: select UDK_BASE > To support these EFI drivers, can the codes simply assign a default UDK binding if no default? (P.S. […] As long as `UDK_BASE` is selected, the drivers will be enabled. Alternatives: * making `UDK_BASE` selectable * making drivers depend on `EDK_BASE || PAYLOAD_EDK2` * always enabling `UDK_BASE` for `PAYLOAD_EDK2` (what you seem to suggest) Allowing picking a version just seemed like a more generic solution applicable to more use cases. But I'm not attached to any specific approach and happy to use a different one if it makes more sense to you. -- To view, visit https://review.coreboot.org/c/coreboot/+/83738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035 Gerrit-Change-Number: 83738 Gerrit-PatchSet: 13 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 27 Apr 2025 13:27:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> [View Less]

1 0

[M] Change in coreboot[main]: vendorcode/intel: allow selecting EDK headers manually
by Shuo Liu (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Martin L Roth, Ronak Kanabar, Sergii Dmytruk. Shuo Liu has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email ) Change subject: vendorcode/intel: allow selecting EDK headers manually ...................................................................... Patch Set 13: (1 comment) File src/vendorcode/intel/Kconfig: https://review.coreboot.org/c/coreboot/+/83738/comment/… [View More]

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Reduce IGD stolen memory size from 128MB to 60MB
by Paul Menzel (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87460?usp=email ) Change subject: soc/intel/pantherlake: Reduce IGD stolen memory size from 128MB to 60MB ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Thank you. -- To … [View More]

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Reduce IGD stolen memory size from 128MB to 60MB
by Subrata Banik (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Hello Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87460?usp=email to look at the new patch set (#4). Change subject: soc/intel/pantherlake: Reduce IGD stolen memory size from 128MB to 60MB ..........................… [View More]............................................ soc/intel/pantherlake: Reduce IGD stolen memory size from 128MB to 60MB This commit updates the pre-allocated IGD stolen memory size for Intel Panther Lake SoCs from 128MB to 60MB within the FSP-M configuration parameters. Reducing the IGD stolen memory allocation from 128MB to 60MB significantly optimizes system memory resource utilization (by 68MB). Furthermore, this reduction frees one MTRR. Previously, the 128MB IGD allocation consumed all 10 available BIOS MTRRs; the new 60MB allocation now leaves MTRR index 9 available. BUG=b:413638298 TEST=Able to boot google/fatcat to OS w/ internal and/or external display attach. Change-Id: Ifd60973bc5d37cbbc4ea6c8eaf5d851069d53083 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/romstage/fsp_params.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/87460/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/87460?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd60973bc5d37cbbc4ea6c8eaf5d851069d53083 Gerrit-Change-Number: 87460 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> [View Less]

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Conditionally init ALC256 HDA
by Subrata Banik (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N. Hello Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87462?usp=email to look at the new patch set (#3). Change subject: mb/google/fatcat/var/fatcat: Conditionally init ALC256 HDA ...................................................................... mb/… [View More]google/fatcat/var/fatcat: Conditionally init ALC256 HDA This commit implements `mainboard_hda_init()` for the Google Fatcat mainboard variant. This overrides the default weak HDA common initialization. Initialization of the High Definition Audio (HDA) controller, managed by `azalia_audio_init()` (which handles HDA verb table loading), is now conditional. It proceeds only if the firmware config `FW_CONFIG(AUDIO, AUDIO_ALC256_HDA)` is set. This value (3) specifically targets the ALC256 HDA codec. This change ensures that HDA verb tables are loaded only when the ALC256 HDA codec is actively configured for the Fatcat variant. Crucially, this prevents attempts to incorrectly load HDA verbs for other audio interfaces, like SoundWire (SNDW) or I2S, which might be present in different Fatcat hardware configurations. The headers `device/azalia_device.h` and `intelblocks/hda.h` were added for this. As a minor stylistic update, header inclusions in this file are also alphabetized. BUG=b:413638298 TEST=Verified HDA verb table loading is skipped on Fatcat platforms when configured with non-HDA audio codecs (e.g., SNDW, I2S), and proceeds as expected when ALC256 HDA is configured. Change-Id: Ifc158b7d15c763cc07d28154259b7e64709bea16 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/variant.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/87462/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87462?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc158b7d15c763cc07d28154259b7e64709bea16 Gerrit-Change-Number: 87462 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> [View Less]

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Conditionally init HDA
by Subrata Banik (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Amanda Hwang, Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N. Hello Amanda Hwang, Avi Uday, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87463?usp=email to look at the new patch set (#3). Change subject: mb/google/fatcat/var/francka: Conditionally init HDA ...................................................................... … [View More] mb/google/fatcat/var/francka: Conditionally init HDA This commit implements `mainboard_hda_init()` for the Google Francka mainboard variant. This overrides the default weak HDA common initialization. Initialization of the High Definition Audio (HDA) controller, managed by `azalia_audio_init()` (which handles HDA verb table loading), is now conditional. It proceeds only if the firmware config `FW_CONFIG(AUDIO, AUDIO_ALC256M_CG_HDA)` is set. This targets the ALC256M-CG HDA codec. This change ensures that HDA verb tables are loaded only when the ALC256M-CG HDA codec is actively configured for the Francka variant. Crucially, this prevents attempts to incorrectly load HDA verbs for other audio interfaces, like SoundWire (SNDW), which might be present in different Francka hardware configurations. The headers `device/azalia_device.h` and `intelblocks/hda.h` are added to support this HDA initialization logic. BUG=b:ENTER_FRANCKA_BUG_ID_HERE TEST=Verified HDA verb table loading is skipped on Francka platforms when configured with non-HDA audio codecs (e.g., SNDW), and proceeds as expected when ALC256M-CG HDA is configured Change-Id: Idbc506c1ad180c7e8ecdec51c3491e6f0518204c Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/variants/francka/variant.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/87463/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87463?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idbc506c1ad180c7e8ecdec51c3491e6f0518204c Gerrit-Change-Number: 87463 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> [View Less]

1 0

[XS] Change in coreboot[main]: mainboard/google/fatcat/francka: Conditional HDA init
by Subrata Banik (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Amanda Hwang, Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87463?usp=email ) Change subject: mainboard/google/fatcat/francka: Conditional HDA init ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87463/comment/… [View More]

1 0

[S] Change in coreboot[main]: mainboard/google/fatcat: Conditional ALC256 HDA init for fatcat variant
by Subrata Banik (Code Review) 27 Apr '25

27 Apr '25

Attention is currently required from: Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87462?usp=email ) Change subject: mainboard/google/fatcat: Conditional ALC256 HDA init for fatcat variant ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87462/comment/… [View More]

1 0

[XL] Change in coreboot[main]: [RFC][POC] util/scripts: Import kernel-doc from Linux
by Nicholas Chin (Code Review) 27 Apr '25

27 Apr '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/87464?usp=email ) Change subject: [RFC][POC] util/scripts: Import kernel-doc from Linux ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is an alternative for Doxygen + Breathe in https://review.coreboot.org/q/topic:%22autogen_api_docs%22. -- To view, visit https://review.coreboot.org/c/coreboot/+/87464?usp=… [View More]

1 0

[S] Change in coreboot[main]: [POC] Docs/lib/timestamp.md: Use kernel-doc for API documentation
by Nicholas Chin (Code Review) 27 Apr '25

27 Apr '25

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87468?usp=email ) Change subject: [POC] Docs/lib/timestamp.md: Use kernel-doc for API documentation ...................................................................... [POC] Docs/lib/timestamp.md: Use kernel-doc for API documentation API documentation written on doc.coreboot.org is likely to go out of date when the code is changed, whereas docstrings directly in the code are more likely to be … [View More]updated. As a proof of concept, use kernel-doc to generate function documentation for `include/timestamp.h`. The existing instructions on https://doc.coreboot.org/getting_started/writing_documentation.html should work to build and view the kernel-doc enabled documentation. Change-Id: I9c36efaf663142535309eb74fb58b4c698eccc27 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/lib/timestamp.md 1 file changed, 12 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/87468/1 diff --git a/Documentation/lib/timestamp.md b/Documentation/lib/timestamp.md index a769f99..98e65f0 100644 --- a/Documentation/lib/timestamp.md +++ b/Documentation/lib/timestamp.md @@ -122,24 +122,20 @@ ## Function APIs -### timestamp_init +```{eval-rst} +.. kernel-doc:: src/include/timestamp.h + :identifiers: timestamp_init +``` -This function initializes the timestamp cache and should be run as early -as possible. On platforms with SRAM, this might mean in bootblock, on -x86 with its CAR backed memory in romstage, this means romstage before -memory init. +```{eval-rst} +.. kernel-doc:: src/include/timestamp.h + :identifiers: timestamp_add +``` -### timestamp_add - -This function accepts from user a timestamp id and time to record in the -timestamp table. It stores the entry in the appropriate table in cbmem -or `_timestamp` region or local stash. - - -### timestamp_add_now - -This function calls `timestamp_add` with user-provided id and current time. - +```{eval-rst} +.. kernel-doc:: src/include/timestamp.h + :identifiers: timestamp_add_now +``` ## Use / Test Cases -- To view, visit https://review.coreboot.org/c/coreboot/+/87468?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9c36efaf663142535309eb74fb58b4c698eccc27 Gerrit-Change-Number: 87468 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025