Attention is currently required from: Fred Reitberger, Jason Glenesk, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84378?usp=email )
Change subject: soc/amd/glinda: Update gpp bridge naming scheme
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/birman/devicetree_glinda.cb:
https://review.coreboot.org/c/coreboot/+/84378/comment/859911a5_b8c42a9d?us… :
PS1, Line 161: device ref gpp_bridge_2_1 on end # NVME SSD0
: device ref gpp_bridge_2_2 on end # SD
: device ref gpp_bridge_2_3 on end # WLAN
: device ref gpp_bridge_2_4 on end # GBE
this isn't just the rename of the bridges. would be good if this patch only did the renaming and the changes that also need the corresponding dxio/mpio descriptor changes in a separate patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/84378?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f740d75a3561dba2ed65acb16bb4259f632307d
Gerrit-Change-Number: 84378
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 15:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84353?usp=email )
Change subject: payloads/edk2: Fix image alignment
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> A while back, this was broken on, I believe, MinPlatform. […]
CFR, SecureBoot, TPM, SMMStore, cbmem logging - I think that's all the features everyone uses floating around, save for the GOP driver
--
To view, visit https://review.coreboot.org/c/coreboot/+/84353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I881bfd1eec55454e444909b845a342a94ba8904b
Gerrit-Change-Number: 84353
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 13:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Attention is currently required from: Alicja Michalska.
Nicholas Sudsgaard has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84388?usp=email )
Change subject: mb/ocp/tiogapass: Update dead links in the documentation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84388?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I685d1aaabab0cb14f88025cdc80d86342e354a63
Gerrit-Change-Number: 84388
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 12:29:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Werner Zeh.
Mario Scheithauer has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84391?usp=email )
Change subject: mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning in FSP
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84391/comment/fa27f2eb_65158c87?us… :
PS1, Line 11: improves performance in the real-time environment for these mainboards.
> Is there a public benchmark that could be run? Is there a command that can be run in Linux to check […]
We use our self-made Linux system and our real-time automation software for the test. No public benchmark test can be used.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04859b2f32bc11344b0620925f2414e7a6df625e
Gerrit-Change-Number: 84391
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 09:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Mario Scheithauer, Werner Zeh.
Hello Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84391?usp=email
to look at the new patch set (#2).
Change subject: mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning in FSP
......................................................................
mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning in FSP
The real-time feature should also be activated for all mc_ehl
mainboards, as it has already been done for mainboard mc_ehl1. It
improves performance in the real-time environment for these mainboards.
Change-Id: I04859b2f32bc11344b0620925f2414e7a6df625e
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/devicetree.cb
M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/devicetree.cb
3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/84391/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04859b2f32bc11344b0620925f2414e7a6df625e
Gerrit-Change-Number: 84391
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Attention is currently required from: Mario Scheithauer, Werner Zeh.
Paul Menzel has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84391?usp=email )
Change subject: mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84391/comment/e8f701c9_d4727059?us… :
PS1, Line 7: mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning
… in FSP
https://review.coreboot.org/c/coreboot/+/84391/comment/66ae0ec2_8914d015?us… :
PS1, Line 11: improves performance in the real-time environment for these mainboards.
Is there a public benchmark that could be run? Is there a command that can be run in Linux to check for one of the settings?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04859b2f32bc11344b0620925f2414e7a6df625e
Gerrit-Change-Number: 84391
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 09:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No