coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
2237 discussions

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Jérémy Compostella (Code Review) 18 Sep '24

18 Sep '24

Hello Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84402?usp=email to look at the new patch set (#4). Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... efi: Set EFIAPI to 32-bit ABI for FSP1_1 Because PLATFORM_USES_FSP2_X86_32 default to false when PLATFORM_USES_FSP1_1, efi_datatype.h wrongly defines EFI as __attribute__((__ms_abi__)). TEST=When some code involved in the build of a platform using FSP 1.1 such as Google/CYAN includes efi_datatype.h, it does not hit the following error: '__ms_abi__' calling convention is not supported for this target Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/include/efi/efi_datatype.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/84402/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Jérémy Compostella (Code Review) 18 Sep '24

18 Sep '24

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/2c7cde68_ff93ae63?us… : PS2, Line 7: FSP1_1 > > Technically this is not mandatory: "Test your patches before submitting them to gerrit. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:49:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Jérémy Compostella (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Jérémy Compostella. Hello Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84402?usp=email to look at the new patch set (#3). Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... efi: Set EFIAPI to 32-bit ABI for FSP1_1 Because PLATFORM_USES_FSP2_X86_32 default to false when PLATFORM_USES_FSP1_1, efi_datatype.h wrongly defines EFI as __attribute__((__ms_abi__)). TEST=When some code involved in the build of a platform using FSP 1.1 such as Google/CYAN include efi_datatype.h, it does not hit the following error: '__ms_abi__' calling convention is not supported for this target Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/include/efi/efi_datatype.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/84402/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Subrata Banik (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Jérémy Compostella. Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/3aa6f666_c8b1d6cb?us… : PS2, Line 7: FSP1_1 > Technically this is not mandatory: "Test your patches before submitting them to gerrit. It’s also appreciated if you add a line to the commit message describing how the patch was tested. This prevents people from having to ask whether and how the patch was tested." > > I tend to agree we should have one as much as possible, it just does not make sense here but since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this. Please avoid making such a comment, there is nothing personal. corebootis Gerrit test will be lost over time and we need to know while doing git bisect why one has added a one CL and what is the minimal testing being done. **since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this.** -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:46:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Jérémy Compostella (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Subrata Banik. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/a0d06880_37776a7a?us… : PS2, Line 7: FSP1_1 > > The problem is the issue won't reproduce before the following patch so it is bit weird to mention […] Technically this is not mandatory: "Test your patches before submitting them to gerrit. It’s also appreciated if you add a line to the commit message describing how the patch was tested. This prevents people from having to ask whether and how the patch was tested." I tend to agree we should have one as much as possible, it just does not make sense here but since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this. -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Subrata Banik (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Jérémy Compostella. Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/68950420_22903229?us… : PS2, Line 7: FSP1_1 > The problem is the issue won't reproduce before the following patch so it is bit weird to mention that isn't it ? every patch should have a TEST line to ensure what is the level of sanity here. what is weird here, cyan is FSP 1.1 platform. -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:39:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: soc/intel/ehl/fsp_params: Fix double setting of 'PchPwrOptEnable'
by Paul Menzel (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Lean Sheng Tan, Mario Scheithauer. Paul Menzel has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84399?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/intel/ehl/fsp_params: Fix double setting of 'PchPwrOptEnable' ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84399/comment/28e63eae_306985bd?us… : PS3, Line 7: Fix double setting of 'PchPwrOptEnable' I misunderstood the summary. Maybe something like: > Do not re-enable PchPwrOptEnable for real-time tuning https://review.coreboot.org/c/coreboot/+/84399/comment/94e85fa1_2014b9bf?us… : PS3, Line 9: If real-time tuning was enabled, 'PchPwrOptEnable' was set two times. … with different values. -- To view, visit https://review.coreboot.org/c/coreboot/+/84399?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f31015c1da51a4ae1b8d5226f5d7b60a6023f3d Gerrit-Change-Number: 84399 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Jérémy Compostella (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Subrata Banik. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/e14691c3_ad02a642?us… : PS2, Line 7: FSP1_1 > > coreboot jenkins catched it. […] The problem is the issue won't reproduce before the following patch so it is bit weird to mention that isn't it ? -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[M] Change in coreboot[main]: soc/amd/glinda/chipset.cb: Update for glinda
by Maximilian Brune (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84376?usp=email ) Change subject: soc/amd/glinda/chipset.cb: Update for glinda ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > ah, that's also why the build fails Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1138f27bfd47f6fa70a0c2afcc65a5553a609d57 Gerrit-Change-Number: 84376 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: efi: Set EFIAPI to 32-bit ABI for FSP1_1
by Subrata Banik (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Jérémy Compostella. Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email ) Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84402/comment/10a24898_e85a32dc?us… : PS2, Line 7: FSP1_1 > coreboot jenkins catched it. As soon as we start using the right type, through inclusion we get the following error. > > https://qa.coreboot.org/job/coreboot-gerrit/264548/ can you please mention that able to build `Google/CYAN` board w/o any compilation error -- To view, visit https://review.coreboot.org/c/coreboot/+/84402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d Gerrit-Change-Number: 84402 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 04:35:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024