Attention is currently required from: Hannah Williams.
Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/83785?usp=email )
Change subject: soc/intel/common: Add SoC QDF read function
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/83785/comment/de9d3a2e_7b0a13d0?us… :
PS1, Line 885:
> @jamie.m.ryu@intel. […]
Hannah, Thanks for the suggestion. I added comments for the function.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83785?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icad129e8889bac6bb96fb99dde089bcc4426d274
Gerrit-Change-Number: 83785
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Comment-Date: Wed, 07 Aug 2024 00:38:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hannah Williams <hannah.williams(a)intel.com>
Attention is currently required from: Bora Guvendik, Jamie Ryu.
Hello Bora Guvendik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83784?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Bora Guvendik
Change subject: soc/intel/common: Add PMC command to access SoC registers
......................................................................
soc/intel/common: Add PMC command to access SoC registers
This adds PMC IPC Command PMC_IPC_CMD_SOC_REG_ACC to access SoC
registers. This command can be used to read Intel SoC QDF using
REGID_SOC_QDF and the QDF read is supported from Panther Lake SoC.
Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com>
---
M src/soc/intel/common/block/include/intelblocks/pmc_ipc.h
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83784/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Gerrit-Change-Number: 83784
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Attention is currently required from: Anil Kumar K, Naveen M, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
to look at the new patch set (#6).
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
drivers/soundwire: Support Realtek ALC722 codec
This patch adds SoundWire driver to support ALC722 audio codec.
The existing ALC711 codec driver is refactored to include support for
ALC722 device based on config flag.
The ACPI address for the codec is calculated with the information in
the codec driver combined with the devicetree.cb hierarchy where the
link and unique IDs are extracted from the device path.
For example this device is connected to master link ID 0 and has strap
settings configuring it for unique ID 1:
chip drivers/soundwire/alc722
register "desc" = ""Headset Codec""
device generic 0.1 on end
end
TEST=This driver was tested on Intel RVP with on board ALC722 codec
by booting and disassembling the runtime SSDT to ensure that the
devices have the expected address and properties. Test soundcard
binding works and devices are detected and check for audio playback
using speaker output.
reference datasheet : Realtek ALC722-CG ver. 0.56
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
---
M src/drivers/soundwire/alc711/Kconfig
M src/drivers/soundwire/alc711/Makefile.mk
M src/drivers/soundwire/alc711/alc711.c
M src/include/mipi/ids.h
4 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/81920/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 6
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Naveen M <naveen.m(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Anil Kumar K, Naveen M, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
drivers/soundwire: Support Realtek ALC722 codec
This patch adds SoundWire driver to support ALC722 audio codec.
The existing ALC711 codec driver is refactored to include support for
ALC722 device based on config flag.
The ACPI address for the codec is calculated with the information in
the codec driver combined with the devicetree.cb hierarchy where the
link and unique IDs are extracted from the device path.
For example this device is connected to master link ID 0 and has strap
settings configuring it for unique ID 1:
chip drivers/soundwire/alc722
register "desc" = ""Headset Codec""
device generic 0.1 on end
end
TEST=This driver was tested on Intel RVP with on board ALC722 codec
by booting and disassembling the runtime SSDT to ensure that the
devices have the expected address and properties. Test soundcard
binding works and devices are detected and check for audio playback
using speaker output.
reference datasheet : Realtek ALC722-CG ver. 0.56
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
---
M src/drivers/soundwire/alc711/Kconfig
M src/drivers/soundwire/alc711/Makefile.mk
M src/drivers/soundwire/alc711/alc711.c
M src/include/mipi/ids.h
4 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/81920/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 5
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Naveen M <naveen.m(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Jamie Ryu.
Bora Guvendik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/83784?usp=email )
Change subject: soc/intel/common: Add PMC command to access SoC registers
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Gerrit-Change-Number: 83784
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 23:30:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak, Vanessa Eusebio.
Felix Held has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )
Change subject: acpi: Move HPET generation to a common location
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
would be good if you could update this patch so that it can eventually land in upstream
--
To view, visit https://review.coreboot.org/c/coreboot/+/76128?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20
Gerrit-Change-Number: 76128
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 23:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Christian Walter.
Benjamin Doron has posted comments on this change by Christian Walter. ( https://review.coreboot.org/c/coreboot/+/82235?usp=email )
Change subject: src/drivers/vpd: Add VPD as option backend
......................................................................
Patch Set 2:
(3 comments)
File src/drivers/vpd/Kconfig:
https://review.coreboot.org/c/coreboot/+/82235/comment/54058343_b90d2e77?us… :
PS2, Line 28: config VPD_OPTION_BACKEND
Use this Kconfig to determine in VPD's Makefile if options.c is compiled in? Although somewhere in https://github.com/coreboot/coreboot/blob/8d0d57f0a2ed454f0036caae6d6ac30c5… may be a better place for this anyways.
File src/drivers/vpd/options.c:
https://review.coreboot.org/c/coreboot/+/82235/comment/3d9734f4_7a2abe0c?us… :
PS2, Line 1: BSD-3-Clause
coreboot tends towards GPL v2, or GPL v2+. Is BSD allowed?
https://review.coreboot.org/c/coreboot/+/82235/comment/3ce8a4e8_fea7c749?us… :
PS2, Line 19: printk(BIOS_WARNING, "VPDs are not meant to be written from coreboot", name, value);
The arguments are unused, and this is missing a newline character. Perhaps `"Attempted to write \"%s\" = %d. VPDs should not be written from coreboot, skipping\n"`
--
To view, visit https://review.coreboot.org/c/coreboot/+/82235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic114f29034c8e70ce5044bcad631c4dbbe5c9bfe
Gerrit-Change-Number: 82235
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Tue, 06 Aug 2024 22:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/83784?usp=email )
Change subject: soc/intel/common: Add PMC command to access SoC registers
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Gerrit-Change-Number: 83784
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 06 Aug 2024 22:16:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No