Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/flash_controller.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/559c48d7_8142fd47?us… :
PS5, Line 239: else
no need
https://review.coreboot.org/c/coreboot/+/83989/comment/79c9eb36_7fc968a9?us… :
PS5, Line 240: printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__,
: gpio_get_driving(pad_func->gpio));
decrease indent
--
To view, visit https://review.coreboot.org/c/coreboot/+/83989?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I145233ef887a38251e8fc129b8357f236c5f7a2b
Gerrit-Change-Number: 83989
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 08:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84027?usp=email )
Change subject: soc/mediatek/mt8196: Add SSPM firmware v1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Missing license.txt.
--
To view, visit https://review.coreboot.org/c/blobs/+/84027?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda
Gerrit-Change-Number: 84027
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 08:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Zhanzhan Ge has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31
......................................................................
Patch Set 17:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/dc073c09_0b164e3f?us… :
PS8, Line 9: 1. Set systimer compensation to version 2.0.
: 2. The system does not need to serve pending IRQ from systimer
: after rebooting. Therefore we clear systimer IRQ pending bit
: at early booting.
> Yes,
1 and 2 are related, 1 fixes to you, 2 fixes potential issues, but 2 depends on 1, so there is no need to separate them. Thank you
--
To view, visit https://review.coreboot.org/c/coreboot/+/83928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I520986b81ca153ec3ce56558a80619448cfc0c59
Gerrit-Change-Number: 83928
Gerrit-PatchSet: 17
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 08:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Elyes Haouas, Felix Singer.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83107?usp=email )
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
Thanks for your time
--
To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Gerrit-Change-Number: 83107
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 23 Aug 2024 07:57:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Felix Singer.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83107?usp=email )
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
......................................................................
Patch Set 17:
(8 comments)
Patchset:
PS16:
> Please remove "duplicated" includes and include only what you use.
Removed
Patchset:
PS17:
+ some changes in the device tree (USB, PMC)
File src/mainboard/asrock/imb-1222/Kconfig:
https://review.coreboot.org/c/coreboot/+/83107/comment/07b8da82_0b50626c?us… :
PS16, Line 21: select INTEL_INT15
> duplicated select, remove
Done
File src/mainboard/asrock/imb-1222/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83107/comment/2b7dcf11_79b2d5d7?us… :
PS16, Line 6: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
> This is the default. Please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/061e2c8c_34c56ec1?us… :
PS16, Line 45: device cpu_cluster 0 on end
> Already in chipset devicetree. Please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/f6b48baf_7eb64ea6?us… :
PS16, Line 91: device ref heci1 on end
> Same as in chipset devicetree, please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/7b245261_2354ad90?us… :
PS16, Line 143: device ref fast_spi on end
> Same as in chipset devicetree, please remove.
Done
File src/mainboard/asrock/imb-1222/fmap.fmd:
PS16:
> Is there a reason for the custom fmap? It looks pretty much like a standard one.
Anyway, it doesn't work and I didn't understand why.
Removed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Gerrit-Change-Number: 83107
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 23 Aug 2024 07:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Maxim.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83107?usp=email
to look at the new patch set (#17).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
......................................................................
mb/asrock: Add Asrock Industrial IMB-1222 motherboard
ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX
motherboard [1].
Working:
- Dual Channel DDR4 2933/2666/2400 MHz;
- Intel UHD Graphics (VGA Option ROM, libgfxinit);
- DP (both), HDMI;
- PCIe x16 Slot (Gen3);
- SATA ports;
- USB 2.0 ports;
- USB 3.0 ports;
- M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi);
- M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1);
- M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3);
- LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps;
- LAN2 Intel I219LM, 10/100/1000 Mbps;
- Realtek ALC887 HD Audio (line-out, mic-in);
- COM 1/2/3/4 ports;
- onboard speaker;
- HWM/FANs control (fintek f81966);
- S3 suspend and wake;
- TPM;
- disabling ME (me_cleaner);
- boots Ubuntu 22.04/24.04 (SeaBIOS, Linuxboot, edk2 [2]).
Unknown/untested:
- USB3.0 in M.2 Key-B 3042/3052 slot;
- eDP/LVDS;
- PCIe riser cards;
- SPDIF.
Known issues:
- there is no video output in firmware with edk2 [2].
There is no schematic/boardview, reverse engineering only.
This port is based on system76/bonw14 because it has a similar topology.
[1] https://web.archive.org/web/20220924171403/https://www.asrockind.com/en-gb/IMB-1222
[2] MrChromebox' edk2 fork, https://github.com/mrchromebox/edk2
uefipayload_202309 branch
Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
A Documentation/mainboard/asrock/imb-1222.md
M Documentation/mainboard/index.md
A src/mainboard/asrock/imb-1222/Kconfig
A src/mainboard/asrock/imb-1222/Kconfig.name
A src/mainboard/asrock/imb-1222/Makefile.mk
A src/mainboard/asrock/imb-1222/acpi/mainboard.asl
A src/mainboard/asrock/imb-1222/acpi/sleep.asl
A src/mainboard/asrock/imb-1222/board_info.txt
A src/mainboard/asrock/imb-1222/bootblock.c
A src/mainboard/asrock/imb-1222/cmos.default
A src/mainboard/asrock/imb-1222/cmos.layout
A src/mainboard/asrock/imb-1222/data.vbt
A src/mainboard/asrock/imb-1222/devicetree.cb
A src/mainboard/asrock/imb-1222/dsdt.asl
A src/mainboard/asrock/imb-1222/gma-mainboard.ads
A src/mainboard/asrock/imb-1222/gpio.c
A src/mainboard/asrock/imb-1222/gpio_beep.c
A src/mainboard/asrock/imb-1222/hda_verb.c
A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h
A src/mainboard/asrock/imb-1222/include/mainboard/superio.h
A src/mainboard/asrock/imb-1222/panic.c
A src/mainboard/asrock/imb-1222/ramstage.c
A src/mainboard/asrock/imb-1222/romstage.c
A src/mainboard/asrock/imb-1222/superio.c
24 files changed, 1,225 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Gerrit-Change-Number: 83107
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Zhanzhan Ge has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31
......................................................................
Patch Set 17:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/007a92ad_3fdca2eb?us… :
PS8, Line 9: 1. Set systimer compensation to version 2.0.
: 2. The system does not need to serve pending IRQ from systimer
: after rebooting. Therefore we clear systimer IRQ pending bit
: at early booting.
> Can we have 2 separate patches for these? Item 1 looks like a fix to me, but item 2 seems like an im […]
Yes,
File src/soc/mediatek/mt8196/include/soc/timer.h:
https://review.coreboot.org/c/coreboot/+/83928/comment/be68526e_849dd2fc?us… :
PS8, Line 22: /* 0x0*/
> Remove these comments, as there are already `check_member` below.
Done
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/bff4c3f8_ac29efa2?us… :
PS8, Line 18: &mtk_systimer->cnttval[id].con
> Use a local variable for this pointer.
Hi, mtk_systimer is already a local variable, thank you
https://review.coreboot.org/c/coreboot/+/83928/comment/d2cd711e_ffaaa7f6?us… :
PS8, Line 28: clrbits32
> `clrbits32p`
The difference between clrbits32 and clrbits32p is whether the first parameter is a pointer, so there should be no need to change it to clrbits32p. Thank you
--
To view, visit https://review.coreboot.org/c/coreboot/+/83928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I520986b81ca153ec3ce56558a80619448cfc0c59
Gerrit-Change-Number: 83928
Gerrit-PatchSet: 17
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 07:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Arthur Heymans, Christian Walter, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84039?usp=email )
Change subject: cbmem.h: Change signature of cbmem_get_region
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
The target of lto_2024 is to enable clang for x86 target, with LTO as an option, right? For LTO, the major benefit for coreboot is more at boot perf or module size?
Commit Message:
https://review.coreboot.org/c/coreboot/+/84039/comment/7e6268ab_21b66de0?us… :
PS2, Line 7: cbmem.h: Change signature of cbmem_get_region
return type?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84039?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib3e09a75380faf9f533601368993261f042422ef
Gerrit-Change-Number: 84039
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 23 Aug 2024 07:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84052?usp=email )
Change subject: car.ld: Fix bug with LLD
......................................................................
car.ld: Fix bug with LLD
Somehow LLD does not know how to deal with this region and places it
quite high which overlaps with bootblock. As this section is not used it
can be dropped.
Change-Id: I9cdd1b509bb9ff449e692109a4b674f8bfd732a4
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/car.ld
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/84052/1
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld
index 4c869df..2612980 100644
--- a/src/arch/x86/car.ld
+++ b/src/arch/x86/car.ld
@@ -116,10 +116,6 @@
. += CONFIG_FSP_M_RC_HEAP_SIZE;
}
-. = _car_region_end;
-.car.mrc_var . (NOLOAD) : {
- . += CONFIG_DCACHE_RAM_MRC_VAR_SIZE;
-}
.car.fspt_reserved . (NOLOAD) : {
. += CONFIG_FSP_T_RESERVED_SIZE;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84052?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9cdd1b509bb9ff449e692109a4b674f8bfd732a4
Gerrit-Change-Number: 84052
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Christian Walter, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84039?usp=email
to look at the new patch set (#3).
Change subject: cbmem.h: Change signature of cbmem_get_region
......................................................................
cbmem.h: Change signature of cbmem_get_region
The underlying IMD function already returns an integer which indicates
success or failure.
This removes the need to have initialized variables that need to be
checked for NULL later.
Dying is appropriate if cbmem is not found as it is essential to the
bootflow.
Change-Id: Ib3e09a75380faf9f533601368993261f042422ef
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/postcar_loader.c
M src/include/cbmem.h
M src/lib/fit_payload.c
M src/lib/imd_cbmem.c
M src/security/memory/memory_clear.c
M src/soc/intel/xeon_sp/memmap.c
M tests/lib/Makefile.mk
7 files changed, 23 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/84039/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84039?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib3e09a75380faf9f533601368993261f042422ef
Gerrit-Change-Number: 84039
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>