Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84061?usp=email )
Change subject: soc/amd/common/psp/psp_def: rework command buffer documentation
......................................................................
soc/amd/common/psp/psp_def: rework command buffer documentation
The existing comment on the mbox_default_buffer struct was outdated and
didn't reflect the current state, so rework it to keep it a bit more
generic and also add the document number for the newer generations of
CPUs. To better document which commands use non-default buffers, add the
names of the commands using the non-default buffers to those buffer
struct definitions.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I510d953217240243392e8a415358524257bd28b1
---
M src/soc/amd/common/block/psp/psp_def.h
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/84061/1
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h
index c2b2fca..03fd352 100644
--- a/src/soc/amd/common/block/psp/psp_def.h
+++ b/src/soc/amd/common/block/psp/psp_def.h
@@ -48,12 +48,11 @@
} __packed;
/*
- * command-specific buffer definitions: see NDA document #54267
- * The following commands need a buffer definition if they are to be used.
- * All other commands will work with the default buffer.
- * MBOX_BIOS_CMD_SMM_INFO MBOX_BIOS_CMD_PSP_QUERY
- * MBOX_BIOS_CMD_SX_INFO MBOX_BIOS_CMD_S3_DATA_INFO
- * MBOX_BIOS_CMD_RSM_INFO
+ * x86 to PSP mailbox commands that don't take any parameter or return any data, use the
+ * mbox_default_buffer, while x86 to PSP commands that either pass data to the PSP or get data
+ * returned from the PSP use command-specific buffer definitions. For details on the specific
+ * buffer definitions for the various commands, see NDA document #54267 for the generations
+ * before family 17h and NDA document #55758 for the generations from family 17h on.
*/
struct mbox_default_buffer { /* command-response buffer unused by command */
@@ -73,16 +72,19 @@
uint64_t psp_mbox_smm_flag_address;
} __packed;
+/* MBOX_BIOS_CMD_SMM_INFO */
struct mbox_cmd_smm_info_buffer {
struct mbox_buffer_header header;
struct smm_req_buffer req;
} __packed __aligned(32);
+/* MBOX_BIOS_CMD_SX_INFO */
struct mbox_cmd_sx_info_buffer {
struct mbox_buffer_header header;
u8 sleep_type;
} __packed __aligned(32);
+/* MBOX_BIOS_CMD_SET_SPL_FUSE */
struct mbox_cmd_late_spl_buffer {
struct mbox_buffer_header header;
uint32_t spl_value;
@@ -99,6 +101,7 @@
DTPM_REQUEST_MAX,
};
+/* MBOX_BIOS_CMD_I2C_TPM_ARBITRATION */
struct mbox_cmd_dtpm_config_buffer {
struct mbox_buffer_header header;
uint32_t request_type;
--
To view, visit https://review.coreboot.org/c/coreboot/+/84061?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I510d953217240243392e8a415358524257bd28b1
Gerrit-Change-Number: 84061
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Angel Pons, Elyes Haouas, Jason Glenesk, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83005?usp=email )
Change subject: crossgcc: Upgrade LLVM from 18.1.6 to 18.1.8
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83005/comment/1b6aa5c9_6f04e89d?us… :
PS6, Line 7: [wip]
> Maybe look into it after OSFC is done?
We try to get toolchain updates in as soon as possible so that there is lots of time in between until the next release. Let's see how 19.1 will work out. Until then, I'll will submit this one since it's a bug fix release.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83005?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id74ba772f105a5c36308b8e1dd803ae50840002b
Gerrit-Change-Number: 83005
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 23 Aug 2024 21:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas, Jason Glenesk, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83007?usp=email )
Change subject: crossgcc: Upgrade CMake from 3.29.3 to 3.30.2
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83007?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0bb1a2a84d81ec03c4468955926f3f0c94276203
Gerrit-Change-Number: 83007
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 23 Aug 2024 21:43:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83839?usp=email )
Change subject: crossgcc: Upgrade GCC from 14.1.0 to 14.2.0
......................................................................
crossgcc: Upgrade GCC from 14.1.0 to 14.2.0
Change-Id: I6ffff766fb1fa91ad376c3e7e9aebe17c3288725
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83839
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-14.2.0_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-14.2.0_gnat.patch
R util/crossgcc/patches/gcc-14.2.0_libcpp.patch
R util/crossgcc/patches/gcc-14.2.0_libgcc.patch
R util/crossgcc/patches/gcc-14.2.0_musl_poisoned_calloc.patch
R util/crossgcc/patches/gcc-14.2.0_rv32iafc.patch
D util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum
A util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum
9 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 4440fe8..367caab 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -38,7 +38,7 @@
GMP_VERSION=6.3.0
MPFR_VERSION=4.2.1
MPC_VERSION=1.3.1
-GCC_VERSION=14.1.0
+GCC_VERSION=14.2.0
BINUTILS_VERSION=2.43.1
IASL_VERSION="20230628"
# CLANG version number
diff --git a/util/crossgcc/patches/gcc-14.1.0_asan_shadow_offset_callback.patch b/util/crossgcc/patches/gcc-14.2.0_asan_shadow_offset_callback.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_asan_shadow_offset_callback.patch
rename to util/crossgcc/patches/gcc-14.2.0_asan_shadow_offset_callback.patch
diff --git a/util/crossgcc/patches/gcc-14.1.0_gnat.patch b/util/crossgcc/patches/gcc-14.2.0_gnat.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_gnat.patch
rename to util/crossgcc/patches/gcc-14.2.0_gnat.patch
diff --git a/util/crossgcc/patches/gcc-14.1.0_libcpp.patch b/util/crossgcc/patches/gcc-14.2.0_libcpp.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_libcpp.patch
rename to util/crossgcc/patches/gcc-14.2.0_libcpp.patch
diff --git a/util/crossgcc/patches/gcc-14.1.0_libgcc.patch b/util/crossgcc/patches/gcc-14.2.0_libgcc.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_libgcc.patch
rename to util/crossgcc/patches/gcc-14.2.0_libgcc.patch
diff --git a/util/crossgcc/patches/gcc-14.1.0_musl_poisoned_calloc.patch b/util/crossgcc/patches/gcc-14.2.0_musl_poisoned_calloc.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_musl_poisoned_calloc.patch
rename to util/crossgcc/patches/gcc-14.2.0_musl_poisoned_calloc.patch
diff --git a/util/crossgcc/patches/gcc-14.1.0_rv32iafc.patch b/util/crossgcc/patches/gcc-14.2.0_rv32iafc.patch
similarity index 100%
rename from util/crossgcc/patches/gcc-14.1.0_rv32iafc.patch
rename to util/crossgcc/patches/gcc-14.2.0_rv32iafc.patch
diff --git a/util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum b/util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum
deleted file mode 100644
index b512e72..0000000
--- a/util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum
+++ /dev/null
@@ -1 +0,0 @@
-0aec8d432b8473559942a45c12459a5db3a04618 tarballs/gcc-14.1.0.tar.xz
diff --git a/util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum
new file mode 100644
index 0000000..f81c535
--- /dev/null
+++ b/util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum
@@ -0,0 +1 @@
+d91ecc3d20ce6298bd95f9b09cc51dc6d3c73ae3 tarballs/gcc-14.2.0.tar.xz
--
To view, visit https://review.coreboot.org/c/coreboot/+/83839?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ffff766fb1fa91ad376c3e7e9aebe17c3288725
Gerrit-Change-Number: 83839
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83839?usp=email )
Change subject: crossgcc: Upgrade GCC from 14.1.0 to 14.2.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83839?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ffff766fb1fa91ad376c3e7e9aebe17c3288725
Gerrit-Change-Number: 83839
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 23 Aug 2024 21:36:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes