Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83643?usp=email )
Change subject: acpi,soc: use is_domain0 function
......................................................................
acpi,soc: use is_domain0 function
No need to open-code this when we have a function for this.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Iae570ba750cb29456436349b4263808e2e410e2e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83643
Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Shuo Liu <shuo.liu(a)intel.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
---
M src/acpi/acpigen_pci_root_resource_producer.c
M src/soc/amd/common/block/data_fabric/domain.c
M src/soc/cavium/cn81xx/soc.c
M src/soc/intel/xeon_sp/uncore_acpi.c
4 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Angel Pons: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
Shuo Liu: Looks good to me, but someone else must approve
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/acpi/acpigen_pci_root_resource_producer.c b/src/acpi/acpigen_pci_root_resource_producer.c
index 78e1a89..ce57b9cc 100644
--- a/src/acpi/acpigen_pci_root_resource_producer.c
+++ b/src/acpi/acpigen_pci_root_resource_producer.c
@@ -60,7 +60,7 @@
acpigen_resource_producer_bus_number(domain->downstream->secondary,
domain->downstream->max_subordinate);
- if (domain->path.domain.domain == 0) {
+ if (is_domain0(domain)) {
/* ACPI 6.4.2.5 I/O Port Descriptor */
acpigen_write_io16(PCI_IO_CONFIG_INDEX, PCI_IO_CONFIG_LAST_PORT, 1,
PCI_IO_CONFIG_PORT_COUNT, 1);
diff --git a/src/soc/amd/common/block/data_fabric/domain.c b/src/soc/amd/common/block/data_fabric/domain.c
index b056d60..c419fe0 100644
--- a/src/soc/amd/common/block/data_fabric/domain.c
+++ b/src/soc/amd/common/block/data_fabric/domain.c
@@ -206,7 +206,7 @@
read_non_pci_resources(domain, &idx);
/* Only add the SoC's DRAM memory map and fixed resources once */
- if (domain->path.domain.domain == 0) {
+ if (is_domain0(domain)) {
add_pci_cfg_resources(domain, &idx);
read_soc_memmap_resources(domain, &idx);
diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c
index 81c9a64..e0caea6 100644
--- a/src/soc/cavium/cn81xx/soc.c
+++ b/src/soc/cavium/cn81xx/soc.c
@@ -386,8 +386,7 @@
static void enable_soc_dev(struct device *dev)
{
- if (dev->path.type == DEVICE_PATH_DOMAIN &&
- dev->path.domain.domain == 0) {
+ if (is_domain0(dev)) {
dev->ops = &pci_domain_ops_ecam0;
} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
dev->ops = &soc_ops;
diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c
index 22f8b6f..0b2b9f4 100644
--- a/src/soc/intel/xeon_sp/uncore_acpi.c
+++ b/src/soc/intel/xeon_sp/uncore_acpi.c
@@ -560,7 +560,7 @@
struct acpi_rsdp *rsdp)
{
/* Only write uncore ACPI tables for domain0 */
- if (device->path.domain.domain != 0)
+ if (!is_domain0(device))
return current;
acpi_srat_t *srat;
--
To view, visit https://review.coreboot.org/c/coreboot/+/83643?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae570ba750cb29456436349b4263808e2e410e2e
Gerrit-Change-Number: 83643
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83642?usp=email )
Change subject: device: move is_domain0 and is_dev_on_domain0 to common code
......................................................................
device: move is_domain0 and is_dev_on_domain0 to common code
Move is_domain0 and is_dev_on_domain0 from the Intel Xeon SP code to the
common coreboot code so that it can be used elsewhere in coreboot too,
and while moving also implement it as functions instead of macros which
is more in line with the rest of helper functions in that new file.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I954251ebc82802c77bf897dfa2db54aa10bc5ac4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83642
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Shuo Liu <shuo.liu(a)intel.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/device/device_util.c
M src/include/device/device.h
M src/soc/intel/xeon_sp/include/soc/chip_common.h
3 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Shuo Liu: Looks good to me, but someone else must approve
Angel Pons: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
build bot (Jenkins): Verified
diff --git a/src/device/device_util.c b/src/device/device_util.c
index 6a45770..2e97ece 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -261,6 +261,16 @@
return NULL;
}
+bool is_domain0(const struct device *dev)
+{
+ return dev && dev->path.type == DEVICE_PATH_DOMAIN && dev->path.domain.domain == 0;
+}
+
+bool is_dev_on_domain0(const struct device *dev)
+{
+ return is_domain0(dev_get_domain(dev));
+}
+
/**
* Allocate 64 more resources to the free list.
*
diff --git a/src/include/device/device.h b/src/include/device/device.h
index 1b2e097..ac8a117 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -194,6 +194,8 @@
bool is_enabled_pci(const struct device *pci);
bool is_pci_dev_on_bus(const struct device *pci, unsigned int bus);
bool is_pci_bridge(const struct device *pci);
+bool is_domain0(const struct device *dev);
+bool is_dev_on_domain0(const struct device *dev);
/* Returns whether there is a hotplug port on the path to the given device. */
bool dev_path_hotplug(const struct device *);
diff --git a/src/soc/intel/xeon_sp/include/soc/chip_common.h b/src/soc/intel/xeon_sp/include/soc/chip_common.h
index c5553c0..4731bec 100644
--- a/src/soc/intel/xeon_sp/include/soc/chip_common.h
+++ b/src/soc/intel/xeon_sp/include/soc/chip_common.h
@@ -83,9 +83,6 @@
#define is_dev_on_ubox_domain(dev) is_ubox_domain(dev_get_domain(dev))
#define is_dev_on_cxl_domain(dev) is_cxl_domain(dev_get_domain(dev))
-#define is_domain0(dev) (dev && dev->path.type == DEVICE_PATH_DOMAIN &&\
- dev->path.domain.domain == 0)
-#define is_dev_on_domain0(dev) (is_domain0(dev_get_domain(dev)))
#define is_stack0(socket, stack) (socket == 0 && stack == IioStack0)
void unlock_pam_regions(void);
--
To view, visit https://review.coreboot.org/c/coreboot/+/83642?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I954251ebc82802c77bf897dfa2db54aa10bc5ac4
Gerrit-Change-Number: 83642
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83640?usp=email )
Change subject: mb/protectli/vault_[adl_p,bsw]/Kconfig: drop unneeded MAINBOARD_VENDOR
......................................................................
mb/protectli/vault_[adl_p,bsw]/Kconfig: drop unneeded MAINBOARD_VENDOR
MAINBOARD_VENDOR is already provided by the Kconfig file on the vendor
level, so there's no need to redefine it to the same value at the
mainboard level.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Icfcbcec005fadb8eaf1b8f90e1d71b3c6ee32088
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83640
Reviewed-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/protectli/vault_adl_p/Kconfig
M src/mainboard/protectli/vault_bsw/Kconfig
2 files changed, 0 insertions(+), 7 deletions(-)
Approvals:
Paul Menzel: Looks good to me, but someone else must approve
Felix Singer: Looks good to me, approved
Nico Huber: Looks good to me, approved
build bot (Jenkins): Verified
Michał Żygowski: Looks good to me, approved
diff --git a/src/mainboard/protectli/vault_adl_p/Kconfig b/src/mainboard/protectli/vault_adl_p/Kconfig
index 51fb7c5..b7578ab 100644
--- a/src/mainboard/protectli/vault_adl_p/Kconfig
+++ b/src/mainboard/protectli/vault_adl_p/Kconfig
@@ -23,9 +23,6 @@
config MAINBOARD_PART_NUMBER
default "VP66XX"
-config MAINBOARD_VENDOR
- default "Protectli"
-
config MAINBOARD_FAMILY
default "Vault Pro"
diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig
index 9bbb1b9..8650b57 100644
--- a/src/mainboard/protectli/vault_bsw/Kconfig
+++ b/src/mainboard/protectli/vault_bsw/Kconfig
@@ -29,10 +29,6 @@
default "FW2B" if BOARD_PROTECTLI_FW2B
default "FW4B" if BOARD_PROTECTLI_FW4B
-config MAINBOARD_VENDOR
- string
- default "Protectli"
-
config DIMM_MAX
default 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83640?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfcbcec005fadb8eaf1b8f90e1d71b3c6ee32088
Gerrit-Change-Number: 83640
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Kopeć, Michał Żygowski.
Paul Menzel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email )
Change subject: ec/dasharo/ec: add Dasharo features
......................................................................
Patch Set 12:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82672/comment/b7153f93_9289507d?us… :
PS12, Line 13:
Can this be tested without a board, for example in QEMU?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d
Gerrit-Change-Number: 82672
Gerrit-PatchSet: 12
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 25 Jul 2024 21:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No