Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2:
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/658edaf0_cbff710f?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
> > Can't say that I know the language. Is there a way to make this not […]
shoot me, please
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin.
Arthur Heymans has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/36196247_eb6ce874?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
> Can't say that I know the language. Is there a way to make this not
> part of the global scope?
iirc go uses casing for scope. Uppercase letter: global, lowercase: local.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/7fa8e16e_4b1f0111?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
Can't say that I know the language. Is there a way to make this not
part of the global scope?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Julius Werner, Paul Menzel, Shelley Chen.
Bharath N has posted comments on this change by Bharath N. ( https://review.coreboot.org/c/qc_blobs/+/83305?usp=email )
Change subject: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/qc_blobs/+/83305/comment/37ecfba6_09d3740c?us… :
PS2, Line 7: blobs binaries
> I would remove "binaries". […]
done
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: qc_blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Gerrit-Change-Number: 83305
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Bharath N, Julius Werner, Paul Menzel, Shelley Chen.
Hello Julius Werner, Shelley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
to look at the new patch set (#3).
Change subject: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
......................................................................
sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
TEST=Validated on qualcomm sc7180 development board
Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Signed-off-by: Bharath N <quic_bharn(a)quicinc.com>
---
M sc7180/qtiseclib/Release_Notes.txt
M sc7180/qtiseclib/libqtisec.a
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/05/83305/3
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: qc_blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Gerrit-Change-Number: 83305
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Bharath N <quic_bharn(a)quicinc.com>
Attention is currently required from: Alexander Couzens, Anastasios Koutian, Nico Huber.
Angel Pons has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83280?usp=email )
Change subject: mb/lenovo/t420: Use vendor default power limits
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Do we know if Lenovo always used the same numbers? i.e. irrespective […]
Would be good to check the values when using a dual-core CPU and a quad-core CPU
--
To view, visit https://review.coreboot.org/c/coreboot/+/83280?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia187b67ae28fbcda7d5d0e35ec64a3b21d97a21b
Gerrit-Change-Number: 83280
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Jonathon Hall, Martin L Roth, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford.
Matt DeVillier has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email )
Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727
Gerrit-Change-Number: 83119
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 05 Jul 2024 15:31:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes