Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83362?usp=email )
Change subject: payloads/ipxe: Update stable commit id to master
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83362?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib60e9b3793b3245409724d212edd31da70572265
Gerrit-Change-Number: 83362
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Martin L Roth.
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83362?usp=email )
Change subject: payloads/ipxe: Update stable commit id to master
......................................................................
payloads/ipxe: Update stable commit id to master
The iPXE stable commit id is quite old and doesn't even compile with the
current coreboot toolchain due to build errors. So update it to the most
recent commit which is available on the master branch.
b66e27d9b2: [ipv6] Expose router address for DHCPv6 leased addresses
Tested that iPXE compiles again.
Change-Id: Ib60e9b3793b3245409724d212edd31da70572265
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/iPXE/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/83362/1
diff --git a/payloads/external/iPXE/Makefile b/payloads/external/iPXE/Makefile
index 7ec8126..9d51d88 100644
--- a/payloads/external/iPXE/Makefile
+++ b/payloads/external/iPXE/Makefile
@@ -2,7 +2,7 @@
# 2022.1 - Last commit of January 2022
# When updating, change the name both here and in payloads/external/iPXE/Kconfig
-STABLE_COMMIT_ID=6ba671acd922ee046b257c5119b8a0f64d275473
+STABLE_COMMIT_ID=b66e27d9b29a172a097c737ab4d378d60fe01b05
TAG-$(CONFIG_IPXE_MASTER)=origin/master
TAG-$(CONFIG_IPXE_STABLE)=$(STABLE_COMMIT_ID)
--
To view, visit https://review.coreboot.org/c/coreboot/+/83362?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib60e9b3793b3245409724d212edd31da70572265
Gerrit-Change-Number: 83362
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83361?usp=email )
Change subject: payloads/ipxe/kconfig: Fix option name prefix
......................................................................
payloads/ipxe/kconfig: Fix option name prefix
With commit 238ff1e9c7 ("payloads/ipxe: Prefix iPXE options with "IPXE"
instead "PXE""), the prefix for iPXE related Kconfig identifiers was
unified to "IPXE". So rename the identifier for the TRUST_CMD option as
well, which was introduced later.
Change-Id: I918358b859003503526ba7849494bb23f8c893fd
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/iPXE/Kconfig
M payloads/external/iPXE/Makefile
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/83361/1
diff --git a/payloads/external/iPXE/Kconfig b/payloads/external/iPXE/Kconfig
index 02dce27..ff25d81 100644
--- a/payloads/external/iPXE/Kconfig
+++ b/payloads/external/iPXE/Kconfig
@@ -108,7 +108,7 @@
Enable HTTPS protocol, which allows you to encrypt all communication
with a web server and to verify the server's identity
-config PXE_TRUST_CMD
+config IPXE_TRUST_CMD
bool "Enable TRUST commands"
default y
help
diff --git a/payloads/external/iPXE/Makefile b/payloads/external/iPXE/Makefile
index 91074fe..7ec8126 100644
--- a/payloads/external/iPXE/Makefile
+++ b/payloads/external/iPXE/Makefile
@@ -52,7 +52,7 @@
ifeq ($(CONFIG_IPXE_HAS_HTTPS),y)
sed -i'' 's|.*DOWNLOAD_PROTO_HTTPS|#define DOWNLOAD_PROTO_HTTPS|g' "$(project_dir)/src/config/general.h"
endif
-ifeq ($(CONFIG_PXE_TRUST_CMD),y)
+ifeq ($(CONFIG_IPXE_TRUST_CMD),y)
sed -i'' 's|.*IMAGE_TRUST_CMD|#define IMAGE_TRUST_CMD|g' "$(project_dir)/src/config/general.h"
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/83361?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I918358b859003503526ba7849494bb23f8c893fd
Gerrit-Change-Number: 83361
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Arthur Heymans.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83358?usp=email )
Change subject: autoport: Drop ioapic, ioapic_irq, and lapic handling for devicetree
......................................................................
Patch Set 3:
(1 comment)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83358/comment/2803749b_ad1e740d?us… :
PS2, Line 363: "lapic"
> lapic is no longer valid either.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83358?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf2582594b244cf5f726c722eb3a3c12573a2662
Gerrit-Change-Number: 83358
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 06 Jul 2024 17:30:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Arthur Heymans, Nicholas Chin.
Hello Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83358?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins)
Change subject: autoport: Drop ioapic, ioapic_irq, and lapic handling for devicetree
......................................................................
autoport: Drop ioapic, ioapic_irq, and lapic handling for devicetree
The ioapic and ioapic_irq keywords are no longer valid tokens as of
commit e84b095d3a23 (util/sconfig: Remove unused ioapic and irq
keywords), and the associated driver had previously been removed in
commit ca5a793ec31c (drivers/generic/ioapic: Drop poor implementation).
Thus, drop them from autoport. Also, the IOAPICIRQs map that this code
relied on to generate ioapic_irq entries never seems to have been
populated by any code in any previous commit, so this appears to have
been dead code since autoport was created.
The lapic keyword was removed from sconfig in commit 15d5183e4af7
(util/sconfig: Remove lapic devices from devicetree parsers) so remove
autoport handling for it as well.
Change-Id: Icf2582594b244cf5f726c722eb3a3c12573a2662
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/autoport/main.go
1 file changed, 1 insertion(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83358/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83358?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf2582594b244cf5f726c722eb3a3c12573a2662
Gerrit-Change-Number: 83358
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Elyes Haouas has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/13044?usp=email )
Change subject: Make Ada a first class citizen
......................................................................
Patch Set 16:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/13044/comment/6c5348ed_03347099?us… :
PS16, Line 362: +=
> I just mimicked `CFLAGS_common` I guess. The difference is subtle and if […]
thank you
--
To view, visit https://review.coreboot.org/c/coreboot/+/13044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70df9adbd467ecd2dc7c5c1cf418b7765aca4e93
Gerrit-Change-Number: 13044
Gerrit-PatchSet: 16
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 06 Jul 2024 12:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/13044?usp=email )
Change subject: Make Ada a first class citizen
......................................................................
Patch Set 16:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/13044/comment/607e19c7_0cef9114?us… :
PS16, Line 362: +=
> I mean as it is the first time `ADAFLAGS_common ` is used here, why you used `+=` instead of ` := ` […]
I just mimicked `CFLAGS_common` I guess. The difference is subtle and if
we did the right thing wrt. future changes can only be decided in the future.
Generally, I like to think about the various `Makefile.mk`s that their order
shouldn't matter.
--
To view, visit https://review.coreboot.org/c/coreboot/+/13044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70df9adbd467ecd2dc7c5c1cf418b7765aca4e93
Gerrit-Change-Number: 13044
Gerrit-PatchSet: 16
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 06 Jul 2024 11:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Maximilian Brune.
Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83313?usp=email )
Change subject: Makefile.mk: Remove bc dependency
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83313/comment/64fb3e09_3074d129?us… :
PS1, Line 9: commit:
: 229e021110: Makefile.inc: Add left shift macro
> I updated the commit-msg. But I would like to leave the gerrit link (CB... […]
Okay, sure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83313?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab4bc2bd7a45e84b923d4fe7ec473e6c7db2146
Gerrit-Change-Number: 83313
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Sat, 06 Jul 2024 10:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>