Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83364?usp=email )
Change subject: [test] Enable Wparentheses for LLVM
......................................................................
Patch Set 1:
(1 comment)
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/83364/comment/bf8ae4ec_c3b82055?us… :
PS1, Line 265: CLANG_CFLAGS_${TARCH}+=-Qunused-arguments -m${TWIDTH}
: # tone down clang compiler warnings
: CLANG_CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare
: CLANG_CFLAGS_${TARCH}+=-Wno-shift-overflow -Wno-address-of-packed-member -Wno-initializer-overrides
: CL
While on it, could you please move each option into their own line please?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83364?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I346c078988f3afe3487aea02bb91c86fb47c0cb7
Gerrit-Change-Number: 83364
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 07 Jul 2024 11:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons, Felix Held, Felix Singer, Martin Roth, Michał Żygowski, Paul Menzel.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83004?usp=email )
Change subject: util/superiotool/fintek: Add f81866 register table
......................................................................
Patch Set 14:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83004/comment/5ffc053a_f548c545?us… :
PS9, Line 12: 1
> Putting URLs in the commit message is discouraged as they frequently become stale as the website cha […]
Done
https://review.coreboot.org/c/coreboot/+/83004/comment/b1adb681_7eca6416?us… :
PS9, Line 20: LDN 0xfe
> > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
File util/superiotool/fintek.c:
https://review.coreboot.org/c/coreboot/+/83004/comment/b47e5967_bc83f55b?us… :
PS11, Line 521: {0x30,0x60,0x61,0x70,0x71,0x72,0x73,0x7e,0x7f, 0xf0,0xf1,0xf2,0xf3,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9, 0xe0,0xe1,0xe2,0xe3,0xe8,0xe9, 0xd0,0xd1,0xd2,0xd3, 0xc0,0xc1,0xc2,0xc3, 0xb0,0xb1,0xb2,0xb3, 0xa0,0xa1,0xa2,0xa3,0xa8,0xa9, 0x90,0x91,0x92,0x93, 0x80,0x81,0x82,0x83, 0x88,0x89,0x8a,0x8b,0x8e,0x8f, 0xef, EOT},
> Please wrap these lines, as done in other Super I/Os. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83004?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Gerrit-Change-Number: 83004
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 07 Jul 2024 09:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Maxim.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83019?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: util/superiotool/fintek: Add f81966 register table
......................................................................
util/superiotool/fintek: Add f81966 register table
In accordance with the F81962/F81964/F81966/F81967 datasheet:
Release Date: Feb, 2018, Version: V0.18P [1].
[1] https://web.archive.org/web/20240707052102/http://www.jetwaycomputer.com/download/Fintek/F81966_wdt_gpio.zip
Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 157 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83019/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/83019?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Gerrit-Change-Number: 83019
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Attention is currently required from: Felix Held, Felix Singer, Maxim, Michał Żygowski, Paul Menzel.
Hello Felix Held, Felix Singer, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83004?usp=email
to look at the new patch set (#14).
Change subject: util/superiotool/fintek: Add f81866 register table
......................................................................
util/superiotool/fintek: Add f81866 register table
In accordance with the F81866A datasheet:
Release Date: Jan, 2012, Version: V0.14P [1].
[1] https://web.archive.org/web/20240707051837/http://www.
jetwaycomputer.com/download/Fintek/F81866_wdt_gpio.zip
Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 179 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83004/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/83004?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Gerrit-Change-Number: 83004
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Felix Singer, Maxim, Michał Żygowski, Paul Menzel.
Hello Felix Held, Felix Singer, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83004?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/superiotool/fintek: Add f81866 register table
......................................................................
util/superiotool/fintek: Add f81866 register table
In accordance with the F81866A datasheet:
Release Date: Jan, 2012, Version: V0.14P [1].
[1] https://web.archive.org/web/20240707051837/http://www.
jetwaycomputer.com/download/Fintek/F81866_wdt_gpio.zip
Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 164 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83004/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/83004?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Gerrit-Change-Number: 83004
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83019?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/superiotool/fintek: Add f81966 register table
......................................................................
util/superiotool/fintek: Add f81966 register table
In accordance with the F81962/F81964/F81966/F81967 datasheet:
Release Date: Feb, 2018, Version: V0.18P [1].
Tested on Asrock IMB-1222 [2].
[1] https://web.archive.org/web/20240707052102/http://www.jetwaycomputer.com/download/Fintek/F81966_wdt_gpio.zip
[2] CB:83107
Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 135 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83019/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/83019?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Gerrit-Change-Number: 83019
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Martin L Roth.
Hello Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83363?usp=email
to look at the new patch set (#2).
Change subject: payloads/ipxe/makefile: Use git reset for resetting config state
......................................................................
payloads/ipxe/makefile: Use git reset for resetting config state
At the moment copies of the original configuration files are created
before customisations are applied and the state is reset by copying them
back after the build finished, so that the state is not left dirty when
another build is done. That's not just overly complicated but it also
doesn't allow debugging the state after the build finished and the state
is left dirty when the build gets interrupted in between.
Simplify resetting the state by using `git reset --hard` before config
customisations are applied, which makes the file copies superfluous and
it also leaves the tree dirty after the build.
Change-Id: I325cf4d155780208b6f9cbbc49e50a69a4d59dd3
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/iPXE/Makefile
1 file changed, 2 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/83363/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83363?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I325cf4d155780208b6f9cbbc49e50a69a4d59dd3
Gerrit-Change-Number: 83363
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83363?usp=email )
Change subject: payloads/ipxe/makefile: Use git checkout for resetting config state
......................................................................
payloads/ipxe/makefile: Use git checkout for resetting config state
At the moment copies of the original configuration files are created
before customisations are applied and the state is reset by copying them
back after the build finished, so that the state is not left dirty when
another build is done. That's not just overly complicated but it also
doesn't allow debugging the state after the build finished and the state
is left dirty when the build gets interrupted in between.
Simplify resetting the state by using `git reset --hard` before config
customisations are applied, which makes the file copies superfluous and
it also leaves the tree dirty after the build.
Change-Id: I325cf4d155780208b6f9cbbc49e50a69a4d59dd3
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/iPXE/Makefile
1 file changed, 2 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/83363/1
diff --git a/payloads/external/iPXE/Makefile b/payloads/external/iPXE/Makefile
index 7ec8126..05475a3 100644
--- a/payloads/external/iPXE/Makefile
+++ b/payloads/external/iPXE/Makefile
@@ -33,16 +33,13 @@
git checkout -b coreboot $(TAG-y)
config: checkout
+ cd $(project_dir); \
+ git reset --hard
ifeq ($(CONSOLE_SERIAL),yy)
- cp "$(project_dir)/src/config/console.h" "$(project_dir)/src/config/console.h.cb"
- cp "$(project_dir)/src/config/serial.h" "$(project_dir)/src/config/serial.h.cb"
sed -i'' 's|//#define\s*CONSOLE_SERIAL.*|#define CONSOLE_SERIAL|' "$(project_dir)/src/config/console.h"
sed -i'' 's|#define\s*COMCONSOLE.*|#define COMCONSOLE $(IPXE_UART)|' "$(project_dir)/src/config/serial.h"
sed -i'' 's|#define\s*COMSPEED.*|#define COMSPEED $(CONFIG_TTYS0_BAUD)|' "$(project_dir)/src/config/serial.h"
endif
-ifneq ($(filter y,$(CONFIG_HAS_SCRIPT) $(CONFIG_IPXE_NO_PROMPT)),)
- cp "$(project_dir)/src/config/general.h" "$(project_dir)/src/config/general.h.cb"
-endif
ifeq ($(CONFIG_HAS_SCRIPT),y)
sed -i'' 's|//#define\s*IMAGE_SCRIPT.*|#define IMAGE_SCRIPT|' "$(project_dir)/src/config/general.h"
endif
@@ -65,13 +62,6 @@
$(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom
endif
cp $(project_dir)/src/bin/$(PXE_ROM_PCI_ID).rom $(project_dir)/ipxe.rom
-ifeq ($(CONSOLE_SERIAL),yy)
- cp "$(project_dir)/src/config/console.h.cb" "$(project_dir)/src/config/console.h"
- cp "$(project_dir)/src/config/serial.h.cb" "$(project_dir)/src/config/serial.h"
-endif
-ifneq ($(filter y,$(CONFIG_HAS_SCRIPT) $(CONFIG_IPXE_NO_PROMPT)),)
- cp "$(project_dir)/src/config/general.h.cb" "$(project_dir)/src/config/general.h"
-endif
clean:
test -d $(project_dir) && $(MAKE) -C $(project_dir)/src veryclean || exit 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/83363?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I325cf4d155780208b6f9cbbc49e50a69a4d59dd3
Gerrit-Change-Number: 83363
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>