coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Drop GPIO by I/O
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Fabian Groffen, Felix Held, Keith Hui, Keith Hui. Martin L Roth has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75145?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/asus/p8z77-m: Drop GPIO by I/O ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Added a second LPC generic decode and this GPIO by I/O actually works - I can toggle DRAM_LED right […] Keith, Sorry, I'm confused by the last comment. What did we want to do with this patch? Should it get merged or not? -- To view, visit https://review.coreboot.org/c/coreboot/+/75145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22654f3c77082bf163ab7000ec467ab7085a0534 Gerrit-Change-Number: 75145 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:43:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: mb/asrock/z97_extreme6: Fix EDID mapping for DVI-I
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Angel Pons, Nicholas Chin, Nico Huber. Martin L Roth has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/82753?usp=email ) Change subject: mb/asrock/z97_extreme6: Fix EDID mapping for DVI-I ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82753/comment/3b42f6e8_164929b6?us… : PS1, Line 13: Not yet tested. Are you going to test it before merging or no? -- To view, visit https://review.coreboot.org/c/coreboot/+/82753?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8239917e2f7ee5bb982621752ec406c2d3ca302 Gerrit-Change-Number: 82753 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: include: Remove unused <string.h>
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82622?usp=email ) Change subject: include: Remove unused <string.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2824cbc8525f861d36cefebf2741e009f13a12 Gerrit-Change-Number: 82622 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:39:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: arch/riscv/include/vm.h: Remove unused <string.h>
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Elyes Haouas, Philipp Hug, Ron Minnich. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82621?usp=email ) Change subject: arch/riscv/include/vm.h: Remove unused <string.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I910cd5bd6ee524ebb43955615f20a8aa24395b13 Gerrit-Change-Number: 82621 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:39:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h>
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82620?usp=email ) Change subject: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82620?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14bb98dad11d34d4e1c6fd1374ace0a5306b070f Gerrit-Change-Number: 82620 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:39:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/intel/avenuecity_crb/romstage: Remove unused <string.h>
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82619?usp=email ) Change subject: mb/intel/avenuecity_crb/romstage: Remove unused <string.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49694e85263939092cd28db3499705e1a19e3d7a Gerrit-Change-Number: 82619 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:38:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Fix int-shift-left
by Felix Singer (Code Review) 09 Jul '24

09 Jul '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83377?usp=email ) Change subject: Makefile.mk: Fix int-shift-left ...................................................................... Makefile.mk: Fix int-shift-left commit 4a8d73d6a4 ("Makefile.mk: Remove bc dependency") broke the left shift, since the expr tool does not support shifting operations. This patch uses the left shift operator inside arithmetic expansion. Every posix shell should support this. Tested: Build amd/birman mainboard and check that the soft-fuse parameter doesn't change. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c Reviewed-on: https://review.coreboot.org/c/coreboot/+/83377 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved Martin L Roth: Looks good to me, approved Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Makefile.mk b/Makefile.mk index 592365e..b4532c3 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -178,7 +178,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) -int-shift-left=$(shell expr $(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1))) +int-shift-left=$(shell echo -n $$(($(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1))))) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \< $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \> $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1)))) -- To view, visit https://review.coreboot.org/c/coreboot/+/83377?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c Gerrit-Change-Number: 83377 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Fix int-shift-left
by Martin L Roth (Code Review) 09 Jul '24

09 Jul '24

Attention is currently required from: Maximilian Brune. Martin L Roth has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83377?usp=email ) Change subject: Makefile.mk: Fix int-shift-left ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83377?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c Gerrit-Change-Number: 83377 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 08 Jul 2024 22:37:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Keith Short (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Abhishek Pandit-Subedi, Keith Short, Shelley Chen. Keith Short has uploaded a new patch set (#3) to the change originally created by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... ec/google/chromeec: Stop checking CBI for UCSI The ucsi_enabled flag is no longer used by the EC. Update coreboot to only use only EC_FEATURE_UCSI_PPM to determine whether UCSI is enabled. BUG=b:319124515 TEST=emerge-brox coreboot chromeos-bootimage Cq-Depend: chromium:5664227 Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> --- M src/ec/google/chromeec/ec.c 1 file changed, 1 insertion(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/83252/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Keith Short <keithshort(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Keith Short <keithshort(a)chromium.org> Gerrit-Attention: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org>

1 0

[XS] Change in coreboot[main]: Makefile: unexport CFLAGS
by Name of user not set (Code Review) 08 Jul '24

08 Jul '24

Name of user not set #1005536 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email ) Change subject: Makefile: unexport CFLAGS ...................................................................... Makefile: unexport CFLAGS Whenever CFLAGS variable is present in environment, make doesn't treat CFLAGS assignments locally. This may lead to compile errors due to -Wextra flag leaking. Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1 Signed-off-by: Torsten Schenk <coreboot(a)mail.schenk.biz> --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83379/1 diff --git a/Makefile b/Makefile index cc73900..1e6be31 100644 --- a/Makefile +++ b/Makefile @@ -3,6 +3,9 @@ ifneq ($(words $(CURDIR)),1) $(error Error: Path to the main directory cannot contain spaces) endif + +unexport CFLAGS + top := $(CURDIR) src := src srck := $(top)/util/kconfig -- To view, visit https://review.coreboot.org/c/coreboot/+/83379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1 Gerrit-Change-Number: 83379 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005536

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024