Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83381?usp=email )
Change subject: Documentation/Makefile: Fix test target
......................................................................
Documentation/Makefile: Fix test target
The test target called make with the `-K` flag, which is not valid.
Change it to `-k` (keep going if some targets fail) which is what was
probably intended.
It also tried to build the `doctest` target from Makefile.sphinx, which
results in an error. Further investigation reveals that this is because
the sphinx doctest extension was not enabled in conf.py. However, from
the documentation of doctest [1], it seems like it is intended to ensure
that documentation containing Python snippets along with the expected
output of the snippet remain in sync, which is something that we
probably don't need. So, remove the call to it.
[1] https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html"
Change-Id: Id514950b4486ed8644d078af222c96ed711fc8f9
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Documentation/Makefile
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/83381/1
diff --git a/Documentation/Makefile b/Documentation/Makefile
index ec1e1a4..6d2a641 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -31,8 +31,7 @@
test:
@echo "Test for logging purposes - Failing tests will not fail the build"
- -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx html
- -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx doctest
+ -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -k -f Makefile.sphinx html
help:
@echo "all - Builds all documentation targets"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83381?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id514950b4486ed8644d078af222c96ed711fc8f9
Gerrit-Change-Number: 83381
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Elyes Haouas.
Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83159?usp=email )
Change subject: Doc/mainboard/gigabyte/ga-g41m-es2l: Use tutorial/part1.md
......................................................................
Patch Set 2:
(2 comments)
File Documentation/mainboard/gigabyte/ga-g41m-es2l.md:
https://review.coreboot.org/c/coreboot/+/83159/comment/9d6afd9f_bd5cb0b9?us… :
PS2, Line 46: S
> Seems like this needs to be lowercase to actually work. […]
Sorry, all lower case
```suggestion
[get sources](../../tutorial/part1.md#step-2-download-coreboot-source-tree)
```
https://review.coreboot.org/c/coreboot/+/83159/comment/6cdb5249_10d68dec?us… :
PS2, Line 62: S
> Same here […]
```suggestion
[Build coreboot toolchain](../../tutorial/part1.md#step-3-build-the-coreboot-toolchain)
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83159?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4917d20fe327628dbc156e85a85b1d439915a77
Gerrit-Change-Number: 83159
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 09 Jul 2024 00:37:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Elyes Haouas.
Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83159?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Doc/mainboard/gigabyte/ga-g41m-es2l: Use tutorial/part1.md
......................................................................
Patch Set 2:
(2 comments)
File Documentation/mainboard/gigabyte/ga-g41m-es2l.md:
https://review.coreboot.org/c/coreboot/+/83159/comment/7d20ea02_707eb3a0?us… :
PS2, Line 46: S
Seems like this needs to be lowercase to actually work. When I test it it just links to the top of part1.md
```suggestion
[get sources](../../tutorial/part1.md#step-2-Download-coreboot-source-tree)
```
https://review.coreboot.org/c/coreboot/+/83159/comment/7337aa06_847a6bf0?us… :
PS2, Line 62: S
Same here
```suggestion
[Build coreboot toolchain](../../tutorial/part1.md#step-3-Build-the-coreboot-toolchain)
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83159?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4917d20fe327628dbc156e85a85b1d439915a77
Gerrit-Change-Number: 83159
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 09 Jul 2024 00:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth, Name of user not set #1005536.
Felix Singer has posted comments on this change by Name of user not set #1005536. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email )
Change subject: Makefile: unexport CFLAGS
......................................................................
Patch Set 1:
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/83379/comment/f40a0a87_6a344682?us… :
PS1, Line 7: unexport CFLAGS
Should we unexport LDFLAGS too? Anything else?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83379?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1
Gerrit-Change-Number: 83379
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1005536
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Name of user not set #1005536
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2024 00:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82620?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I rebased and it looks like the include was removed by another patch, since it vanished from the fil […]
Unresolved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82620?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I14bb98dad11d34d4e1c6fd1374ace0a5306b070f
Gerrit-Change-Number: 82620
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Jul 2024 23:58:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Elyes Haouas.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82619?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/intel/avenuecity_crb/romstage: Remove unused <string.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I rebased and it looks like the include was removed by another patch, since it vanished from the file list. So it can be abandoned.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82619?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49694e85263939092cd28db3499705e1a19e3d7a
Gerrit-Change-Number: 82619
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Jul 2024 23:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82620?usp=email )
Change subject: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I rebased and it looks like the include was removed by another patch, since it vanished from the file list. So it can be abandoned.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82620?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I14bb98dad11d34d4e1c6fd1374ace0a5306b070f
Gerrit-Change-Number: 82620
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Jul 2024 23:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Philipp Hug, Ron Minnich.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82621?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/riscv/include/vm.h: Remove unused <string.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I rebased and it looks like the include was removed by another patch, since it vanished from the file list. So it can be abandoned.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82621?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I910cd5bd6ee524ebb43955615f20a8aa24395b13
Gerrit-Change-Number: 82621
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Jul 2024 23:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82622?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: include: Remove unused <string.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I rebased and it looks like the include was removed by another patch, since it vanished from the file list.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82622?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide2824cbc8525f861d36cefebf2741e009f13a12
Gerrit-Change-Number: 82622
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 08 Jul 2024 23:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No