coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: Revert "Makefile.mk: Remove bc dependency"
by Maximilian Brune (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Held. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83375?usp=email ) Change subject: Revert "Makefile.mk: Remove bc dependency" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Please test your changes before you push them, or push them as WIP or private by default. I gave it another go here: CB:83377 (this time tested, although I would appreciate someone confirming this). Should we just go through with the revert or use the new patch instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f Gerrit-Change-Number: 83375 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:40:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Fix int-shift-left
by Maximilian Brune (Code Review) 08 Jul '24

08 Jul '24

Maximilian Brune has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83377?usp=email ) Change subject: Makefile.mk: Fix int-shift-left ...................................................................... Makefile.mk: Fix int-shift-left commit 4a8d73d6a4 ("Makefile.mk: Remove bc dependency") broke the left shift, since the expr tool does not support shifting operations. This patch uses the left shift operator inside arithmetic expansion. Every posix shell should support this. Tested: Build amd/birman mainboard and check that the soft-fuse paramter doesn't change. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/83377/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83377?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c Gerrit-Change-Number: 83377 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Remove bc dependency
by Maximilian Brune (Code Review) 08 Jul '24

08 Jul '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83377?usp=email ) Change subject: Makefile.mk: Remove bc dependency ...................................................................... Makefile.mk: Remove bc dependency bc was added as dependency in commit 229e021110 ("Makefile.inc: Add left shift macro") bc is not stated as dependency in our docs (e.g. package installation). If you don't have bc installed you can easily get false positives on coreboot builds. For example you build a mainboard and coreboot tells you the build succeeded, even though you don't have bc installed. This patch uses the left shift operator inside arithmetic expansion. Every posix shell should support this. Tested: Build amd/birman mainboard and check that the soft-fuse paramter doesn't change. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/83377/1 diff --git a/Makefile.mk b/Makefile.mk index 68fc8c9..b4532c3 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -178,7 +178,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) -int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc) +int-shift-left=$(shell echo -n $$(($(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1))))) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \< $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \> $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1)))) -- To view, visit https://review.coreboot.org/c/coreboot/+/83377?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3b29dae727875b0788100a2cb02c86736ffaf8c Gerrit-Change-Number: 83377 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XL] Change in coreboot[main]: mb/novacustom: add V5x0TU board (Meteor Lake)
by Michał Kopeć (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Żygowski. Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email ) Change subject: mb/novacustom: add V5x0TU board (Meteor Lake) ...................................................................... Patch Set 12: (2 comments) File src/mainboard/novacustom/mtl-h/Kconfig: https://review.coreboot.org/c/coreboot/+/82673/comment/8d588c86_2a1fae6f?us… : PS12, Line 69: 512 > 1024 for DDR5 Done File src/mainboard/novacustom/mtl-h/devicetree.cb: https://review.coreboot.org/c/coreboot/+/82673/comment/5c7ac3e3_685a710d?us… : PS12, Line 61: register "device_count" = "3" > Why 3? Should be 6, unused outputs should be counted too. Thanks for catching it -- To view, visit https://review.coreboot.org/c/coreboot/+/82673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771 Gerrit-Change-Number: 82673 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:08:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski. Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email ) Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... Patch Set 11: (7 comments) File src/ec/dasharo/ec/acpi/dasharo.asl: https://review.coreboot.org/c/coreboot/+/82672/comment/5fb9c0bb_e769faed?us… : PS10, Line 3: // Notifications: : // 0x80 - hardware backlight toggle : // 0x81 - backlight toggle : // 0x82 - backlight down : // 0x83 - backlight up : // 0x84 - backlight color change : // 0x85 - OLED screen toggle > These have been removed from the code, should be removed from here as well. Removed https://review.coreboot.org/c/coreboot/+/82672/comment/e2034191_340181c2?us… : PS10, Line 11: Name (_HID, "XXXX0000") // TODO: Update after we get a valid ACPI HID prefix > Don't we have one already? https://uefi. […] Indeed, changed to `DSHR4543` https://review.coreboot.org/c/coreboot/+/82672/comment/ad94d9b2_af5e1df4?us… : PS10, Line 17: Debug = "DASH: RSET" > Here `Debug` is directly written to, in other cases `Printf` is used, even for simple strings. […] Fixed File src/ec/dasharo/ec/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/82672/comment/65edf809_0ac96e70?us… : PS10, Line 95: ^^^^DASH.RSET() > Won't it unconditionally turn off airplane mode LED on wake? It would, if any of the devices we support had an airplane mode led :| Removed all dead airplane mode related code File src/ec/dasharo/ec/dasharo_ec.c: https://review.coreboot.org/c/coreboot/+/82672/comment/3ef067b1_3a128d66?us… : PS10, Line 43: 2 > REG_DATA Done https://review.coreboot.org/c/coreboot/+/82672/comment/28be766f_57748879?us… : PS10, Line 52: REG_CMD + 2 > REG_DATA Done https://review.coreboot.org/c/coreboot/+/82672/comment/935652f3_5b83fda5?us… : PS10, Line 200: #define SPI_ACCESS_SIZE 252 > IIUC this is `(DASHARO_EC_SIZE - REG_DATA - ARRAY_SIZE(read_cmd))` (the last operand defined below, […] Changed to `(DASHARO_EC_SIZE - REG_DATA - 2)` and added a comment explaining the `2` -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 08 Jul 2024 14:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Hello Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Verified+1 by build bot (Jenkins) Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 862 insertions(+), 316 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: mb/novacustom: add V5x0TU board (Meteor Lake)
by Michał Kopeć (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Hello Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82673?usp=email to look at the new patch set (#13). Change subject: mb/novacustom: add V5x0TU board (Meteor Lake) ...................................................................... mb/novacustom: add V5x0TU board (Meteor Lake) NovaCustom (Clevo) V5x0TU are two boards with Intel Core Ultra (Meteor Lake) series processors. Two variants (V540TU and V560TU) are supported. Their EC firmware is different due to keyboard layout changes. On coreboot's side, the only difference are SMBIOS strings. Working: - DDR5 SODIMM in slot RAM2 - M.2 2280 PCIe slots - Thunderbolt, USB ports - Video outputs in OS and firmware - I2C touchpad, webcam, SD Card reader - S0ix - Booting Ubuntu 24.04 with edk2 UefiPayload - Vboot, TPM measured boot Not working: - DDR5 SODIMM in slot RAM1 - PS/2 keyboard in edk2 - Onboard audio Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A src/mainboard/novacustom/Kconfig A src/mainboard/novacustom/Kconfig.name A src/mainboard/novacustom/mtl-h/Kconfig A src/mainboard/novacustom/mtl-h/Kconfig.name A src/mainboard/novacustom/mtl-h/Makefile.mk A src/mainboard/novacustom/mtl-h/acpi/backlight.asl A src/mainboard/novacustom/mtl-h/acpi/mainboard.asl A src/mainboard/novacustom/mtl-h/board_info.txt A src/mainboard/novacustom/mtl-h/bootblock.c A src/mainboard/novacustom/mtl-h/cmos.default A src/mainboard/novacustom/mtl-h/cmos.layout A src/mainboard/novacustom/mtl-h/data.vbt A src/mainboard/novacustom/mtl-h/devicetree.cb A src/mainboard/novacustom/mtl-h/dsdt.asl A src/mainboard/novacustom/mtl-h/fadt.c A src/mainboard/novacustom/mtl-h/gpio.c A src/mainboard/novacustom/mtl-h/gpio_early.c A src/mainboard/novacustom/mtl-h/hda_verb.c A src/mainboard/novacustom/mtl-h/include/mainboard/gpio.h A src/mainboard/novacustom/mtl-h/ramstage.c A src/mainboard/novacustom/mtl-h/romstage.c A src/mainboard/novacustom/mtl-h/vboot-rwab.fmd 22 files changed, 1,401 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/82673/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/82673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771 Gerrit-Change-Number: 82673 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Remove bc dependency"
by Maximilian Brune (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Held. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83375?usp=email ) Change subject: Revert "Makefile.mk: Remove bc dependency" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83375/comment/d63d0390_cc64ba7b?us… : PS1, Line 13: Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f > Missing Signed-off-by line. Interesting gerrit doesn't seem to add it by default if I use the gerrit UI to revert a patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f Gerrit-Change-Number: 83375 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 13:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Remove bc dependency"
by Maximilian Brune (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Held, Maximilian Brune. Hello Felix Held, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83375?usp=email to look at the new patch set (#2). Change subject: Revert "Makefile.mk: Remove bc dependency" ...................................................................... Revert "Makefile.mk: Remove bc dependency" This reverts commit 4a8d73d6a4af625f97af908911478d481b95b461. Reason for revert: expr does not support shifting. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/83375/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f Gerrit-Change-Number: 83375 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Remove bc dependency"
by Felix Singer (Code Review) 08 Jul '24

08 Jul '24

Attention is currently required from: Felix Held, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83375?usp=email ) Change subject: Revert "Makefile.mk: Remove bc dependency" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f Gerrit-Change-Number: 83375 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 08 Jul 2024 13:22:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024