coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: Makefile: update clean-symlink target
by Elyes Haouas (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83124?usp=email ) Change subject: Makefile: update clean-symlink target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c Gerrit-Change-Number: 83124 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 12:21:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Makefile: Add cleanall-symlink target
by Elyes Haouas (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83123?usp=email ) Change subject: Makefile: Add cleanall-symlink target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83123?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a56e7c628701e4a0471833443b08ab2bcceb27e Gerrit-Change-Number: 83123 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 12:19:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Makefile: Update symlink target
by Elyes Haouas (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Christian Walter, Felix Held, Martin L Roth. Elyes Haouas has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83122?usp=email ) Change subject: Makefile: Update symlink target ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b0d1b5bc19556bc41ca98519390e69ea104bd1b Gerrit-Change-Number: 83122 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Jun 2024 12:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: cpu/x86/smm: Enable SSE in SMM as well
by Patrick Rudolph (Code Review) 24 Jun '24

24 Jun '24

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83115?usp=email ) Change subject: cpu/x86/smm: Enable SSE in SMM as well ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83115?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idccfc35685c482ece5109f45a147096215d3f782 Gerrit-Change-Number: 83115 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Fix inclusion of site-local/Makefile.inc
by Elyes Haouas (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Werner Zeh. Elyes Haouas has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/83190?usp=email ) Change subject: Makefile.mk: Fix inclusion of site-local/Makefile.inc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36ad1aca5742869c84e2fb556f898f896c6f037a Gerrit-Change-Number: 83190 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 12:03:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: test commit
by Wen Zhang (Code Review) 24 Jun '24

24 Jun '24

Wen Zhang has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/83193?usp=email ) Change subject: test commit ...................................................................... test commit Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Signed-off-by: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com> --- A test 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/83193/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Gerrit-Change-Number: 83193 Gerrit-PatchSet: 3 Gerrit-Owner: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: test commit
by Wen Zhang (Code Review) 24 Jun '24

24 Jun '24

Wen Zhang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83193?usp=email ) Change subject: test commit ...................................................................... test commit Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Signed-off-by: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> --- A test 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/83193/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Gerrit-Change-Number: 83193 Gerrit-PatchSet: 2 Gerrit-Owner: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com>

1 0

[NoOp] Change in coreboot[main]: test commit
by Wen Zhang (Code Review) 24 Jun '24

24 Jun '24

Wen Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83193?usp=email ) Change subject: test commit ...................................................................... test commit Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Signed-off-by: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> --- A test 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/83193/1 diff --git a/test b/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test -- To view, visit https://review.coreboot.org/c/coreboot/+/83193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3723732a99fb34eeabe408995f3046077a2b6fc9 Gerrit-Change-Number: 83193 Gerrit-PatchSet: 1 Gerrit-Owner: Wen Zhang <zhangwen6(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE
by Poornima Tom (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya. Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83076?usp=email ) Change subject: mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/brya/variants/nivviks/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83076/comment/10e949e0_b49f5e4f?us… : PS8, Line 665: probe WIFI_CATEGORY WIFI_7 > oh Interesting wat to write the device under chip. Is that working? Could you check the static. […] Hi Eric, Have tested the BT connection , when wifi 7 module is connected. Also, lsusb -t , list BT on usb port8 as below: |__ Port 8: Dev 5, If 0, Class=Wireless, Driver=btusb, 12M |__ Port 8: Dev 5, If 1, Class=Wireless, Driver=btusb, 12M To understand the static.c generation , i generated build with and without this change(line num 664 to 667). When this change is added, change reflected in static.c is as below: STORAGE struct device _dev_usb2_port8 = { #if !DEVTREE_EARLY .ops = NULL, #endif .bus = &_dev_xhci_root_hub_links[0], .path = {.type=DEVICE_PATH_USB,{.usb={ .port_type = 2, .port_id = 7 }}}, .enabled = 1, -------------> enabled was 0 without the change .hidden = 0, .mandatory = 0, .on_mainboard = 1, .link_list = NULL, .sibling = &_dev_usb2_port9, .probe_list = _dev_usb2_port8_probe_list--> this probelist also got added if !DEVTREE_EARLY .chip_ops = &drivers_usb_acpi_ops, #endif .chip_info = &drivers_usb_acpi_info_9, .next=&_dev_usb2_port9, #if !DEVTREE_EARLY #if CONFIG(GENERATE_SMBIOS_TABLES) #endif #endif where ,below are the other details added: STORAGE struct fw_config _dev_usb2_port8_probe_list[] = { { .field_name = FW_CONFIG_FIELD_WIFI_CATEGORY_NAME, .option_name = FW_CONFIG_FIELD_WIFI_CATEGORY_OPTION_WIFI_7_NAME, .mask = FW_CONFIG_FIELD_WIFI_CATEGORY_MASK, .value = FW_CONFIG_FIELD_WIFI_CATEGORY_OPTION_WIFI_7_VALUE, }, { } }; STORAGE struct drivers_usb_acpi_config drivers_usb_acpi_info_9 = { .desc = "USB2 Bluetooth", .reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D4), .type = UPC_TYPE_INTERNAL, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/83076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I989cf6122f2555cc89f622e4ce5d21b574d0458e Gerrit-Change-Number: 83076 Gerrit-PatchSet: 8 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 24 Jun 2024 10:54:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[S] Change in coreboot[main]: mb/intel/adlrvp: Prefer include <soc/gpio.h> via <gpio.h>
by Elyes Haouas (Code Review) 24 Jun '24

24 Jun '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82822?usp=email ) Change subject: mb/intel/adlrvp: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/82822?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a469e567ba8413b6b14970f7902db8e80370d6d Gerrit-Change-Number: 82822 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024