coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: mb/purism/librem_cnl: Prefer include <soc/gpio.h> via <gpio.h>
by Jonathon Hall (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Elyes Haouas, Felix Singer. Jonathon Hall has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82871?usp=email ) Change subject: mb/purism/librem_cnl: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Commented on change 82872; we discussed this at the last leadership meeting and the consensus was that including soc/gpio.h from mainboard sources is OK, details in the comment there. -- To view, visit https://review.coreboot.org/c/coreboot/+/82871?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0be13ff1195aa1fc7b8810ac7a0758afec56e0b Gerrit-Change-Number: 82871 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 19 Jun 2024 17:46:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/purism/librem_skl: Prefer include <soc/gpio.h> via <gpio.h>
by Jonathon Hall (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Elyes Haouas, Felix Singer. Jonathon Hall has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82872?usp=email ) Change subject: mb/purism/librem_skl: Prefer include <soc/gpio.h> via <gpio.h> ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: @ehaouas@noos.fr, we discussed this at the last leadership meeting, consensus is that we don't want to change these inclusions across the board. Including soc/gpio.h from mainboards is OK. I don't think the style guide really meant to say that you must include gpio.h instead of soc/gpio.h; it's saying that don't need to include both. gpio.h has include-what-you-use annotations stating it exports soc/gpio.h, which is consistent with that. Either way, there was agreement that we could edit the style guide for clarity here, and including soc/gpio.h is fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/82872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4bb0f0b6fff2953ec9cc3a52704b04ccc8e8098 Gerrit-Change-Number: 82872 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 19 Jun 2024 17:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: documentation: Fix evaluation of reStructuredText
by Felix Held (Code Review) 19 Jun '24

19 Jun '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83117?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: documentation: Fix evaluation of reStructuredText ...................................................................... documentation: Fix evaluation of reStructuredText eval_rst isn't a valid directive. Use eval-rst instead. Also, add curly braces where necessary since the MyST parser requires them. Change-Id: I68337354e9bd4de4b2c29d4e42c3bb22337fbe06 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83117 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/getting_started/writing_documentation.md M Documentation/mainboard/hp/8560w.md M Documentation/mainboard/hp/pro_3500_series.md 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Nicholas Chin: Looks good to me, approved Angel Pons: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/getting_started/writing_documentation.md b/Documentation/getting_started/writing_documentation.md index 51ea531..b9c30b0 100644 --- a/Documentation/getting_started/writing_documentation.md +++ b/Documentation/getting_started/writing_documentation.md @@ -99,7 +99,7 @@ Under Sphinx markdown tables are not supported. Therefore you can use following code block to write tables in reStructuredText and embed them into the markdown: - ```eval_rst + ```{eval-rst} +------------+------------+-----------+ | Header 1 | Header 2 | Header 3 | +============+============+===========+ @@ -144,7 +144,7 @@ You can import CSV files and let sphinx automatically convert them to human readable tables, using the following reStructuredText snipped: - ```eval_rst + ```{eval-rst} .. csv-table:: :header: "Key", "Value" :file: keyvalues.csv diff --git a/Documentation/mainboard/hp/8560w.md b/Documentation/mainboard/hp/8560w.md index babd632..103d912 100644 --- a/Documentation/mainboard/hp/8560w.md +++ b/Documentation/mainboard/hp/8560w.md @@ -17,7 +17,7 @@ ![8560w_chip_location](8560w_flash.webp) -```eval_rst +```{eval-rst} +---------------------+------------+ | Type | Value | +=====================+============+ @@ -61,7 +61,7 @@ ## Technology -```eval_rst +```{eval-rst} +------------------+--------------------------------------------------+ | Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | +------------------+--------------------------------------------------+ diff --git a/Documentation/mainboard/hp/pro_3500_series.md b/Documentation/mainboard/hp/pro_3500_series.md index 241b567..881bf37 100644 --- a/Documentation/mainboard/hp/pro_3500_series.md +++ b/Documentation/mainboard/hp/pro_3500_series.md @@ -14,7 +14,7 @@ ## Flashing coreboot -```{eval_rst} +```{eval-rst} +---------------------+-------------------------+ | Type | Value | +=====================+=========================+ @@ -82,7 +82,7 @@ ## Technology -```{eval_rst} +```{eval-rst} +------------------+--------------------------------------------------+ | Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | +------------------+--------------------------------------------------+ -- To view, visit https://review.coreboot.org/c/coreboot/+/83117?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I68337354e9bd4de4b2c29d4e42c3bb22337fbe06 Gerrit-Change-Number: 83117 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: util: Break up spdx identifier text in scripts & makefiles
by Felix Held (Code Review) 19 Jun '24

19 Jun '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80585?usp=email ) Change subject: util: Break up spdx identifier text in scripts & makefiles ...................................................................... util: Break up spdx identifier text in scripts & makefiles The SPDX parsers can find the SPDX identifiers in the scripts and makefiles if they aren't broken up. This unnecessarily confuses things when we're doing license parsing. Change-Id: I215ed047397f342c912f1a969315fa184a124f6a Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80585 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com> --- M util/cbfstool/Makefile M util/chromeos/update_ec_headers.sh M util/lint/lint-000-license-headers 3 files changed, 25 insertions(+), 21 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Varshit Pandya: Looks good to me, approved diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index 8dde77b..5a33598 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -13,6 +13,7 @@ VBOOT_SOURCE ?= $(top)/3rdparty/vboot VBOOT_HOST_BUILD ?= $(abspath $(objutil)/vboot_lib) +SPDX_ID_STRING := SPDX-License-Identifier .PHONY: all all: cbfstool ifittool fmaptool rmodtool ifwitool cbfs-compression-tool elogtool cse_fpt cse_serger @@ -54,7 +55,7 @@ $(CC) -m32 -o linux_trampoline linux_trampoline.S -ffreestanding -nostdlib -nostdinc -Wl,--defsym=_start=0 $(OBJCOPY) -Obinary -j .data linux_trampoline trampoline echo "/* This file is automatically generated. Do not manually change */" > trampoline.c - echo "/* SPDX-License-Identifier: GPL-2.0-only */" >> trampoline.c + echo "/* $(SPDX_ID_STRING): GPL-2.0-only */" >> trampoline.c xxd -c 16 -i trampoline >> trampoline.c mv trampoline.c linux_trampoline.c rm linux_trampoline trampoline diff --git a/util/chromeos/update_ec_headers.sh b/util/chromeos/update_ec_headers.sh index c3ee13e..23b6418 100755 --- a/util/chromeos/update_ec_headers.sh +++ b/util/chromeos/update_ec_headers.sh @@ -12,6 +12,7 @@ scratch_file='' coreboot_top='' pname='' +SPDX_ID_STRING="SPDX-License-Identifier" cleanup() { @@ -41,7 +42,7 @@ update_copyright() { - local spdx='/* SPDX-License-Identifier: BSD-3-Clause */' + local spdx="/* ${SPDX_ID_STRING}: BSD-3-Clause */" local f=$1 # replace existing copyright with empty lines diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index f418a32..44657d2 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -84,13 +84,15 @@ #make a copy to check for the old style header later. headerlist=$(${FIND_FILES} $HEADER_DIRS | grep -E -v "($HEADER_EXCLUDED)") +LICENSE_ID_STRING="SPDX-License-Identifier" + #update headerlist by removing files that match the license string check_for_license() { if [ -n "$headerlist" ] && [ -z "$2" ]; then - headerlist="$(grep -iL "$1" $headerlist 2>/dev/null)" + headerlist="$(grep -iL "${LICENSE_ID_STRING}: $1" $headerlist 2>/dev/null)" elif [ -n "$headerlist" ]; then - p1list="$(grep -il "$1" $headerlist 2>/dev/null)" - p2list="$(grep -il "$2" $headerlist 2>/dev/null)" + p1list="$(grep -il "${LICENSE_ID_STRING}: $1" $headerlist 2>/dev/null)" + p2list="$(grep -il "${LICENSE_ID_STRING}: $2" $headerlist 2>/dev/null)" # Make list of files that were in both previous lists pbothlist="$(echo $p1list $p2list | tr ' ' "\n" | \ @@ -105,33 +107,33 @@ } #search the files for license headers -check_for_license 'SPDX-License-Identifier: Apache-2.0' -check_for_license 'SPDX-License-Identifier: BSD-2-Clause' -check_for_license 'SPDX-License-Identifier: BSD-3-Clause' -check_for_license 'SPDX-License-Identifier: GPL-2.0-only' -check_for_license 'SPDX-License-Identifier: GPL-2.0-or-later' -check_for_license 'SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note' -check_for_license 'SPDX-License-Identifier: GPL-3.0-only' -check_for_license 'SPDX-License-Identifier: GPL-3.0-only WITH GCC-exception-3.1' -check_for_license 'SPDX-License-Identifier: GPL-3.0-or-later' -check_for_license 'SPDX-License-Identifier: HPND' -check_for_license 'SPDX-License-Identifier: HPND-sell-variant' -check_for_license 'SPDX-License-Identifier: ISC' -check_for_license 'SPDX-License-Identifier: MIT' -check_for_license 'SPDX-License-Identifier: X11' +check_for_license 'Apache-2.0' +check_for_license 'BSD-2-Clause' +check_for_license 'BSD-3-Clause' +check_for_license 'GPL-2.0-only' +check_for_license 'GPL-2.0-or-later' +check_for_license 'GPL-2.0-only WITH Linux-syscall-note' +check_for_license 'GPL-3.0-only' +check_for_license 'GPL-3.0-only WITH GCC-exception-3.1' +check_for_license 'GPL-3.0-or-later' +check_for_license 'HPND' +check_for_license 'HPND-sell-variant' +check_for_license 'ISC' +check_for_license 'MIT' +check_for_license 'X11' # This is 4 clause ("with advertising") but the University of Berkeley # declared that 4th clause void, see # ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change # With this, BSD-4-Clause-UC becomes GPLv2 compatible, and so SPDX doesn't # differentiate between this license with or without advertising. -check_for_license 'SPDX-License-Identifier: BSD-4-Clause-UC' +check_for_license 'BSD-4-Clause-UC' # This is the Creative Commons Public Domain Dedication and Certification # for files that are already in the public domain. This includes files # that cannot be licensed such as blank files or files with no "creative" # content. -check_for_license 'SPDX-License-Identifier: CC-PDDC' +check_for_license 'CC-PDDC' for file in $headerlist; do # Verify the file actually exists -- To view, visit https://review.coreboot.org/c/coreboot/+/80585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I215ed047397f342c912f1a969315fa184a124f6a Gerrit-Change-Number: 80585 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
by Subrata Banik (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, V Sowmya. Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email ) Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/nivviks/fw_config.c: https://review.coreboot.org/c/coreboot/+/83077/comment/e7adedbb_d97fd7f8?us… : PS6, Line 103: PAD_CFG_GPO > Another case, i can think of now is , when there is any update for any wifi firmware, don't they prefer to reset it completely? if wifi fw update required to reset the controller then there should be power sequencing code existed in BIOS/ACPI because none of the kernel driver actually aware how to reset the controller w/o end details about platform. Better you check with kernel/driver folks, my recommendation is simple, lock the GPO unless there is a valid driver usage. There is no point of argue unless there are some data that says either we need or we don't need to configure those PINs being independent of AP FW. -- To view, visit https://review.coreboot.org/c/coreboot/+/83077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0584e91b5143c6df742961657d242c046409b3a Gerrit-Change-Number: 83077 Gerrit-PatchSet: 7 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jun 2024 17:31:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Poornima Tom <poornima.tom(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
by Poornima Tom (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, V Sowmya. Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email ) Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/nivviks/fw_config.c: https://review.coreboot.org/c/coreboot/+/83077/comment/eb483e8c_2a9c6919?us… : PS6, Line 103: PAD_CFG_GPO > If any such recent vulnerability has been reported recently, i agree that it is risky. […] Another case, i can think of now is , when there is any update for any wifi firmware, don't they prefer to reset it completely? -- To view, visit https://review.coreboot.org/c/coreboot/+/83077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0584e91b5143c6df742961657d242c046409b3a Gerrit-Change-Number: 83077 Gerrit-PatchSet: 7 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jun 2024 17:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Poornima Tom <poornima.tom(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
by Poornima Tom (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, V Sowmya. Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email ) Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/nivviks/fw_config.c: https://review.coreboot.org/c/coreboot/+/83077/comment/9f4419d5_fd658fbe?us… : PS6, Line 103: PAD_CFG_GPO > > Ideally, i think, locking of GPIO becomes relevant, when it is some thing like Write protect signa […] If any such recent vulnerability has been reported recently, i agree that it is risky. But, what about the regular use case in which user prefer to turn off wifi when not using it and turn it on later based on usage? Doesn't this need a reset for PERST0# ? Also, If we lock it, user will be forced to restart the system completely, inorder to reset PERST0# signal for wifi to turn on again right? May be we should involve kernel team also to clarify, on how do they actually prefer to turn on and turn off wifi here? -- To view, visit https://review.coreboot.org/c/coreboot/+/83077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0584e91b5143c6df742961657d242c046409b3a Gerrit-Change-Number: 83077 Gerrit-PatchSet: 7 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jun 2024 17:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Poornima Tom <poornima.tom(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: driver/intel/fsp2_0: Prevent error logs during S3 wakeup
by Varun Upadhyay (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Andrey Petrov, Krishna P Bhat D, Ronak Kanabar, Subrata Banik. Hello Andrey Petrov, Krishna P Bhat D, Ronak Kanabar, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83055?usp=email to look at the new patch set (#4). Change subject: driver/intel/fsp2_0: Prevent error logs during S3 wakeup ...................................................................... driver/intel/fsp2_0: Prevent error logs during S3 wakeup This patch adds the S3 wakeup check to prevent firmware error logging that occurred when the system resumed from the S3 state. BUG=b:348091236 TEST=Verified that no error logs appear during S3 resume on nivviks Change-Id: I13463b5409e248cf4843c9a887a47d73459972a3 Signed-off-by: Varun Upadhyay <varun.upadhyay(a)intel.com> --- M src/drivers/intel/fsp2_0/fsp_gop_blt.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/83055/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13463b5409e248cf4843c9a887a47d73459972a3 Gerrit-Change-Number: 83055 Gerrit-PatchSet: 4 Gerrit-Owner: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>

1 0

[S] Change in coreboot[main]: commonlib/bsd/lz4_wrapper.c: Fix misaligned access
by Arthur Heymans (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Angel Pons, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, Ron Minnich. Arthur Heymans has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email ) Change subject: commonlib/bsd/lz4_wrapper.c: Fix misaligned access ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/commonlib/bsd/lz4_wrapper.c: https://review.coreboot.org/c/coreboot/+/81910/comment/1cd1064e_d356330f?us… : PS5, Line 20: LZ4_readLE32 > I don't see a reference to this one? Nvm it's below -- To view, visit https://review.coreboot.org/c/coreboot/+/81910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add Gerrit-Change-Number: 81910 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 19 Jun 2024 15:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[S] Change in coreboot[main]: commonlib/bsd/lz4_wrapper.c: Fix misaligned access
by Arthur Heymans (Code Review) 19 Jun '24

19 Jun '24

Attention is currently required from: Angel Pons, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, Ron Minnich. Arthur Heymans has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email ) Change subject: commonlib/bsd/lz4_wrapper.c: Fix misaligned access ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81910/comment/9a76f645_72035f3c?us… : PS1, Line 18: The coreboot LZ4 decompression code does some misaligned access during : decompression > NB. I'd expect that inlining LZ4_readLE16() has a bigger effect. No the actual lz4c.c.inc is included below and the compiler is sufficiently smart to do that already. File src/commonlib/bsd/lz4_wrapper.c: https://review.coreboot.org/c/coreboot/+/81910/comment/7c7bd521_77838ec0?us… : PS5, Line 20: LZ4_readLE32 I don't see a reference to this one? -- To view, visit https://review.coreboot.org/c/coreboot/+/81910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add Gerrit-Change-Number: 81910 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 19 Jun 2024 15:50:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024