Attention is currently required from: Angel Pons, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 12
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 14:59:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82046?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/self_test/intel_cpu: Add self test submodule for Intel CPU
......................................................................
drivers/self_test/intel_cpu: Add self test submodule for Intel CPU
Add a self test submodule for Intel CPU. This module checks microcode
patch status on all the cores and logs an error if microcode patch has
not loaded on any of the cores.
BUG=b:233012780
TEST=Print self test result in the OS
Run the below command in the OS to get the self test logs:
$ cbmem -r 53545354 | hexdump -C
Sample output:
00000000 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
00001000
Change-Id: Ie2e40e60609d4b5f2f0ea6dca0f6b51987890877
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
---
A src/drivers/self_test/modules/intel_cpu/Kconfig
A src/drivers/self_test/modules/intel_cpu/Makefile.mk
A src/drivers/self_test/modules/intel_cpu/st_intel_cpu.c
M src/include/self_test_id.h
4 files changed, 75 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/82046/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82046?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie2e40e60609d4b5f2f0ea6dca0f6b51987890877
Gerrit-Change-Number: 82046
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82045?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/self_test: coreboot self test
......................................................................
drivers/self_test: coreboot self test
Add a self test infrastructure with below features -
- Modularity: New tests can be added easily as a module.
- Flexibility: Where tests can be executed at any stage.
- Where results can be dumped during payload or the OS.
BUG=b:233012780
TEST=Print self test result in the OS
Run the below command in the OS to get the self test logs:
$ cbmem -r 53545354 | hexdump -C
Sample output:
00000000 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
00001000
Change-Id: I8d7813d972167592b8dc9e9e7e9b0eb1f50c3da6
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
---
M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h
A src/drivers/self_test/Kconfig
A src/drivers/self_test/Makefile.mk
A src/drivers/self_test/modules/.gitignore
A src/drivers/self_test/self_test.c
A src/include/self_test.h
A src/include/self_test_id.h
7 files changed, 279 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/82045/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82045?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d7813d972167592b8dc9e9e7e9b0eb1f50c3da6
Gerrit-Change-Number: 82045
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 12:
(2 comments)
File src/arch/arm64/include/armv8/arch/cache.h:
https://review.coreboot.org/c/coreboot/+/79106/comment/5a9e1aa7_d593ea7c :
PS11, Line 42: cache_type
> add variable name
Done
https://review.coreboot.org/c/coreboot/+/79106/comment/ba81c127_79797a81 :
PS11, Line 42: struct cache_info *info);
> line limit
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 12
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 14:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Paul Menzel.
Hello Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79106?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: arch/arm64: Extend cache helper functions
......................................................................
arch/arm64: Extend cache helper functions
This patch extends the cpu_get_cache_info function, so that
additional information like size of cache lines can be retrieved.
Patch was tested against the qemu-sbsa mainboard.
Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com>
---
M src/arch/arm64/armv8/cache.c
M src/arch/arm64/include/armv8/arch/cache.h
2 files changed, 27 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/79106/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 12
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82045?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/self_test: coreboot self test
......................................................................
drivers/self_test: coreboot self test
Add a self test infrastructure with below features -
- Modularity: New tests can be added easily as a module.
- Flexibility: Where tests can be executed at any stage.
- Where results can be dumped during payload or the OS.
BUG=b:233012780
TEST=Print self test result in the OS
Run the below command in the OS to get the self test logs:
$ cbmem -r 53545354 | hexdump -C
Sample output:
00000000 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
00001000
Change-Id: I8d7813d972167592b8dc9e9e7e9b0eb1f50c3da6
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
---
M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h
A src/drivers/self_test/Kconfig
A src/drivers/self_test/Makefile.mk
A src/drivers/self_test/modules/.gitignore
A src/drivers/self_test/self_test.c
A src/include/self_test.h
A src/include/self_test_id.h
7 files changed, 278 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/82045/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82045?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d7813d972167592b8dc9e9e7e9b0eb1f50c3da6
Gerrit-Change-Number: 82045
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 11:
(2 comments)
File src/arch/arm64/include/armv8/arch/cache.h:
https://review.coreboot.org/c/coreboot/+/79106/comment/b9fcfead_4edd1473 :
PS11, Line 42: cache_type
add variable name
https://review.coreboot.org/c/coreboot/+/79106/comment/16d24728_9d3346e0 :
PS11, Line 42: struct cache_info *info);
line limit
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 11
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 14:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 11:
(1 comment)
File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/c/coreboot/+/79106/comment/89ab28a3_68aa9782 :
PS8, Line 63: /* [2:0] - Indicates (Log2(Number of bytes in cache line) - 4) */
: uint8_t line_length = 1 << ((ccsidr_el1 & 0x7) + 4);
: /* (Number of sets in cache) - 1 */
: uint64_t num_sets = get_ccsidr_el1_numsets(ccsidr_el1) + 1;
: /* (Associativity of cache) - 1 */
: *assoc = get_ccsidr_el1_assoc(ccsidr_el1) + 1;
> Can you return the comments? The helpers we use don't extract human readable data from raw registers […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 11
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 14:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Paul Menzel.
Hello Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79106?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Code-Review+2 by Benjamin Doron
Change subject: arch/arm64: Extend cache helper functions
......................................................................
arch/arm64: Extend cache helper functions
This patch extends the cpu_get_cache_info function, so that
additional information like size of cache lines can be retrieved.
Patch was tested against the qemu-sbsa mainboard.
Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com>
---
M src/arch/arm64/armv8/cache.c
M src/arch/arm64/include/armv8/arch/cache.h
2 files changed, 25 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/79106/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 11
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-MessageType: newpatchset