Attention is currently required from: Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82040?usp=email )
Change subject: libpayload: Save EAX and EBX for multiboot payloads
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82040/comment/6fc10424_194c5adb :
PS1, Line 7: for
only for?
https://review.coreboot.org/c/coreboot/+/82040/comment/11eb15ac_85efd45c :
PS1, Line 12:
Why are they removed for non-multiboot things?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82040?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98c2cd00206ee48eb0fc67edd9533032bcf3e5eb
Gerrit-Change-Number: 82040
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 10:25:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Haikun Zhou, Xuxin Xiong, Yang Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82054?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/mipi: Add support for STA_ER88576 panel
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82054/comment/446731bb_9bff7dc8 :
PS5, Line 9: Add STA panel STA_ER88577 serializable data to CBFS.
Please mention the datasheet name and revision, and how you wrote the initialization.
https://review.coreboot.org/c/coreboot/+/82054/comment/91be843c_ba5cc694 :
PS5, Line 12: include
includes
File src/drivers/mipi/panel-STA_ER88577.c:
https://review.coreboot.org/c/coreboot/+/82054/comment/154be5db_ad05bf74 :
PS5, Line 57: PANEL_DELAY(120),
That is quite long.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82054?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7
Gerrit-Change-Number: 82054
Gerrit-PatchSet: 5
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 10:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yang Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82055?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/corsola: Add STA_ER88577 MIPI panel for Wugtrio
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82055/comment/807155dc_025d92c1 :
PS3, Line 7: for Wugtrio
Add it to the prefix?
https://review.coreboot.org/c/coreboot/+/82055/comment/cd33d2c0_7e853299 :
PS3, Line 9: Add STA_ER88577 MIPI panel for Wugtrio.
Please mention the datasheet name and revision.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I279d431d80ca0770540d88e213d4aeafe77038ce
Gerrit-Change-Number: 82055
Gerrit-PatchSet: 3
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 10:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yang Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82055?usp=email )
Change subject: mb/google/corsola: Add STA_ER88577 MIPI panel for Wugtrio
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I279d431d80ca0770540d88e213d4aeafe77038ce
Gerrit-Change-Number: 82055
Gerrit-PatchSet: 3
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 09:33:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Haikun Zhou, Xuxin Xiong, Yang Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82054?usp=email )
Change subject: drivers/mipi: Add support for STA_ER88576 panel
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82054?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7
Gerrit-Change-Number: 82054
Gerrit-PatchSet: 5
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 09:32:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82040?usp=email )
Change subject: libpayload: Save EAX and EBX for multiboot payloads
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File payloads/libpayload/arch/x86/main.c:
https://review.coreboot.org/c/coreboot/+/82040/comment/5726fad9_7e122864 :
PS1, Line 33: #if CONFIG(LP_MULTIBOOT)
: unsigned long loader_eax; /**< The value of EAX passed from the loader */
: unsigned long loader_ebx; /**< The value of EBX passed from the loader */
: #endif
As those are not referenced in this file, maybe move them to multiboot.c instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82040?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98c2cd00206ee48eb0fc67edd9533032bcf3e5eb
Gerrit-Change-Number: 82040
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 08:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment