Attention is currently required from: Elyes Haouas, Jianeng Ceng, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 23:
(1 comment)
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/d0e89552_8eef9634 :
PS23, Line 42: 10EC5650
any reason why are we hard coding this ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 23
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 20 Apr 2024 04:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81671?usp=email )
Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6
Gerrit-Change-Number: 81671
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 01:53:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Felix Singer.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
> Please rebase on the latest main branch. There was an issue before which is fixed by now.
Done. Thanks for your review!
Patchset:
PS3:
Done. Thanks for your review!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 00:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Daniel Schaefer, Kieran Levin, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81978?usp=email )
Change subject: mb/framework: Initial push of azalea (Framework 13 AMD 7040)
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/framework/azalea/Kconfig:
https://review.coreboot.org/c/coreboot/+/81978/comment/3748646c_93a0f806 :
PS5, Line 6: if BOARD_FRAMEWORK_AZALEA
Add a blank line above (as in the abandoned CB:81992)
https://review.coreboot.org/c/coreboot/+/81978/comment/ac5c3f6e_e46753ca :
PS5, Line 16: endif
Nit: Add a blank line above
File src/mainboard/framework/azalea/Kconfig.name:
PS5:
Missing SPDX header
File src/mainboard/framework/azalea/Makefile.inc:
PS5:
Should be Makefile.mk
--
To view, visit https://review.coreboot.org/c/coreboot/+/81978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
Gerrit-Change-Number: 81978
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Reviewer: Kieran Levin <ktl(a)frame.work>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Attention: Kieran Levin <ktl(a)frame.work>
Gerrit-Comment-Date: Sat, 20 Apr 2024 00:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Naveen Iyer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Please rebase on the latest main branch. There was an issue before which is fixed by now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 2
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 00:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Felix Singer.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82001/comment/b0059fb7_74b3b0d2 :
PS1, Line 6:
> > `A patch subject line should describe the change not the tool that found it` […]
Thanks for your review. I was following what was documented in the tutorial:
https://doc.coreboot.org/tutorial/part2.html#step-4a-use-the-command-line-t…
Made the change you suggested.
https://review.coreboot.org/c/coreboot/+/82001/comment/54dd5752_038cfc79 :
PS1, Line 7: src/
> We don't add src when we do changes to files from there. Remove.
Thanks for your review. Done.
Patchset:
PS1:
Thanks for your review. Implemented your suggestions. Please review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 23:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Naveen Iyer.
Hello Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82001?usp=email
to look at the new patch set (#2).
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
security/tpm/tspi/crtm.c: Fix space required before open brace error
Fix checkpatch error.
Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
---
M src/security/tpm/tspi/crtm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/82001/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 2
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Naveen Iyer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: src/security/tpm/tspi/crtm.c: Fix checkpatch error
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82001/comment/789a5670_8006bb7a :
PS1, Line 6:
> `A patch subject line should describe the change not the tool that found it`
Swap the commit summary with the commit title.
https://review.coreboot.org/c/coreboot/+/82001/comment/f67ca455_7bb8be38 :
PS1, Line 7: src/
We don't add src when we do changes to files from there. Remove.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 23:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Naveen Iyer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: src/security/tpm/tspi/crtm.c: Fix checkpatch error
......................................................................
src/security/tpm/tspi/crtm.c: Fix checkpatch error
Fix space required before open brace error.
Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
---
M src/security/tpm/tspi/crtm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/82001/1
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c
index 3c2760a..621d7cd 100644
--- a/src/security/tpm/tspi/crtm.c
+++ b/src/security/tpm/tspi/crtm.c
@@ -67,7 +67,7 @@
if (rc)
return rc;
}
- } else if (CONFIG(BOOTBLOCK_IN_CBFS)){
+ } else if (CONFIG(BOOTBLOCK_IN_CBFS)) {
/* Mapping measures the file. We know we can safely map here because
bootblock-as-a-file is only used on x86, where we don't need cache to map. */
enum cbfs_type type = CBFS_TYPE_BOOTBLOCK;
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Iyer
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 4:
(2 comments)
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/28a88b6c_a5bae77d :
PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) {
> > > > [Subrata] I don't under why all of sudden the "multiple entry point approach" considered criti […]
Acknowledged
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/2223ec5d_66f49d3d :
PS3, Line 47: is_payload_64_bit_enabled
> > Handle the case when in ENV_X86_32 and is_payload_64_bit_enabled() returns true. […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 19 Apr 2024 22:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment