coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3667 discussions

[XS] Change in coreboot[main]: mb/google/oak: Don't build the ChromeEC codebase by default
by Yidi Lin (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Hung-Te Lin, Martin L Roth. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81023?usp=email ) Change subject: mb/google/oak: Don't build the ChromeEC codebase by default ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > Do we know why Oak needs to build ChromeEC? Can we just replace that with something equivalent that […] For Oak/Elm/Hana, the ec/pd images are built by coreboot. `chromeos-ec` is not even in `chromeos-bootimage`'s build dependent list. (I check this by `emerge-elm -pv chromeos-bootimage`) I got build failure when trying `emerge-elm chromeos-ec`. -- To view, visit https://review.coreboot.org/c/coreboot/+/81023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd4fe45e52dbdd1c8dccf0d2c09d5cf6d61aa839 Gerrit-Change-Number: 81023 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 05:38:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/Kconfig: Deduplicate SSE2 selection
by Elyes Haouas (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Felix Singer, Jérémy Compostella. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81021?usp=email ) Change subject: arch/x86/Kconfig: Deduplicate SSE2 selection ...................................................................... Patch Set 2: (1 comment) File src/arch/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/81021/comment/b08af24b_250e94e0 : PS1, Line 45: select SSE2 > Missed that if VBOOT_STARTS_BEFORE_BOOTBLOCK ? -- To view, visit https://review.coreboot.org/c/coreboot/+/81021?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78c9bb599303d3a249a2434dd38b7629e3f1ca86 Gerrit-Change-Number: 81021 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 05:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/Kconfig: Deduplicate SSE2 selection
by Elyes Haouas (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Elyes Haouas, Jérémy Compostella. Hello Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81021?usp=email to look at the new patch set (#2). Change subject: arch/x86/Kconfig: Deduplicate SSE2 selection ...................................................................... arch/x86/Kconfig: Deduplicate SSE2 selection Change-Id: I78c9bb599303d3a249a2434dd38b7629e3f1ca86 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/81021/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81021?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78c9bb599303d3a249a2434dd38b7629e3f1ca86 Gerrit-Change-Number: 81021 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/brya: Create yavista variant
by Henry Sun (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Derek Huang, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rasheed Hsueh, Subrata Banik. Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80342?usp=email ) Change subject: mb/google/brya: Create yavista variant ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: > Nissa variants are under Brya. Oh, I see, sorry I forgot that. LGTM then. -- To view, visit https://review.coreboot.org/c/coreboot/+/80342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6fa464a4dcd9551a42e8746e64c724b3582dbe02 Gerrit-Change-Number: 80342 Gerrit-PatchSet: 5 Gerrit-Owner: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ryan Lin <ryan.lin(a)intel.corp-partner.google.com> Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 04 Mar 2024 05:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update chromeec submodule to upstream main
by Elyes Haouas (Code Review) 04 Mar '24

04 Mar '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81019?usp=email ) Change subject: Update chromeec submodule to upstream main ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba329d9dee4835b9c626bc6fda77e6280211f342 Gerrit-Change-Number: 81019 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: [for test] Test build google/oak
by Elyes Haouas (Code Review) 04 Mar '24

04 Mar '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81017?usp=email ) Change subject: [for test] Test build google/oak ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81017?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea8f183d498431f5affd7d5ff0a4d61d28a80c93 Gerrit-Change-Number: 81017 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: src/acpi: Modify ACPI revision
by minyu li (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Cliff Huang, Felix Singer, Lance Zhao, Tim Wawrzynczak. minyu li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80781?usp=email ) Change subject: src/acpi: Modify ACPI revision ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80781/comment/ac869517_ff4abfe8 : PS1, Line 9: Modify ACPI revision from 6.0 to 6.4 > Mention a reason. […] The ACPI PROCESSOR_OP has been deprecated in ACPI 6.0 and dropped in ACPI 6.4. As a replacement, DEVICE_OP with the special HID ACPI0007 should be used instead. This special HID was introduced in version 3 of the ACPI spec. So upgrade ACPI minor version to 4 -- To view, visit https://review.coreboot.org/c/coreboot/+/80781?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b978f07b296e55e67d4de5e981bd48fd28eb03 Gerrit-Change-Number: 80781 Gerrit-PatchSet: 1 Gerrit-Owner: minyu li <li.minyu(a)h3c.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 03:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: [test only] upgrade to gcc-14-20240303
by Felix Singer (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber, Zebreus. Felix Singer has uploaded a new patch set (#9) to the change originally created by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/80607?usp=email ) The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: [test only] upgrade to gcc-14-20240303 ...................................................................... [test only] upgrade to gcc-14-20240303 Change-Id: Ib96709309e7c71b76a51d3b8600be793312d6a8f Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-14-20240303_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-14-20240303_gnat.patch R util/crossgcc/patches/gcc-14-20240303_libcpp.patch R util/crossgcc/patches/gcc-14-20240303_libgcc.patch R util/crossgcc/patches/gcc-14-20240303_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-14-20240303_rv32iafc.patch D util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-14-20240303.tar.xz.cksum 9 files changed, 11 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/80607/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/80607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib96709309e7c71b76a51d3b8600be793312d6a8f Gerrit-Change-Number: 80607 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/oak: Don't build the ChromeEC codebase by default
by Yu-Ping Wu (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Martin L Roth, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81023?usp=email ) Change subject: mb/google/oak: Don't build the ChromeEC codebase by default ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81023/comment/7779828c_ad50026b : PS2, Line 9: only boards Would be nice to also clean up the ineffective references in foster and rambi. -- To view, visit https://review.coreboot.org/c/coreboot/+/81023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd4fe45e52dbdd1c8dccf0d2c09d5cf6d61aa839 Gerrit-Change-Number: 81023 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 03:15:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update chromeec submodule to upstream main
by Felix Singer (Code Review) 04 Mar '24

04 Mar '24

Attention is currently required from: Elyes Haouas, Hung-Te Lin, Yidi Lin. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81019?usp=email ) Change subject: Update chromeec submodule to upstream main ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See CB:81024 -- To view, visit https://review.coreboot.org/c/coreboot/+/81019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba329d9dee4835b9c626bc6fda77e6280211f342 Gerrit-Change-Number: 81019 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 04 Mar 2024 03:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024