Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80554?usp=email )
Change subject: soc/intel/common/block/sata: Fix scope for SATA ACPI device
......................................................................
soc/intel/common/block/sata: Fix scope for SATA ACPI device
acpi_device_path() includes the device name, so we end up with:
Scope (\_SB.PCI0.SATA) {
Device (SATA) {
...
Fix this by using acpi_device_scope() instead.
TEST=build/boot purism librem_cml (Mini v2), dump ACPI and verify
SATA device scope correct.
Change-Id: Ibbc8890d93b22f0ecba4b3a9b0531994574b3d55
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/common/block/sata/sata.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/80554/1
diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c
index 96c33ef..96b7390 100644
--- a/src/soc/intel/common/block/sata/sata.c
+++ b/src/soc/intel/common/block/sata/sata.c
@@ -9,7 +9,7 @@
static void sata_acpi_fill_ssdt(const struct device *dev)
{
- const char *scope = acpi_device_path(dev);
+ const char *scope = acpi_device_scope(dev);
if (!scope)
return;
--
To view, visit https://review.coreboot.org/c/coreboot/+/80554?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibbc8890d93b22f0ecba4b3a9b0531994574b3d55
Gerrit-Change-Number: 80554
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Matt DeVillier, Sean Rhodes, Subrata Banik.
Hello Sean Rhodes, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80553?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: soc/intel/common/block/systemagent: Add ACPI stub for TCPU device
......................................................................
soc/intel/common/block/systemagent: Add ACPI stub for TCPU device
Add an ACPI stub containing the TCPU device in proper scope, along with
the device status, on boards not using the DPTF driver, so that there
exists an ACPI device to be referenced from the PEPD LPI constraint
list.
Adding the stub fixes an AE_NOT_FOUND ACPI error under Linux for
_SB.PCI0.TCPU on boards with the SA thermal device enabled but which do
not use the Intel DPTF driver.
TEST=build/boot Linux,Win11 on purism/librem_cnl (Librem Mini v2).
Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/common/block/systemagent/systemagent.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/80553/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newpatchset
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80553?usp=email )
Change subject: soc/intel/common/block/systemagent: Add ACPI stub for TCPU device
......................................................................
soc/intel/common/block/systemagent: Add ACPI stub for TCPU device
Add an ACPI stub containing the TCPU device in proper scope, along with
the device status, on boards not using the DPTF driver, so that there
exists an ACPI device to be referenced from the PEPD LPI constraint
list.
Adding the stub fixes an AE_NOT_FOUND ACPI error under Linux for
_SB.PCI0.TCPU on boards with the SA thermal device enabled but which do
not use the Intel DPTF driver.
TEST=build/boot Linux,Win11 on purism/librem_cnl (Librem Mini v2).
Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/common/block/systemagent/systemagent.c
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/80553/1
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c
index bcae6a6..0e1d8fe 100644
--- a/src/soc/intel/common/block/systemagent/systemagent.c
+++ b/src/soc/intel/common/block/systemagent/systemagent.c
@@ -402,6 +402,25 @@
return (uint64_t)size_field * MiB;
}
+static void sa_acpi_fill_ssdt(const struct device *dev)
+{
+ const char *scope = acpi_device_path(dev);
+
+ if (!scope)
+ return;
+
+ /* Skip if DPTF driver in use */
+ if (CONFIG(DRIVERS_INTEL_DPTF))
+ return;
+
+ acpigen_write_scope(scope);
+ acpigen_write_device(soc_acpi_name(dev));
+ acpigen_write_ADR_pci_device(dev);
+ acpigen_write_STA(acpi_device_status(dev));
+ acpigen_pop_len(); /* Device */
+ acpigen_pop_len(); /* Scope */
+}
+
struct device_operations systemagent_ops = {
.read_resources = systemagent_read_resources,
.set_resources = pci_dev_set_resources,
@@ -410,6 +429,7 @@
.ops_pci = &pci_dev_ops_pci,
#if CONFIG(HAVE_ACPI_TABLES)
.write_acpi_tables = sa_write_acpi_tables,
+ .acpi_fill_ssdt = sa_acpi_fill_ssdt,
#endif
};
--
To view, visit https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Sean Rhodes.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80462?usp=email )
Change subject: mb/starlabs/starbook/{kbl,cml}: Remove libgfxinit code
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
No objection, but libgfxinit does work with GRUB. I used it with textmode so far, since graphical bootloaders aren't a thing for me. However, there are other bootloaders other than GRUB as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80462?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86af51f07f29971070bdccc3a589e807425cb83a
Gerrit-Change-Number: 80462
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 15 Feb 2024 20:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80552?usp=email )
Change subject: .gitmodules: Use https to fetch modules
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
That makes the mirrored repositories on e.g. GitHub quite useless for the standard users, since most people probably don't know how they are hooked up.
What's the reason for this change?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80552?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4f95c70a7f194d1073dc561c9f33dcc108060cc
Gerrit-Change-Number: 80552
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 20:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79980?usp=email )
Change subject: device/device_const: add pcidev_path_on_segbus
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/79980?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibbbee9966abc997ded6389e72912e621c1f0bdbf
Gerrit-Change-Number: 79980
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79874?usp=email )
Change subject: soc/intel/common/tcss: Rename tcss_mux_init to disconnect_tcss_devices
......................................................................
soc/intel/common/tcss: Rename tcss_mux_init to disconnect_tcss_devices
Rename tcss_mux_init to disconnect_tcss_devices to make it clear
what this function is doing, as it doesn't initialise anything.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I5e43f0cca9d49bc30fc189663490a306efd71584
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79874
Reviewed-by: Kapil Porwal <kapilporwal(a)google.com>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/common/block/tcss/tcss.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kapil Porwal: Looks good to me, approved
Subrata Banik: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c
index 974aeb6..8080c25 100644
--- a/src/soc/intel/common/block/tcss/tcss.c
+++ b/src/soc/intel/common/block/tcss/tcss.c
@@ -269,7 +269,7 @@
return 0;
}
-static void tcss_init_mux(int port, const struct tcss_port_map *port_map)
+static void disconnect_tcss_devices(int port, const struct tcss_port_map *port_map)
{
int ret;
@@ -447,7 +447,7 @@
if (CONFIG(TCSS_HAS_USBC_OPS))
for (i = 0; i < num_ports; i++)
- tcss_init_mux(i, &port_map[i]);
+ disconnect_tcss_devices(i, &port_map[i]);
/* This should be performed before alternate modes are entered */
if (tcss_ops.configure_aux_bias_pads)
--
To view, visit https://review.coreboot.org/c/coreboot/+/79874?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e43f0cca9d49bc30fc189663490a306efd71584
Gerrit-Change-Number: 79874
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Paul Menzel, Sean Rhodes.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79874?usp=email )
Change subject: soc/intel/common/tcss: Rename tcss_mux_init to disconnect_tcss_devices
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79874?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e43f0cca9d49bc30fc189663490a306efd71584
Gerrit-Change-Number: 79874
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 15 Feb 2024 19:42:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Michał Żygowski.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80455?usp=email )
Change subject: drivers/pc80/tpm: Disable device if TPM not present
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/80455/comment/dd8040d5_52cb3c27 :
PS2, Line 895:
unnecessary extra line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80455?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05972ad74a36abaafa2f17a16f09710550a3a3f3
Gerrit-Change-Number: 80455
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 19:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Sean Rhodes.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80179?usp=email )
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 15 Feb 2024 19:31:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment