coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: acpi/acpi.c: Move MADT lapic addr to APIC code
by Lean Sheng Tan (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Lance Zhao, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email ) Change subject: acpi/acpi.c: Move MADT lapic addr to APIC code ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Gerrit-Change-Number: 76070 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 23:59:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi.c: Fill in >4G FADT entries correctly
by Lean Sheng Tan (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Kyösti Mälkki, Lance Zhao, Nico Huber, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76179?usp=email ) Change subject: acpi.c: Fill in >4G FADT entries correctly ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84ab0068e8409a5e525ddc781347087680d80640 Gerrit-Change-Number: 76179 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 23:56:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi.c: Guard FACS generation
by Lean Sheng Tan (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Felix Singer, Kyösti Mälkki, Lance Zhao, Nico Huber, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76178?usp=email ) Change subject: acpi.c: Guard FACS generation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76178?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a1f36616e7f6adb021625e62e0fdf81864c7ac3 Gerrit-Change-Number: 76178 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 23:55:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: libpayload/libcbfs: Support file type in unverified_area APIs
by Julius Werner (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Simon Glass, Simon Glass, Subrata Banik. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73150?usp=email ) Change subject: libpayload/libcbfs: Support file type in unverified_area APIs ...................................................................... Patch Set 5: (1 comment) File payloads/libpayload/include/cbfs.h: https://review.coreboot.org/c/coreboot/+/73150/comment/d5fd7f76_ef69e6d3 : PS4, Line 27: static inline void *cbfs_unverified_area_type_map(const char *area, const char *name, > OK, so just drop all the code in payloads/ ? […] Yes, please drop everything in payloads/. You can just add unit tests for the coreboot version in the toplevel tests/ directory. A lot of stuff is duplicated between coreboot and libpayload for historical and licensing reasons. We've been trying to cut back a bit on it in recent years but there's definitely more way to go. In the case of CBFS APIs a bunch of things are actually different between the versions (e.g. backend for boot device access, FMAP APIs, lack of direct mapping), there are probably still some more things that could be unified but it's not like the whole file is a straight copy. -- To view, visit https://review.coreboot.org/c/coreboot/+/73150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I286addab7c435a47e5d22161be84e9fc559de4b9 Gerrit-Change-Number: 73150 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 23:27:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76: Enable C10 reporting on systems using eSPI
by Tim Crawford (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jeremy Soller. Hello Jeremy Soller, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76910?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/system76: Enable C10 reporting on systems using eSPI ...................................................................... mb/system76: Enable C10 reporting on systems using eSPI Report CPU C10 state over eSPI so that the EC can use Virtual Wires to detect if PECI can be used. Change-Id: I301361f35caee8ba1c3fd9227219603897add92b Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/ramstage.c M src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c M src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c M src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c 4 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/76910/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I301361f35caee8ba1c3fd9227219603897add92b Gerrit-Change-Number: 76910 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/ovis: Use and configure RT8168 driver
by YH Lin (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Stefan Reinauer, Subrata Banik, Tarun Tuli. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76872?usp=email ) Change subject: mb/google/rex/variants/ovis: Use and configure RT8168 driver ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Verified on Ovis. -- To view, visit https://review.coreboot.org/c/coreboot/+/76872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699e52e25f851de325f96ef885e04d15ca64badd Gerrit-Change-Number: 76872 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 22:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/ovis: Use and configure RT8168 driver
by YH Lin (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Stefan Reinauer, Subrata Banik, Tarun Tuli. YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76872?usp=email ) Change subject: mb/google/rex/variants/ovis: Use and configure RT8168 driver ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699e52e25f851de325f96ef885e04d15ca64badd Gerrit-Change-Number: 76872 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 22:19:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76: Enable C10 reporting on systems using eSPI
by Tim Crawford (Code Review) 01 Aug '23

01 Aug '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76910?usp=email ) Change subject: mb/system76: Enable C10 reporting on systems using eSPI ...................................................................... mb/system76: Enable C10 reporting on systems using eSPI Report CPU C10 state over eSPI so that the EC can use Virtual Wires to detect if PECI can be used. Change-Id: I301361f35caee8ba1c3fd9227219603897add92b Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/ramstage.c M src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c M src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c M src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c 4 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/76910/1 diff --git a/src/mainboard/system76/adl/ramstage.c b/src/mainboard/system76/adl/ramstage.c index c767f2d..aa9a1b7 100644 --- a/src/mainboard/system76/adl/ramstage.c +++ b/src/mainboard/system76/adl/ramstage.c @@ -17,6 +17,9 @@ params->SataPortDevSlpPinMux[1] = 0x5967400d; // GPP_H13 params->SataPortsSolidStateDrive[1] = 1; + + // Enable reporting CPU C10 state over eSPI + params->PchEspiHostC10ReportEnable = 1; } static void mainboard_init(void *chip_info) diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c index 9d98563..b4106df 100644 --- a/src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c @@ -18,4 +18,7 @@ // Remap PEG2 as PEG1 params->CpuPcieRpFunctionSwap = 1; + + // Enable reporting CPU C10 state over ESPI + params->PchEspiHostC10ReportEnable = 1; } diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c index 0f83461..1623225 100644 --- a/src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c @@ -15,4 +15,7 @@ params->CpuPcieRpAdvancedErrorReporting[1] = 0; params->CpuPcieRpLtrEnable[1] = 1; params->CpuPcieRpPtmEnabled[1] = 0; + + // Enable reporting CPU C10 state over ESPI + params->PchEspiHostC10ReportEnable = 1; } diff --git a/src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c b/src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c index 72ad3fc..a4d4b40 100644 --- a/src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c +++ b/src/mainboard/system76/tgl-h/variants/oryp8/ramstage.c @@ -21,4 +21,7 @@ // Low latency legacy I/O params->PchLegacyIoLowLatency = 1; + + // Enable reporting CPU C10 state over ESPI + params->PchEspiHostC10ReportEnable = 1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/76910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I301361f35caee8ba1c3fd9227219603897add92b Gerrit-Change-Number: 76910 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/rex: Create karis4es variant
by Eran Mitrani (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, YH Lin. Hello Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, YH Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76761?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by YH Lin, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/google/rex: Create karis4es variant ...................................................................... mb/google/rex: Create karis4es variant This patch creates a new variant karis4es. The new variant will support only ESx samples. The existing karis variant will support the QS samples. BUG=b:293326312 TEST=WIP, Not tested yet Change-Id: I854fee7206528a235f027ff8ec98593a02be4806 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/Kconfig.name 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/76761/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I854fee7206528a235f027ff8ec98593a02be4806 Gerrit-Change-Number: 76761 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: libpayload/libcbfs: Support file type in unverified_area APIs
by Simon Glass (Code Review) 01 Aug '23

01 Aug '23

Attention is currently required from: Jakub Czapiga, Julius Werner, Simon Glass, Subrata Banik. Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73150?usp=email ) Change subject: libpayload/libcbfs: Support file type in unverified_area APIs ...................................................................... Patch Set 5: (1 comment) File payloads/libpayload/include/cbfs.h: https://review.coreboot.org/c/coreboot/+/73150/comment/9ffd69aa_ba25adb6 : PS4, Line 27: static inline void *cbfs_unverified_area_type_map(const char *area, const char *name, > I meant we shouldn't add any of this to libpayload. […] OK, so just drop all the code in payloads/ ? Is it still possible to add a test? Why is the code duplicated in two places? -- To view, visit https://review.coreboot.org/c/coreboot/+/73150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I286addab7c435a47e5d22161be84e9fc559de4b9 Gerrit-Change-Number: 73150 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Aug 2023 21:55:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023