coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add DPTF parameters
by John Su (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, Rex Chou, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Van Chen. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76712?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add DPTF parameters ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d9e1ad2e2fa98757d76578956101a482073885e Gerrit-Change-Number: 76712 Gerrit-PatchSet: 7 Gerrit-Owner: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Store CSE RW FW version during cse_fw_sync
by Dinesh Gehlot (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Kapil Porwal. Hello Kapil Porwal, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76395?usp=email to look at the new patch set (#10). Change subject: src: Store CSE RW FW version during cse_fw_sync ...................................................................... src: Store CSE RW FW version during cse_fw_sync The current way to store CSE versions requires obtaining the version from CSE, which takes 7 to 19 milliseconds. This patch stores the CSE version while the CSE firmware sync, so it does not need to be retrieved again. BUG=b:285405031 TEST=Build and boot verified on rex. Change-Id: If95ce7e1584aae6be3c431f07f8d8e5001e7854a Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/drivers/intel/ish/ish.c M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_lite.c 5 files changed, 25 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/76395/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/76395?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95ce7e1584aae6be3c431f07f8d8e5001e7854a Gerrit-Change-Number: 76395 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Dinesh Gehlot (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Kapil Porwal, Lean Sheng Tan, Subrata Banik, Werner Zeh. Hello Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Subrata Banik, Werner Zeh, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76393?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... src: Implement framework for PRERAM VSD store This patch implements a framework that stores Vendor Specific Data (VSD) until CBMEM is initialized. It also copies the VSD back to its original CBMEM once it is initialized. BUG=b:285405031 TEST=Build and boot verified on rex. Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h A src/include/cbmem_vsd.h M src/lib/Makefile.inc A src/lib/cbmem_vsd.c 4 files changed, 79 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/76393/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 13 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add DPTF parameters
by Van Chen (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, John Su, Rex Chou, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli. Van Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76712?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add DPTF parameters ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/76712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d9e1ad2e2fa98757d76578956101a482073885e Gerrit-Change-Number: 76712 Gerrit-PatchSet: 7 Gerrit-Owner: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:21:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add wifi sar table
by Jamie Chen (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, Sumeet R Pawnikar, Tarun Tuli. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76576?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add wifi sar table ...................................................................... Patch Set 14: (3 comments) Patchset: PS11: > Done Done File src/mainboard/google/brya/Kconfig.name: https://review.coreboot.org/c/coreboot/+/76576/comment/7f5f62f5_2fbad933 : PS12, Line 399: <<<<<<< PATCH SET (886fd9 mb/google/nissa/var/craaskov: Add wifi sar table) > Done Done File src/mainboard/google/brya/variants/craaskov/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76576/comment/27cde9de_a3e24c67 : PS12, Line 5: > Done Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21f674b6749e125bf76a196902c994bfac15e65 Gerrit-Change-Number: 76576 Gerrit-PatchSet: 14 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add wifi sar table
by Eric Lai (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, Jamie Chen, Sumeet R Pawnikar, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76576?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add wifi sar table ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21f674b6749e125bf76a196902c994bfac15e65 Gerrit-Change-Number: 76576 Gerrit-PatchSet: 14 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:08:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add wifi sar table
by Jamie Chen (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Eric Lai, Ian Feng, Sumeet R Pawnikar, Tarun Tuli. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76576?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add wifi sar table ...................................................................... Patch Set 14: Code-Review+1 (2 comments) File src/mainboard/google/brya/Kconfig.name: https://review.coreboot.org/c/coreboot/+/76576/comment/d14f337b_cc09aeb4 : PS12, Line 399: <<<<<<< PATCH SET (886fd9 mb/google/nissa/var/craaskov: Add wifi sar table) > fix this... Done File src/mainboard/google/brya/variants/craaskov/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76576/comment/6243e26a_03443db7 : PS12, Line 5: > no need warp here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21f674b6749e125bf76a196902c994bfac15e65 Gerrit-Change-Number: 76576 Gerrit-PatchSet: 14 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add wifi sar table
by Eric Lai (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, Jamie Chen, Sumeet R Pawnikar, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76576?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add wifi sar table ...................................................................... Patch Set 12: (2 comments) File src/mainboard/google/brya/Kconfig.name: https://review.coreboot.org/c/coreboot/+/76576/comment/d91651ca_0ecf7f72 : PS12, Line 399: <<<<<<< PATCH SET (886fd9 mb/google/nissa/var/craaskov: Add wifi sar table) fix this... File src/mainboard/google/brya/variants/craaskov/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76576/comment/ef35e062_a5fac779 : PS12, Line 5: no need warp here. -- To view, visit https://review.coreboot.org/c/coreboot/+/76576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21f674b6749e125bf76a196902c994bfac15e65 Gerrit-Change-Number: 76576 Gerrit-PatchSet: 12 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add wifi sar table
by Jamie Chen (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Eric Lai, Ian Feng, Jamie Chen, Sumeet R Pawnikar, Tarun Tuli. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76576?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add wifi sar table ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Patchset: PS11: > please fix the conflict Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76576?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21f674b6749e125bf76a196902c994bfac15e65 Gerrit-Change-Number: 76576 Gerrit-PatchSet: 12 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 02:02:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add DPTF parameters
by Van Chen (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Derek Huang, Dtrain Hsu, Ian Feng, John Su, Rex Chou, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli. Van Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76712?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add DPTF parameters ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/76712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d9e1ad2e2fa98757d76578956101a482073885e Gerrit-Change-Number: 76712 Gerrit-PatchSet: 6 Gerrit-Owner: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 01:56:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023