coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: mb/google/rex: Create karis4es variant
by Jakub Czapiga (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Sumeet R Pawnikar, YH Lin. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76761?usp=email ) Change subject: mb/google/rex: Create karis4es variant ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76761/comment/9459c6ee_52197a57 : PS2, Line 15: WIP, Not tested yet > Need more information. […] Jenkins succeeded and it builds all available boards, so it should be fine. @Eran can you try commands below just to be sure? ``` make crosgcc-i386 -j $(nproc) util/abuild/abuild -p none -t google/rex -b karis4es -x -a util/abuild/abuild -p none -t google/rex -b karis -x -a ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/76761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I854fee7206528a235f027ff8ec98593a02be4806 Gerrit-Change-Number: 76761 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 09:24:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Create karis4es variant
by Subrata Banik (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76761?usp=email ) Change subject: mb/google/rex: Create karis4es variant ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76761/comment/49599720_46a0cab3 : PS2, Line 15: WIP, Not tested yet > Need more information. > Is it built successfully? @Eran, can you please address this cmt? -- To view, visit https://review.coreboot.org/c/coreboot/+/76761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I854fee7206528a235f027ff8ec98593a02be4806 Gerrit-Change-Number: 76761 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 09:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Create karis4es variant
by Tyler Wang (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, YH Lin. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76761?usp=email ) Change subject: mb/google/rex: Create karis4es variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I854fee7206528a235f027ff8ec98593a02be4806 Gerrit-Change-Number: 76761 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 09:13:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Sumeet R Pawnikar (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Nick Vaccaro, Paul Menzel, Peter Ou, Tarun Tuli, Zhuohao Lee. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76769/comment/3ea3eed5_f65c1986 : PS3, Line 10: suggestion Are these values based on any document ? If yes, please add document reference number/ID here. -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 09:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Revert "soc/intel/apollolake: handle p2sb quirks"
by Sean Rhodes (Code Review) 04 Aug '23

04 Aug '23

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76717?usp=email ) Change subject: Revert "soc/intel/apollolake: handle p2sb quirks" ...................................................................... Abandoned Wrong -- To view, visit https://review.coreboot.org/c/coreboot/+/76717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I831e63c3fb7ab48d61dca9a01bc86a72a88370a1 Gerrit-Change-Number: 76717 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Eric Lai (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Nick Vaccaro, Paul Menzel, Peter Ou, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 08:34:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Ren Kuo (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Eric Lai, Nick Vaccaro, Paul Menzel, Peter Ou, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 08:32:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Derek Huang (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Eric Lai, Nick Vaccaro, Paul Menzel, Peter Ou, Ren Kuo, Tarun Tuli. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 08:28:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/alderlake/chip.h: Use boolean type where applicable
by Michael Strosche (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Felix Singer, Subrata Banik, Tarun Tuli. Hello Felix Singer, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76830?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/alderlake/chip.h: Use boolean type where applicable ...................................................................... soc/intel/alderlake/chip.h: Use boolean type where applicable Change-Id: If26184058536590b70bbb03209913118307ff6c5 Signed-off-by: Michael Strosche <michael.strosche(a)gmail.com> --- M src/soc/intel/alderlake/chip.h 1 file changed, 25 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/76830/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/76830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If26184058536590b70bbb03209913118307ff6c5 Gerrit-Change-Number: 76830 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Strosche <michael.strosche(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: nb/intel/sandybridge: Rework nb resource reading
by Angel Pons (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76274?usp=email ) Change subject: nb/intel/sandybridge: Rework nb resource reading ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76274/comment/ffa2fa7b_0c3269f1 : PS4, Line 10: UMA Which function are you referring to? Note that "UMA" in the code refers to the ME stolen memory range just below TOM File src/northbridge/intel/sandybridge/northbridge.c: https://review.coreboot.org/c/coreboot/+/76274/comment/f36402c7_5da8ab7a : PS2, Line 151: mmio_from_to(dev, index++, me_base, tom); > This seems weird and potentially crossing 4GiB boundary? ME UMA is placed just below TOM (Top Of Memory), and TOM is the total installed DRAM capacity. ME UMA is 32 MiB or 64 MiB (can't remember), DIMM sizes are powers of 2 and this platform supports up to 4 DIMMs: no combination of DIMMs can result in ME UMA crossing the 4 GiB boundary. Then again, the code is quite confusing. File src/northbridge/intel/sandybridge/northbridge.c: https://review.coreboot.org/c/coreboot/+/76274/comment/395ef625_e0a758de : PS3, Line 161: printk(BIOS_DEBUG, "DPR base 0x%08lx size %luM\n", dpr_base, dpr_size / MiB); > clang throws this, gcc does not: […] `uintptr_t` is supposed to be printed using the `PRIxPTR` macro. For `size_t`, the correct way to print is with `%zu` (or `%zx` for hex). -- To view, visit https://review.coreboot.org/c/coreboot/+/76274?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64c0b0f6e2c62e764bbeb9e4ea88d42ccdd3e056 Gerrit-Change-Number: 76274 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 07:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023