coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yidi Lin (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email ) Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76919/comment/c8148c36_093767a1 : PS1, Line 15: check timestamps by cbmem. > Depend on CL:4747539 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 11:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yidi Lin (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76919?usp=email to look at the new patch set (#3). Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... soc/mediatek/mt8188: Support ARM arch timer Use ARM architectual timer by initializing frequency to 13 MHz. Since system timer is the source of the architectual timer, we also call `timer_prepare` in `init_timer`. BUG=b:229800119 TEST=run `suite:faft_bios` to verify the firmware stability. check timestamps by cbmem. Depend on CL:4747539 Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/mt8188/Kconfig M src/soc/mediatek/mt8188/Makefile.inc A src/soc/mediatek/mt8188/timer.c 3 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/76919/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yidi Lin (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76919?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... soc/mediatek/mt8188: Support ARM arch timer Use ARM architectual timer by initializing frequency to 13 MHz. Since system timer is the source of the architectual timer, we also call `timer_prepare` in `init_timer`. BUG=b:229800119 TEST=run `suite:faft_bios` to verify the firmware stability. check timestamps by cbmem. Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/mt8188/Kconfig M src/soc/mediatek/mt8188/Makefile.inc A src/soc/mediatek/mt8188/timer.c 3 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/76919/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/rex/var/screebo: Update DTT thermal settings for thermal co...
by Kun Liu (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli, yunhao wang. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76678?usp=email ) Change subject: mb/google/rex/var/screebo: Update DTT thermal settings for thermal control ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/rex/variants/screebo/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76678/comment/20a1df87_099a95e6 : PS1, Line 219: 40000, : .max_power = 40000 > I've added comment on this bug, share details. Thanks. please see https://partnerissuetracker.corp.google.com/issues/291217859#comment9 -- To view, visit https://review.coreboot.org/c/coreboot/+/76678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e6ad653157dc87a7d87b5ffc4f9590991a7c284 Gerrit-Change-Number: 76678 Gerrit-PatchSet: 5 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yunhao wang <wangyunhao(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: yunhao wang <wangyunhao(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 11:12:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: yunhao wang <wangyunhao(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Comment-In-Reply-To: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Sumeet R Pawnikar (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Nick Vaccaro, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76769/comment/391176eb_5fa90c53 : PS3, Line 7: brask This should be brya, isn't it? File src/mainboard/google/brya/variants/kuldax/ramstage.c: https://review.coreboot.org/c/coreboot/+/76769/comment/2e42ffa3_a6ad8f03 : PS3, Line 19: 100000 Add comment for this PL4 value suggested by thermal team which is different from the reference document 686872. https://review.coreboot.org/c/coreboot/+/76769/comment/2a11af7e_7bfd9801 : PS3, Line 43: { PCI_DID_INTEL_RPL_P_ID_5, 15, 138 }, : { PCI_DID_INTEL_RPL_P_ID_4, 15, 138 }, : { PCI_DID_INTEL_RPL_P_ID_3, 15, 138 }, I'm not clear why are we maintaining two separate structures to update the same values. If someone miss to update either one, it might create an issue in the future. We might need to come up with better approach for adding these new values. It seems originally this revise was added to differentiate for 65W BJ power at line 78. -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 10:58:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yu-Ping Wu (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76919/comment/f5f346e5_e4b0be3c : PS1, Line 15: check timestamps by cbmem. Depend on CL:4747539 -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 10:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yu-Ping Wu (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email ) Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/soc/mediatek/mt8188/Kconfig: https://review.coreboot.org/c/coreboot/+/76919/comment/1b0bfda2_a3a243e4 : PS1, Line 16: select ARM64_USE_ARCH_TIMER > Shouldn't we select this from chromium overlay? We can't because ARM64_USE_ARCH_TIMER has no prompt string. File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76919/comment/77318f4f_ac486001 : PS1, Line 9: all-y += timer.c ../common/timer_prepare.c > Add timer.c if ARM64_USE_ARCH_TIMER. Otherwise common/timer.c. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 10:38:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yu-Ping Wu (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email ) The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now. Change subject: soc/mediatek/mt8188: Support ARM arch timer ...................................................................... Patch Set 1: -Code-Review (2 comments) File src/soc/mediatek/mt8188/Kconfig: https://review.coreboot.org/c/coreboot/+/76919/comment/1708880d_ff7b1257 : PS1, Line 16: select ARM64_USE_ARCH_TIMER Shouldn't we select this from chromium overlay? File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76919/comment/ad883add_46c5dc3a : PS1, Line 9: all-y += timer.c ../common/timer_prepare.c Add timer.c if ARM64_USE_ARCH_TIMER. Otherwise common/timer.c. -- To view, visit https://review.coreboot.org/c/coreboot/+/76919?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86 Gerrit-Change-Number: 76919 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 10:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Support ARM arch timer
by Yu-Ping Wu (Code Review) 04 Aug '23

04 Aug '23

1 0

[S] Change in coreboot[master]: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
by Peter Ou (Code Review) 04 Aug '23

04 Aug '23

Attention is currently required from: Bob Moragues, David Wu, Nick Vaccaro, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee. Peter Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email ) Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76769/comment/2c748db0_27c650d2 : PS3, Line 10: suggestion > Are these values based on any document ? If yes, please add document reference number/ID here. Hi Sumeet this change base on customer's request, please refer to the link as below https://partnerissuetracker.corp.google.com/issues/292471206 -- To view, visit https://review.coreboot.org/c/coreboot/+/76769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d Gerrit-Change-Number: 76769 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 09:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023