Attention is currently required from: Hannah Williams, Jamie Ryu, Kapil Porwal, Tarun Tuli, Wonkyu Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76124?usp=email )
Change subject: soc/intel/meteorlake: Report CPU clock info
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
honestly i don;t see any value additional to print the CPU freq.
Already ramstage has an API to show the same msg
```CPU: frequency set to 4200 MHz```
--
To view, visit https://review.coreboot.org/c/coreboot/+/76124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b056fb8db04eca345dd7a240d03463de7c59fc2
Gerrit-Change-Number: 76124
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 07:52:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Henry Sun, Tarun Tuli, Yunlong Jia.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/f3e6fabd_dccd1ba0 :
PS3, Line 168: probed
detect
https://review.coreboot.org/c/coreboot/+/76013/comment/c7c9fdb5_660082bb :
PS3, Line 176: device i2c 0x10 on end
do you have stop_gpio?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76013?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd9788a75f9c342f85d6e1a3d54327d64797dd8
Gerrit-Change-Number: 76013
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 07:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Henry Sun, Tarun Tuli, Yunlong Jia.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/9c4fbeda_3dc603f5 :
PS1, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # USB2_A1
: register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WFC
: register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for PCIe WLAN
: register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for CNVi WLAN
:
: register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/3 Type A port A1
Don't you need these to enable the USB ports?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76013?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd9788a75f9c342f85d6e1a3d54327d64797dd8
Gerrit-Change-Number: 76013
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 07:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Kangheui Won, Reka Norman, Simon Yang, Tarun Tuli, Yunlong Jia.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75872?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add GPIO table for gothrax
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75872?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If852c7a30edb9fb778872414cb15dc3446aebc55
Gerrit-Change-Number: 75872
Gerrit-PatchSet: 9
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 07:15:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, John Zhao, Kapil Porwal, Marx Wang, Subrata Banik, Tarun Tuli.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76126?usp=email )
Change subject: soc/intel/meteorlake: remove unused tcss mailbox code
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76126/comment/aa4b1935_5193b442 :
PS1, Line 16: TEST
> Can it be more like […]
Done
i also tested type-c function on screebo. type-c display and usb are still working after suspend/resume
--
To view, visit https://review.coreboot.org/c/coreboot/+/76126?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a4b26c38ec3f5fe1d81fd70f8c2196d0e5b84c3
Gerrit-Change-Number: 76126
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 07:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, John Zhao, Kane Chen, Marx Wang, Subrata Banik, Tarun Tuli.
Hello Jakub Czapiga, John Zhao, Kapil Porwal, Marx Wang, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76126?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/meteorlake: remove unused tcss mailbox code
......................................................................
soc/intel/meteorlake: remove unused tcss mailbox code
In mtl, there is no MAILBOX_BIOS_CMD_TCSS_DEVEN_INTERFACE
So, this patch removes unused code related to
MAILBOX_BIOS_CMD_TCSS_DEVEN_INTERFACE
ADL also removes this code, see cl:62861
BUG=b:288976547
TEST=Tested on Screebo and DP/USB are working as expected after suspend/resume
Change-Id: I5a4b26c38ec3f5fe1d81fd70f8c2196d0e5b84c3
Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
---
M src/soc/intel/meteorlake/acpi/tcss.asl
1 file changed, 1 insertion(+), 124 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/76126/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76126?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a4b26c38ec3f5fe1d81fd70f8c2196d0e5b84c3
Gerrit-Change-Number: 76126
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/coreboot/+/76141?usp=email
to review the following change.
Change subject: WIP:vboot: The hash read out are all 0 in in S3 resume
......................................................................
WIP:vboot: The hash read out are all 0 in in S3 resume
Change-Id: I48aa8eda74999ecfb95e31c642d332f6e978bd69
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/security/vboot/vboot_logic.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/76141/1
diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c
index 53314b2..4c0b01c 100644
--- a/src/security/vboot/vboot_logic.c
+++ b/src/security/vboot/vboot_logic.c
@@ -179,7 +179,7 @@
timestamp_add_now(TS_HASH_BODY_END);
- return handle_digest_result(hash_digest, hash_digest_sz);
+ return VB2_SUCCESS;
}
static uint32_t extend_pcrs(struct vb2_context *ctx)
--
To view, visit https://review.coreboot.org/c/coreboot/+/76141?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48aa8eda74999ecfb95e31c642d332f6e978bd69
Gerrit-Change-Number: 76141
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newchange
Attention is currently required from: Caveh Jalali, Jakub Czapiga, Subrata Banik, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76137?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for kb8010
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76137/comment/80c4a55f_4129feae :
PS1, Line 17: reworked kb8010 DB
Which rework?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76137?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad093e27617b80f8301008deb00b57fb9b3a48ba
Gerrit-Change-Number: 76137
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Jun 2023 06:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla, Subrata Banik.
Hello Anil Kumar K, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75760?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins)
Change subject: elog: Add PSR backup eventlog messages
......................................................................
elog: Add PSR backup eventlog messages
This patch adds eventlog messages for the below scenarios:
1. To indicate success or failure of PSR data backup command
2. To indicate the loss PSR data when CSE update is corrupted and data
clear command is issued to clear the data.
TEST=Verify elog event added after PSR data backup command is sent
cse_lite: PSR_HECI_FW_DOWNGRADE_BACKUP command sent
...
ELOG: Event(B9) added with size 10 at 2023-06-27 06:44:49 UTC
Change-Id: I2459a2b941d28a87b6c78f75dbe8779d73328d7a
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/commonlib/bsd/include/commonlib/bsd/elog.h
M src/soc/intel/common/block/cse/cse_lite.c
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/75760/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75760?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2459a2b941d28a87b6c78f75dbe8779d73328d7a
Gerrit-Change-Number: 75760
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jérémy Compostella, Paul Menzel, Sridhar Siricilla.
Krishna P Bhat D has uploaded a new patch set (#43) to the change originally created by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/74577?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
......................................................................
soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
During CSE FW downgrade we erase CSE data. This would result in
Platform Service Record(PSR) data to be erased.
To avoid losing PSR data we need to take a backup before data clear.
This patch sends PSR_HECI_FW_DOWNGRADE_BACKUP HECI command to CSE,
informing the CSE to backup PSR data before a data clear operation
during downgrade.
To track the command send status we use CMOS address location 161.
BUG=b:273207144
TEST=build CB image for google/rex board and check PSR backup command
is being sent during a CSE FW downgrade. Also check PSR data is not
lost/erased after a downgrade using intel PSR tool.
Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
---
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 97 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/74577/43
--
To view, visit https://review.coreboot.org/c/coreboot/+/74577?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 43
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: newpatchset