Attention is currently required from: David Wu, Lucas Chen, Nick Vaccaro, Ren Kuo, Tarun Tuli, Tyler Wang, YH Lin.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75745?usp=email )
Change subject: mb/google/brya/var/osiris: Add Micron MT53E2G32D4NQ-046 WT:C SPD
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c66a18fd94d9a013710fbc6dc7f1533d808392e
Gerrit-Change-Number: 75745
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Sun, 11 Jun 2023 03:18:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75779?usp=email )
Change subject: Switch board_status.sh to use main branch
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The switch to another branch should be announced beforehand as it will break many client setups and maybe even CIs.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75779?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0487014fd49829e0d021533b04df9e8bd1a757a
Gerrit-Change-Number: 75779
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 11 Jun 2023 01:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Jason Glenesk, Julius Werner, Martin L Roth, Stefan Reinauer, Yu-Ping Wu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email )
Change subject: Rename CBFS master header -> CBFS main header
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75707/comment/40bd75f3_c8ba409e :
PS5, Line 9: pupose
typo: purpose
https://review.coreboot.org/c/coreboot/+/75707/comment/3976ebc7_9209f763 :
PS5, Line 9: Calling it the main header is more descriptive of its pupose
: and should therefore be preferred.
I don't think that it's more descriptive, rather more confusing. With "main", it suggests that the actual CBFS header is meant and not the one from bootblock. It also suggests that there is some form of a backup or secondary thing. Both terms are not ideal.
Some alternatives:
* init
* boot (referring to bootblock)
* pointer
Patchset:
PS5:
Unrelated to my other comment, I think the whole discussion about "master vs main" is too political and I rather would avoid both terms where possible. However, as far as I know, that header is deprecated and should be removed anyway. So I would just leave as it is and get rid of it asap. Otherwise, I suggested some alternatives in my other comment.
File Documentation/releases/coreboot-4.2-relnotes.md:
PS5:
I wouldn't change the release notes since they relate to a specific state of the tree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75707?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770
Gerrit-Change-Number: 75707
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Sun, 11 Jun 2023 00:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75798?usp=email )
Change subject: Update cbootimage submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0557e7116052e98266ee1d078a078d698232bb2c
Gerrit-Change-Number: 75798
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:55:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75797?usp=email )
Change subject: Update goswid submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75797?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib399578a20c5c64978edf4b6198439bf6983ea44
Gerrit-Change-Number: 75797
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:54:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75795?usp=email )
Change subject: Update qc_blobs submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75795?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I938b768318d31d5e105d7c98823947cf8c02b195
Gerrit-Change-Number: 75795
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:53:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75784?usp=email )
Change subject: Update arm-trusted-firmware submodule to upstream master
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4008ebfffa1ff5176fa9cfe262cfd1598e6751c7
Gerrit-Change-Number: 75784
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:38:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75786?usp=email )
Change subject: Update libgfxinit submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75786?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a95cc0b8e9dc4bffe8c82f0f53ee411281061b
Gerrit-Change-Number: 75786
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:38:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75791?usp=email )
Change subject: Update amd_blobs submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b40e3de15d4e2ad64274c267eec07c521b1b059
Gerrit-Change-Number: 75791
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:37:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75792?usp=email )
Change subject: Update blobs submodule to upstream master
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75792?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0005c3950bcbdf407c2abfc254123931806952f2
Gerrit-Change-Number: 75792
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Jun 2023 22:36:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment