coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[NoOp] Change in blobs[main]: cpu/intel: update model 306ax microcode from 0x20 to 0x21
by Martin Kepplinger (Code Review) 11 Jun '23

11 Jun '23

Martin Kepplinger has abandoned this change. ( https://review.coreboot.org/c/blobs/+/32166?usp=email ) Change subject: cpu/intel: update model 306ax microcode from 0x20 to 0x21 ...................................................................... Abandoned 0x21 is part of coreboot for a long time already. thanks. -- To view, visit https://review.coreboot.org/c/blobs/+/32166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I4513e06019d833262bc7e3afb38c88f145eb5525 Gerrit-Change-Number: 32166 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: Rename CBFS master header -> CBFS main header
by Stefan Reinauer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Julius Werner, Martin L Roth, Yu-Ping Wu. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email ) Change subject: Rename CBFS master header -> CBFS main header ...................................................................... Patch Set 7: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75707/comment/c0992243_e7682379 : PS5, Line 9: pupose > typo: purpose Done https://review.coreboot.org/c/coreboot/+/75707/comment/07b305fd_ee10a649 : PS5, Line 9: Calling it the main header is more descriptive of its pupose : and should therefore be preferred. > I don't think that it's more descriptive, rather more confusing. […] Your opinion on this is noted. Main suggests that it is the overarching structure that contains values that are relevant for all other entries. Neither of your suggestions catch that, and since nothing is initialized nor pointed to here, and the term boot is somewhat overloaded in this type of project, I think main is still the clearest description. Patchset: PS5: > Unrelated to my other comment, I think the whole discussion about "master vs main" is too political […] I am unclear why you are bringing politics to this discussion. I guess I don't understand why the term main header is political for you, or why you think it should be avoided? Unless the header is removed, we should make sure that it is concise. Feel free to point me to the patches that remove this header, preferably outside of the scope of this patch. File Documentation/releases/coreboot-4.2-relnotes.md: PS5: > I wouldn't change the release notes since they relate to a specific state of the tree. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75707?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770 Gerrit-Change-Number: 75707 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 11 Jun 2023 07:40:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Rename CBFS master header -> CBFS main header
by Stefan Reinauer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Angel Pons, Jason Glenesk, Julius Werner, Martin L Roth, Stefan Reinauer, Yu-Ping Wu. Hello Angel Pons, Felix Singer, Jason Glenesk, Julius Werner, Martin L Roth, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75707?usp=email to look at the new patch set (#6). Change subject: Rename CBFS master header -> CBFS main header ...................................................................... Rename CBFS master header -> CBFS main header Calling it the main header is more descriptive of its puprose and should therefore be preferred. Change-Id: I624da280dd78d707b96897b84768be5f5baf0770 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M Documentation/cbfs.txt M Documentation/mainboard/gigabyte/ga-g41m-es2l.md M Documentation/releases/coreboot-4.2-relnotes.md M payloads/libpayload/arch/x86/rom_media.c M payloads/libpayload/include/cbfs_core.h M payloads/libpayload/libcbfs/cbfs_core.c M src/lib/Makefile.inc R src/lib/cbfs_main_header.c R src/lib/main_header_pointer.c M src/security/vboot/Makefile.inc M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c M util/nvramtool/cbfs.c M util/nvramtool/cbfs.h 15 files changed, 64 insertions(+), 64 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/75707/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/75707?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770 Gerrit-Change-Number: 75707 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: Switch board_status.sh to use main branch
by Stefan Reinauer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Felix Singer. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75779?usp=email ) Change subject: Switch board_status.sh to use main branch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The switch to another branch should be announced beforehand as it will break many client setups and […] There is no breakage, as there is actually a very simple recipe to switch over. However, before such a change can be announced, and made, the code should be in place to make it possible. That is what this is. -- To view, visit https://review.coreboot.org/c/coreboot/+/75779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0487014fd49829e0d021533b04df9e8bd1a757a Gerrit-Change-Number: 75779 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Sun, 11 Jun 2023 07:25:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Update qc_blobs submodule to upstream master
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Stefan Reinauer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75795?usp=email ) Change subject: Update qc_blobs submodule to upstream master ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I938b768318d31d5e105d7c98823947cf8c02b195 Gerrit-Change-Number: 75795 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:42:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Update libgfxinit submodule to upstream master
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Stefan Reinauer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75786?usp=email ) Change subject: Update libgfxinit submodule to upstream master ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17a95cc0b8e9dc4bffe8c82f0f53ee411281061b Gerrit-Change-Number: 75786 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:38:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/mb/starlabs: Fix references to documents
by Nicholas Chin (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Felix Singer, Sean Rhodes. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75800?usp=email ) Change subject: doc/mb/starlabs: Fix references to documents ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Note that the common/flashing.md links still don't seem to work, but that seems to be an unrelated issue. They are being rendered as "\[here](common/flashing.md)", which seems to be due to missing closing backticks for the eval_rst block above it. -- To view, visit https://review.coreboot.org/c/coreboot/+/75800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I298370c69edc41a50c859684cc5a2c1dbfc85559 Gerrit-Change-Number: 75800 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Update intel-sec-tools submodule to upstream master
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75508?usp=email ) Change subject: Update intel-sec-tools submodule to upstream master ...................................................................... Abandoned see 75785 -- To view, visit https://review.coreboot.org/c/coreboot/+/75508?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d733e36a8ffea25c426b3bfb482771f68e1d463 Gerrit-Change-Number: 75508 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75507?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Abandoned see 75784 -- To view, visit https://review.coreboot.org/c/coreboot/+/75507?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I412de5518c1dbde2f0ef950ff4837ab86e0a1106 Gerrit-Change-Number: 75507 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Stefan Reinauer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75784?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75784?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4008ebfffa1ff5176fa9cfe262cfd1598e6751c7 Gerrit-Change-Number: 75784 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:23:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023