coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: doc/Makefile: Remove superfluous quotation marks fixing syntax error
by Elyes Haouas (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Felix Singer, Martin L Roth, Nicholas Chin. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75799?usp=email ) Change subject: doc/Makefile: Remove superfluous quotation marks fixing syntax error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Gerrit-Change-Number: 75799 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:17:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Append per-board ccache statistics in log
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Kyösti Mälkki, Martin L Roth, Nico Huber, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75087?usp=email ) Change subject: Append per-board ccache statistics in log ...................................................................... Patch Set 5: (2 comments) Patchset: PS1: > Using -f to test for the presence of a generated file helps to solve the unsupported --show-log-stat […] Any open issues left here? Patchset: PS5: I tested it. Quite cool. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/75087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bab712712f4d6379ec6733fdc55b234e3845da7 Gerrit-Change-Number: 75087 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Append per-board ccache statistics in log
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Kyösti Mälkki, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75087?usp=email ) Change subject: Append per-board ccache statistics in log ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bab712712f4d6379ec6733fdc55b234e3845da7 Gerrit-Change-Number: 75087 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Jun 2023 06:05:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
by Nicholas Chin (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Alexander Couzens, Felix Singer, Paul Menzel. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 2: (1 comment) File src/mainboard/lenovo/m900/mainboard.c: https://review.coreboot.org/c/coreboot/+/74187/comment/bc21ba5c_5f3ff580 : PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ > Would you mind using that for the other files as well? All of these files were originally copied from asrock/h110m so the licence is just leftover from there. I personally have no problem with putting everything under GPL-2.0 or later but is that fine for copied files? -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 11 Jun 2023 05:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Alexander Couzens, Nicholas Chin, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 2: (8 comments) Patchset: PS2: Only looked very quickly over it and found some nits. File src/mainboard/lenovo/m900/Kconfig: https://review.coreboot.org/c/coreboot/+/74187/comment/7f685ab4_2775415e : PS2, Line 5: select BOARD_ROMSIZE_KB_16384 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select HAVE_OPTION_TABLE : select HAVE_CMOS_DEFAULT : select INTEL_GMA_HAVE_VBT : select INTEL_INT15 : select SOC_INTEL_SKYLAKE : select SKYLAKE_SOC_PCH_H : select SUPERIO_NUVOTON_COMMON_PRE_RAM : select MAINBOARD_HAS_LIBGFXINIT ``` select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select SKYLAKE_SOC_PCH_H select SOC_INTEL_SKYLAKE select SUPERIO_NUVOTON_COMMON_PRE_RAM ``` https://review.coreboot.org/c/coreboot/+/74187/comment/a1bd1ed6_c17fc8cd : PS2, Line 27: hex Remove File src/mainboard/lenovo/m900/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74187/comment/1a49d6bb_6a6ba396 : PS2, Line 21: r Move that under iGPU https://review.coreboot.org/c/coreboot/+/74187/comment/c26d4242_0b9029c2 : PS2, Line 155: # Set LPC Serial IRQ mode Seems superfluous too https://review.coreboot.org/c/coreboot/+/74187/comment/47034b3b_9ddcb1cf : PS2, Line 157: Remove superfluous lines https://review.coreboot.org/c/coreboot/+/74187/comment/0cfa94ce_276f7705 : PS2, Line 159: # LPC Interface It's already in line 150 File src/mainboard/lenovo/m900/mainboard.c: https://review.coreboot.org/c/coreboot/+/74187/comment/0bd34beb_b25e3700 : PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ Would you mind using that for the other files as well? -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 11 Jun 2023 05:38:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
by Nicholas Chin (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Alexander Couzens, Paul Menzel. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74187/comment/6df9de6e_8639749b : PS1, Line 7: mb/lenovo: Add Thinkcentre M900 > Maybe add the chipset/socket in brackets? Done https://review.coreboot.org/c/coreboot/+/74187/comment/b60ee414_494fa3b5 : PS1, Line 15: - Boots to Linux using SeaBIOS and EDK2 > Please mention the versions. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 11 Jun 2023 05:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
by Nicholas Chin (Code Review) 11 Jun '23

11 Jun '23

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Jun 2023 05:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: doc/Makefile: Remove superfluous quotation marks fixing syntax error
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Attention is currently required from: Martin L Roth, Nicholas Chin. Hello Martin L Roth, Nicholas Chin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75799?usp=email to look at the new patch set (#2). Change subject: doc/Makefile: Remove superfluous quotation marks fixing syntax error ...................................................................... doc/Makefile: Remove superfluous quotation marks fixing syntax error Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/75799/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Gerrit-Change-Number: 75799 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: doc/mb/starlabs: Fix references to documents
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75800?usp=email ) Change subject: doc/mb/starlabs: Fix references to documents ...................................................................... doc/mb/starlabs: Fix references to documents Some references are pointing to non-existing paths. Fix that. Change-Id: I298370c69edc41a50c859684cc5a2c1dbfc85559 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/starlabs/labtop_cml.md M Documentation/mainboard/starlabs/labtop_kbl.md M Documentation/mainboard/starlabs/lite_glk.md M Documentation/mainboard/starlabs/lite_glkr.md M Documentation/mainboard/starlabs/starbook_adl.md M Documentation/mainboard/starlabs/starbook_tgl.md 6 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75800/1 diff --git a/Documentation/mainboard/starlabs/labtop_cml.md b/Documentation/mainboard/starlabs/labtop_cml.md index 0a493f8..f6db913 100644 --- a/Documentation/mainboard/starlabs/labtop_cml.md +++ b/Documentation/mainboard/starlabs/labtop_cml.md @@ -41,7 +41,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_labtop_cml` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_labtop_cml` as config file. ## Flashing coreboot @@ -64,4 +64,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/labtop_kbl.md b/Documentation/mainboard/starlabs/labtop_kbl.md index f68b95e..6669a63 100644 --- a/Documentation/mainboard/starlabs/labtop_kbl.md +++ b/Documentation/mainboard/starlabs/labtop_kbl.md @@ -38,7 +38,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_labtop_kbl` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_labtop_kbl` as config file. ## Flashing coreboot @@ -61,4 +61,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/lite_glk.md b/Documentation/mainboard/starlabs/lite_glk.md index 6294b45..25ee703 100644 --- a/Documentation/mainboard/starlabs/lite_glk.md +++ b/Documentation/mainboard/starlabs/lite_glk.md @@ -37,7 +37,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_lite_glk` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_lite_glk` as config file. ## Flashing coreboot @@ -60,4 +60,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/lite_glkr.md b/Documentation/mainboard/starlabs/lite_glkr.md index 57749d9..9920d22 100644 --- a/Documentation/mainboard/starlabs/lite_glkr.md +++ b/Documentation/mainboard/starlabs/lite_glkr.md @@ -37,7 +37,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_lite_glkr` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_lite_glkr` as config file. ## Flashing coreboot @@ -60,4 +60,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/starbook_adl.md b/Documentation/mainboard/starlabs/starbook_adl.md index 814dfc6..6f51be8 100644 --- a/Documentation/mainboard/starlabs/starbook_adl.md +++ b/Documentation/mainboard/starlabs/starbook_adl.md @@ -40,7 +40,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_starbook_adl` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_starbook_adl` as config file. ### Preliminaries @@ -85,4 +85,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/starbook_tgl.md b/Documentation/mainboard/starlabs/starbook_tgl.md index 5992d6c..d8b8563 100644 --- a/Documentation/mainboard/starlabs/starbook_tgl.md +++ b/Documentation/mainboard/starlabs/starbook_tgl.md @@ -40,7 +40,7 @@ ## Building coreboot -Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_starbook_tgl` as config file. +Please follow the [Star Labs build instructions](common/building.md) to build coreboot, using `config.starlabs_starbook_tgl` as config file. ## Flashing coreboot @@ -63,4 +63,4 @@ | External flashing | yes | +---------------------+------------+ -Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. +Please see [here](common/flashing.md) for instructions on how to flash with fwupd. -- To view, visit https://review.coreboot.org/c/coreboot/+/75800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I298370c69edc41a50c859684cc5a2c1dbfc85559 Gerrit-Change-Number: 75800 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: Makefile: Remove superfluous quotation marks fixing syntax error
by Felix Singer (Code Review) 11 Jun '23

11 Jun '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75799?usp=email ) Change subject: Makefile: Remove superfluous quotation marks fixing syntax error ...................................................................... Makefile: Remove superfluous quotation marks fixing syntax error Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/75799/1 diff --git a/Documentation/Makefile b/Documentation/Makefile index 19b1f80..60a3f35 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -45,7 +45,7 @@ $(PDFLATEX) corebootBuildingGuide.tex sphinx: $(SPHINXDIR) - $(MAKE) -f Makefile.sphinx html BUILDDIR="$(SPHINXDIR)"" + $(MAKE) -f Makefile.sphinx html BUILDDIR="$(SPHINXDIR)" clean-sphinx: $(MAKE) -f Makefile.sphinx clean BUILDDIR="$(SPHINXDIR)" -- To view, visit https://review.coreboot.org/c/coreboot/+/75799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Gerrit-Change-Number: 75799 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023