coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: arch/x86/smbios: Add weak function for BIOS Vendor in SMBIOS Type0
by Subrata Banik (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Eric Lai, Felix Held, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin Roth, Nill Ge, Yiwei Tang, Ziang Wang, niehaitao(a)bytedance.com. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email ) Change subject: arch/x86/smbios: Add weak function for BIOS Vendor in SMBIOS Type0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @Martin and Felix, Do we allow to change bios vendor? this effort might allow IBVs to mention their contribution towards platform ? -- To view, visit https://review.coreboot.org/c/coreboot/+/75737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dfcca338ffc48b150c966b9aefcefe928704d24 Gerrit-Change-Number: 75737 Gerrit-PatchSet: 1 Gerrit-Owner: Yiwei Tang Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Yiwei Tang Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:48:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/arch/x86/smbios.c: Change smbios_fill_dimm_serial_number function...
by Subrata Banik (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Eric Lai, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Yiwei Tang, Ziang Wang, lichenchen.carl, niehaitao(a)bytedance.com. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75736?usp=email ) Change subject: src/arch/x86/smbios.c: Change smbios_fill_dimm_serial_number function to weak ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Serial should read by SPD, why do you want to overwrite it? +2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc28a56a577f98a2974407175783e32a1e234f86 Gerrit-Change-Number: 75736 Gerrit-PatchSet: 1 Gerrit-Owner: Yiwei Tang Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Yiwei Tang Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: doc/Makefile: Remove superfluous quotation marks fixing syntax error
by Felix Singer (Code Review) 12 Jun '23

12 Jun '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75799?usp=email ) Change subject: doc/Makefile: Remove superfluous quotation marks fixing syntax error ...................................................................... doc/Makefile: Remove superfluous quotation marks fixing syntax error Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75799 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Daniel Maslowski <info(a)orangecms.org> --- M Documentation/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified Felix Held: Looks good to me, approved Elyes Haouas: Looks good to me, approved Daniel Maslowski: Looks good to me, but someone else must approve diff --git a/Documentation/Makefile b/Documentation/Makefile index 19b1f80..60a3f35 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -45,7 +45,7 @@ $(PDFLATEX) corebootBuildingGuide.tex sphinx: $(SPHINXDIR) - $(MAKE) -f Makefile.sphinx html BUILDDIR="$(SPHINXDIR)"" + $(MAKE) -f Makefile.sphinx html BUILDDIR="$(SPHINXDIR)" clean-sphinx: $(MAKE) -f Makefile.sphinx clean BUILDDIR="$(SPHINXDIR)" -- To view, visit https://review.coreboot.org/c/coreboot/+/75799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c269248a3a1e078204882d04964fd5af4b5f51a Gerrit-Change-Number: 75799 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: drivers/pc80/pc/i8254.c: Initialize timer 1 in mode 2
by Petr Cvek (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Paul Menzel, Stefan Reinauer. Petr Cvek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65809?usp=email ) Change subject: drivers/pc80/pc/i8254.c: Initialize timer 1 in mode 2 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Petr, how did you test this patch? It is just the configuration matching the documentation. Originally I've stumbled upon timer1 because it wasn't enabled in SeaBIOS and it caused Windows 98SE instalation CD to hang (ASPI2DOS.SYS and KEYB.COM depends on correctly working timer1 to be used as a delay loop). Setting it up as described in the datasheet causes win98se to correctly proceed. I don't remember if mode 3 actually worked too, it seems it should on i8254 but intel datasheet forbids it on ICH7. So my idea was to match the safest settings. -- To view, visit https://review.coreboot.org/c/coreboot/+/65809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fa969a5432d626aba298a2e020ec19f8da25d59 Gerrit-Change-Number: 65809 Gerrit-PatchSet: 4 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/mb/starlabs: Fix references to documents
by Felix Singer (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Nicholas Chin, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75800?usp=email ) Change subject: doc/mb/starlabs: Fix references to documents ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Note that the common/flashing. […] Fixed in CB:75805 -- To view, visit https://review.coreboot.org/c/coreboot/+/75800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I298370c69edc41a50c859684cc5a2c1dbfc85559 Gerrit-Change-Number: 75800 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:40:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: doc/mb/starlabs: Add missing closing backticks for eval_rst blocks
by Felix Singer (Code Review) 12 Jun '23

12 Jun '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75805?usp=email ) Change subject: doc/mb/starlabs: Add missing closing backticks for eval_rst blocks ...................................................................... doc/mb/starlabs: Add missing closing backticks for eval_rst blocks Change-Id: I4cffd141ef74e20ef13b204955b44c07acd88edf Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/starlabs/labtop_cml.md M Documentation/mainboard/starlabs/labtop_kbl.md M Documentation/mainboard/starlabs/lite_glk.md M Documentation/mainboard/starlabs/lite_glkr.md M Documentation/mainboard/starlabs/starbook_adl.md M Documentation/mainboard/starlabs/starbook_tgl.md 6 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/75805/1 diff --git a/Documentation/mainboard/starlabs/labtop_cml.md b/Documentation/mainboard/starlabs/labtop_cml.md index 0a493f8..54ad420 100644 --- a/Documentation/mainboard/starlabs/labtop_cml.md +++ b/Documentation/mainboard/starlabs/labtop_cml.md @@ -63,5 +63,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/labtop_kbl.md b/Documentation/mainboard/starlabs/labtop_kbl.md index f68b95e..ca11006 100644 --- a/Documentation/mainboard/starlabs/labtop_kbl.md +++ b/Documentation/mainboard/starlabs/labtop_kbl.md @@ -60,5 +60,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/lite_glk.md b/Documentation/mainboard/starlabs/lite_glk.md index 6294b45..41605ea 100644 --- a/Documentation/mainboard/starlabs/lite_glk.md +++ b/Documentation/mainboard/starlabs/lite_glk.md @@ -59,5 +59,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/lite_glkr.md b/Documentation/mainboard/starlabs/lite_glkr.md index 57749d9..1427e1d 100644 --- a/Documentation/mainboard/starlabs/lite_glkr.md +++ b/Documentation/mainboard/starlabs/lite_glkr.md @@ -59,5 +59,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/starbook_adl.md b/Documentation/mainboard/starlabs/starbook_adl.md index 814dfc6..8a770b2 100644 --- a/Documentation/mainboard/starlabs/starbook_adl.md +++ b/Documentation/mainboard/starlabs/starbook_adl.md @@ -84,5 +84,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. diff --git a/Documentation/mainboard/starlabs/starbook_tgl.md b/Documentation/mainboard/starlabs/starbook_tgl.md index 5992d6c..817cb72 100644 --- a/Documentation/mainboard/starlabs/starbook_tgl.md +++ b/Documentation/mainboard/starlabs/starbook_tgl.md @@ -62,5 +62,6 @@ +---------------------+------------+ | External flashing | yes | +---------------------+------------+ +``` Please see [here](../common/flashing.md) for instructions on how to flash with fwupd. -- To view, visit https://review.coreboot.org/c/coreboot/+/75805?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cffd141ef74e20ef13b204955b44c07acd88edf Gerrit-Change-Number: 75805 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init
by Ziang Wang (Code Review) 12 Jun '23

12 Jun '23

Ziang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75739?usp=email ) Change subject: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init ...................................................................... Abandoned Duplicate with https://review.coreboot.org/c/coreboot/+/69310/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b2b15170c3ac9785b6e1cc7f93738f7badc7435 Gerrit-Change-Number: 75739 Gerrit-PatchSet: 2 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init
by Ziang Wang (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Johnny Lin, Yiwei Tang. Ziang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75739?usp=email ) Change subject: drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hi Ziang, […] Thanks Johnny, will be dropping this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/75739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b2b15170c3ac9785b6e1cc7f93738f7badc7435 Gerrit-Change-Number: 75739 Gerrit-PatchSet: 2 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Yiwei Tang Gerrit-Comment-Date: Mon, 12 Jun 2023 04:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Rename CBFS master header -> CBFS main header
by Felix Singer (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Angel Pons, Jason Glenesk, Julius Werner, Martin L Roth, Stefan Reinauer, Yu-Ping Wu. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email ) Change subject: Rename CBFS master header -> CBFS main header ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File Documentation/releases/coreboot-4.2-relnotes.md: https://review.coreboot.org/c/coreboot/+/75707/comment/cfbdbd6d_24c9c01d : PS7, Line 74: main header one "main" left -- To view, visit https://review.coreboot.org/c/coreboot/+/75707?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770 Gerrit-Change-Number: 75707 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/xeon_sp: Fix HEST table length
by Ziang Wang (Code Review) 12 Jun '23

12 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Nico Huber, Paul Menzel, Tim Chu, Yiwei Tang. Ziang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email ) Change subject: soc/intel/xeon_sp: Fix HEST table length ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75738/comment/3cf17dce_a8b19344 : PS1, Line 11: > Please document, how you found the error and how you tested it. Done Patchset: PS1: > The change looks correct and the surrounding code should work. […] I'm sorry but what is 'ubsan'? -- To view, visit https://review.coreboot.org/c/coreboot/+/75738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db Gerrit-Change-Number: 75738 Gerrit-PatchSet: 2 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yiwei Tang Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yiwei Tang Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 12 Jun 2023 04:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023